Changeset View
Changeset View
Standalone View
Standalone View
effects/blur/blur.cpp
Show First 20 Lines • Show All 327 Lines • ▼ Show 20 Line(s) | 327 | if (gl->isSoftwareEmulation()) { | |||
---|---|---|---|---|---|
328 | return false; | 328 | return false; | ||
329 | } | 329 | } | ||
330 | 330 | | |||
331 | return true; | 331 | return true; | ||
332 | } | 332 | } | ||
333 | 333 | | |||
334 | bool BlurEffect::supported() | 334 | bool BlurEffect::supported() | ||
335 | { | 335 | { | ||
336 | bool supported = effects->isOpenGLCompositing() && GLRenderTarget::supported(); | 336 | bool supported = effects->isOpenGLCompositing() && GLRenderTarget::supported() && GLRenderTarget::blitSupported(); | ||
zzag: IMHO, length of this line is too big now.
```lang=cpp
const bool supported = effects… | |||||
You make a good point, but there are lines already longer than this in blur.cpp anemeth: You make a good point, but there are lines already longer than this in `blur.cpp`
Anyways you… | |||||
337 | 337 | | |||
338 | if (supported) { | 338 | if (supported) { | ||
339 | int maxTexSize; | 339 | int maxTexSize; | ||
340 | glGetIntegerv(GL_MAX_TEXTURE_SIZE, &maxTexSize); | 340 | glGetIntegerv(GL_MAX_TEXTURE_SIZE, &maxTexSize); | ||
341 | 341 | | |||
342 | const QSize screenSize = effects->virtualScreenSize(); | 342 | const QSize screenSize = effects->virtualScreenSize(); | ||
343 | if (screenSize.width() > maxTexSize || screenSize.height() > maxTexSize) | 343 | if (screenSize.width() > maxTexSize || screenSize.height() > maxTexSize) | ||
344 | supported = false; | 344 | supported = false; | ||
▲ Show 20 Lines • Show All 430 Lines • Show Last 20 Lines |
IMHO, length of this line is too big now.
would be better.