Differential D12936 Diff 34353 kcms/workspaceoptions/package/contents/ui/main.qml

Changeset View

Standalone View

View Options

kcms/workspaceoptions/package/contents/ui/main.qml

  • This file was added.
1​/*
2​ * Copyright 2018 Furkan Tokac <furkantokac34@gmail.com>
3​ *
4​ * This program is free software; you can redistribute it and/or modify
5​ * it under the terms of the GNU General Public License as published by
6​ * the Free Software Foundation; either version 2 of the License, or
7​ * (at your option) any later version.
8​ *
9​ * This program is distributed in the hope that it will be useful,
10​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
11​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12​ * GNU General Public License for more details.
13​ *
14​ * You should have received a copy of the GNU General Public License
15​ * along with this program; if not, write to the Free Software
16​ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17​ */
18​import QtQuick 2.7
19​import QtQuick.Controls 1.4 as Controls
20​import QtQuick.Layouts 1.3 as Layouts
21​import QtQuick.Controls.Styles 1.4 as Styles
22​import org.kde.kcm 1.1 as KCM
23​
24​import org.kde.plasma.core 2.0 as PlasmaCore
25​
davidedmundsonUnsubmitted
Done

this is unused in every file

davidedmundson: this is unused in every file
furkantokacAuthorUnsubmitted
Done

Actually it is used. It has "units" in it.

Example

Layouts.ColumnLayout {
    id: maincol
    spacing: units.largeSpacing
furkantokac: Actually it is used. It has "units" in it. Example ``` Layouts.ColumnLayout {…
26​Item {
27​ id: root
28​
29​ Controls.ScrollView {
30​ anchors.fill: parent
31​
32​ Layouts.ColumnLayout {
33​ id: maincol
34​ spacing: units.largeSpacing
35​
36​ // General Settings
37​ Column {
38​ spacing: units.smallSpacing
davidedmundsonUnsubmitted
Done

why is here a column inside a columnlayout?

davidedmundson: why is here a column inside a columnlayout?
furkantokacAuthorUnsubmitted
Done

Items under the "Column" has smallSpacing. Items under the "ColumnLayout" has largeSpacing. Otherwise, it looks bad.

furkantokac: Items under the "Column" has smallSpacing. Items under the "ColumnLayout" has largeSpacing.
39​ leftPadding: units.smallSpacing
40​
41​ Controls.Label {
42​ id: generalSettings
43​ text: i18n("General Settings")
44​ }
davidedmundsonUnsubmitted
Done

i18n

davidedmundson: i18n
furkantokacAuthorUnsubmitted
Done

Thanks, fixing...

furkantokac: Thanks, fixing...
45​
46​ Controls.CheckBox {
47​ id: showToolTips
48​ text: i18n("Display informational tooltips on mouse hover")
49​ onCheckedChanged: kcm.toolTip = checked
50​ }
51​
52​ Controls.CheckBox {
53​ id: showVisualFeedback
54​ text: i18n("Display visual feedback for status changes")
55​ onCheckedChanged: kcm.visualFeedback = checked
56​ }
57​
58​ Connections {
59​ target: kcm
60​ onToolTipChanged: showToolTips.checked = kcm.toolTip
61​ onVisualFeedbackChanged: showVisualFeedback.checked = kcm.visualFeedback
62​ }
63​ }
64​ } // END Layouts.ColumnLayout
65​ } // END Controls.ScrollView
66​} // END Item