Differential D12808 Diff 34136 kmymoney/plugins/onlinetasks/sepa/tasks/sepaonlinetransferimpl.cpp

Changeset View

Standalone View

View Options

kmymoney/plugins/onlinetasks/sepa/tasks/sepaonlinetransferimpl.cpp

Context not available.
156 try { 156​ try {
157 payeeIdentifier ident = originAccountIdentifier(); 157​ payeeIdentifier ident = originAccountIdentifier();
158 iban = ident.data<payeeIdentifiers::ibanBic>()->electronicIban(); 158​ iban = ident.data<payeeIdentifiers::ibanBic>()->electronicIban();
159 } catch (payeeIdentifier::exception&) { 159​ } catch (const payeeIdentifier::empty &) {
160​ } catch (const payeeIdentifier::badCast &) {
christiandUnsubmitted
Not Done

To prevent this kind of code the payeeIdentifier::exception should be kept. This can even save time (now up to two cast are done, previously only one).

christiand: To prevent this kind of code the `payeeIdentifier::exception` should be kept. This can even…
wojnilowiczAuthorUnsubmitted
Not Done

Do we need to catch two exceptions at all? Can't we just catch std::exception?

wojnilowicz: Do we need to catch two exceptions at all? Can't we just catch std::exception?
christiandUnsubmitted
Not Done

Maybe, but we have to decide this for each catch individually. This is a lot of (error prone) work without a significant benefit.

christiand: Maybe, but we have to decide this for each catch individually. This is a lot of (error prone)…
160 } 161​ }
161 162​
162 QSharedPointer<const sepaOnlineTransfer::settings> localSettings = getSettings(); 163​ QSharedPointer<const sepaOnlineTransfer::settings> localSettings = getSettings();
Context not available.