Changeset View
Changeset View
Standalone View
Standalone View
doc/contrib.md
Show All 22 Lines | |||||
23 | 23 | | |||
24 | ### Commit Guidelines | 24 | ### Commit Guidelines | ||
25 | Keeping a clean project history requires that we take care when choosing how we will commit our code.Consider the following when creating commits. ALL COMMITS MUST BE REVIEWED BEFORE PUSHING TO MASTER. | 25 | Keeping a clean project history requires that we take care when choosing how we will commit our code.Consider the following when creating commits. ALL COMMITS MUST BE REVIEWED BEFORE PUSHING TO MASTER. | ||
26 | 26 | | |||
27 | - Follow the [KDE commit guidelines] | 27 | - Follow the [KDE commit guidelines] | ||
28 | - Reviewers: rizzitello, patrickelectric, laysrodrigues, tcanabrava | 28 | - Reviewers: rizzitello, patrickelectric, laysrodrigues, tcanabrava | ||
29 | - Be sure to make things "done" in phabricator. | 29 | - Be sure to make things "done" in phabricator. | ||
30 | - Update your revisions with `arc diff --update <diff number>` | 30 | - Update your revisions with `arc diff --update <diff number>` | ||
31 | - Ammend your local commits to fix review issues. | 31 | - Amend your local commits to fix review issues. | ||
32 | - Revisions require a majority acceptance rate before landing | 32 | - Revisions require a majority acceptance rate before landing | ||
33 | - Land your code with `arc land <branch>` | 33 | - Land your code with `arc land <branch>` | ||
34 | 34 | | |||
35 | [IRC]: https://webchat.freenode.net/ | 35 | [IRC]: https://webchat.freenode.net/ | ||
36 | [Telegram]: telegram.me/KDEAtelier | 36 | [Telegram]: telegram.me/KDEAtelier | ||
37 | [KDE Identity]: https://identity.kde.org/ | 37 | [KDE Identity]: https://identity.kde.org/ | ||
38 | [arcanist]:https://secure.phabricator.com/book/phabricator/article/arcanist/ | 38 | [arcanist]:https://secure.phabricator.com/book/phabricator/article/arcanist/ | ||
39 | [KDE style guidelines]:https://community.kde.org/Policies/Kdelibs_Coding_Style | 39 | [KDE style guidelines]:https://community.kde.org/Policies/Kdelibs_Coding_Style | ||
40 | [KDE commit guidelines]:https://community.kde.org/Policies/Commit_Policy | 40 | [KDE commit guidelines]:https://community.kde.org/Policies/Commit_Policy |