Differential D12679 Diff 33560 shell/softwarerendernotifier.cpp

Changeset View

Standalone View

View Options

shell/softwarerendernotifier.cpp

  • This file was added.
1​#include "softwarerendernotifier.h"
2​#include <QMenu>
3​#include <QIcon>
4​#include <QProcess>
5​#include <QGuiApplication>
6​#include <KLocalizedString>
7​#include <KSharedConfig>
8​#include <KConfigGroup>
9​
10​#include <QQuickWindow>
11​
12​void SoftwareRendererNotifier::notifyIfRelevant()
13​{
14​ if (QQuickWindow::sceneGraphBackend() == QLatin1String("software")) {
15​ auto group = KSharedConfig::openConfig()->group(QStringLiteral("softwarerenderer"));
broulikUnsubmitted
Done

Returns empty string for me, as it's too early in the startup:

\note The return value of this function may still be outdated by
subsequent calls to setSceneGraphBackend() until the first QQuickWindow in the
application has been constructed.

(I verified with QSG_INFO that I'm running software)

broulik: Returns empty string for me, as it's too early in the startup: > \note The return value of this…
davidedmundsonAuthorUnsubmitted
Done

We're not making any subsequent calls to setSceneGraphBackend so that should be fine

Did you set it through the KCM (and hence set in KQuickAddons::QtQuickSettings::init();) or through env vars?

davidedmundson: We're not making any subsequent calls to setSceneGraphBackend so that should be fine Did you…
16​ bool neverShow = group.readEntry("neverShow", false);
17​ if (neverShow) {
18​ return;
19​ }
20​ new SoftwareRendererNotifier(qApp);
21​ }
22​}
23​
24​SoftwareRendererNotifier::SoftwareRendererNotifier(QObject *parent)
25​ : KStatusNotifierItem(parent)
26​{
27​ setTitle(i18n("Software Renderer In Use"));
28​ setToolTipTitle(i18nc("Tooltip telling user their GL drivers are broken", "Software Renderer In Use"));
29​ setToolTipSubTitle(i18nc("Tooltip telling user their GL drivers are broken", "Rendering may be degraded"));
broulikUnsubmitted
Done

This will cause that long text to show up as main text in huge font. Should probably use the subtext so the "Software Renderer In Use" is the tooltip main title

(Also, in some cases the software renderer is actually faster :P how about "performance might be reduced" or something like that?)

broulik: This will cause that long text to show up as main text in huge font. Should probably use the…
30​ setIconByName(QStringLiteral("video-card-inactive"));
31​ setStatus(KStatusNotifierItem::Active);
32​ setStandardActionsEnabled(false);
33​
34​ connect(this, &KStatusNotifierItem::activateRequested, this, []() {
35​ QProcess::startDetached("kcmshell5 qtquicksettings");
36​ });
37​
38​ auto menu = new QMenu; //ownership is transferred in setContextMenu
39​ auto action = new QAction(i18n("Never show again"));
40​ connect(action, &QAction::triggered, this, [this]() {
41​ auto group = KSharedConfig::openConfig()->group(QStringLiteral("softwarerenderer"));
42​ group.writeEntry("neverShow", true);
43​ deleteLater();
44​ });
45​ menu->addAction(action);
46​ setContextMenu(menu);
47​}
48​
49​SoftwareRendererNotifier::~SoftwareRendererNotifier() = default;
broulikUnsubmitted
Done

= default

broulik: `= default`
50​