Differential D12331 Diff 33201 plugins/clang/libclang_include_path.h.cmake

Changeset View

Standalone View

View Options

plugins/clang/libclang_include_path.h.cmake

  • This file was added.
1​/*
2​ This file is part of KDevelop
3​
4​ Copyright 2018 Milian Wolff <mail@milianw.de>
5​
6​ This library is free software; you can redistribute it and/or
7​ modify it under the terms of the GNU Library General Public
8​ License as published by the Free Software Foundation; either
9​ version 2 of the License, or (at your option) any later version.
10​
11​ This library is distributed in the hope that it will be useful,
12​ but WITHOUT ANY WARRANTY; without even the implied warranty of
13​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14​ Library General Public License for more details.
15​
16​ You should have received a copy of the GNU Library General Public License
17​ along with this library; see the file COPYING.LIB. If not, write to
18​ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
19​ Boston, MA 02110-1301, USA.
20​*/
21​
22​#define KDEV_CLANG_BUILTIN_DIR "@CLANG_LIBRARY_DIRS@/clang/@CLANG_VERSION@/include"
apolUnsubmitted
Not Done

Wouldn't it make sense to make it possible to point at the include directory of the clang we are interested in?

apol: Wouldn't it make sense to make it possible to point at the include directory of the clang we…
mwolffAuthorUnsubmitted
Not Done

I don't know what you mean? We are interested in the directory that fits to the libclang we link against.

mwolff: I don't know what you mean? We are interested in the directory that fits to the libclang we…
apolUnsubmitted
Not Done

Okay, doesn't make a lot of sense from my ignorant perspective. :P

It sounds to me like we should be telling about the system we are targetting. In fact, I'm surprised that sysroot isn't necessary.

apol: Okay, doesn't make a lot of sense from my ignorant perspective. :P It sounds to me like we…
mwolffAuthorUnsubmitted
Not Done

I think your understanding of how it should be is the exact opposite of what's actually required :D

While parsing with libclang, we have to use the builtin headers from clang that exactly match the version of libclang we are using. With builtin headers, I mean e.g. /usr/lib/clang/6.0.0/include/xmmintrin.h - this is what we have to use when we parse with libclang 6.0.0. And this is independent of what compiler we actually use for the project we parse, this really is just related to the libclang version we use for parsing.

The reason is that these headers use builtins that are highly compiler and version specific. Trying to use GCCs builtins, or even those from a newer clang will fail in horrible ways (cf. all the bug reports we got).

This also explains why we don't need to specify the sysroot.

mwolff: I think your understanding of how it should be is the exact opposite of what's actually…