Differential D12458 Diff 32841 lib/resize/resizeimagewidget.ui

Changeset View

Standalone View

View Options

lib/resize/resizeimagewidget.ui

1<?xml version="1.0" encoding="UTF-8"?> 1​<?xml version="1.0" encoding="UTF-8"?>
2<ui version="4.0"> 2​<ui version="4.0">
3 <class>ResizeImageWidget</class> 3​ <class>ResizeImageWidget</class>
4 <widget class="QWidget" name="ResizeImageWidget"> 4​ <widget class="QWidget" name="ResizeImageWidget">
5 <property name="geometry"> 5​ <property name="geometry">
6 <rect> 6​ <rect>
7 <x>0</x> 7​ <x>0</x>
8 <y>0</y> 8​ <y>0</y>
9 <width>269</width> 9​ <width>302</width>
10 <height>155</height> 10​ <height>158</height>
11 </rect> 11​ </rect>
12 </property> 12​ </property>
13 <property name="windowTitle"> 13​ <property name="windowTitle">
14 <string>Image Resizing</string> 14​ <string>Resize Image</string>
15 </property> 15​ </property>
16 <layout class="QFormLayout" name="formLayout"> 16​ <layout class="QGridLayout" name="gridLayout">
17 <item row="0" column="0" colspan="2"> ​
18 <widget class="QLabel" name="label_3"> ​
19 <property name="text"> ​
20 <string>Enter the new size for this image.</string> ​
21 </property> ​
22 </widget> ​
23 </item> ​
24 <item row="1" column="0"> 17​ <item row="1" column="0">
25 <widget class="QLabel" name="label"> 18​ <widget class="QLabel" name="label">
26 <property name="font"> ​
27 <font> ​
28 <italic>true</italic> ​
29 </font> ​
30 </property> ​
31 <property name="text"> 19​ <property name="text">
32 <string>Current size:</string> 20​ <string>Current size:</string>
33 </property> 21​ </property>
34 <property name="alignment"> 22​ <property name="alignment">
35 <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set> 23​ <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
36 </property> 24​ </property>
37 </widget> 25​ </widget>
38 </item> 26​ </item>
39 <item row="1" column="1"> 27​ <item row="2" column="1">
40 <layout class="QHBoxLayout" name="horizontalLayout"> 28​ <widget class="QSpinBox" name="mWidthSpinBox">
41 <item> 29​ <property name="sizePolicy">
42 <widget class="QLabel" name="mOriginalWidthLabel"> 30​ <sizepolicy hsizetype="Minimum" vsizetype="Fixed">
43 <property name="font"> 31​ <horstretch>1</horstretch>
44 <font> 32​ <verstretch>0</verstretch>
45 <italic>true</italic> 33​ </sizepolicy>
46 </font> ​
47 </property> 34​ </property>
48 <property name="text"> 35​ <property name="alignment">
49 <string/> 36​ <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
50 </property> 37​ </property>
51 <property name="textInteractionFlags"> 38​ <property name="suffix">
52 <set>Qt::LinksAccessibleByMouse|Qt::TextSelectableByMouse</set> 39​ <string> px</string>
53 </property> 40​ </property>
54 </widget> 41​ <property name="minimum">
55 </item> 42​ <number>1</number>
56 <item> ​
57 <widget class="QLabel" name="label_6"> ​
58 <property name="font"> ​
59 <font> ​
60 <italic>true</italic> ​
61 </font> ​
62 </property> 43​ </property>
huoniUnsubmitted
Not Done

I'm guessing this, and all the other value property tags were added by Qt Designer?
I think we should probably remove them since they are unnecessary.

huoni: I'm guessing this, and all the other `value` property tags were added by Qt Designer? I think…
rkflxAuthorUnsubmitted
Not Done

I added them, so the dialog would look somewhat reasonable with an example in the visual editing mode. Otherwise it was a bit hard to see how the final dialog would look like.

As this value is overwritten by Gwenview later on anyway, I could not find any situation where this is causing harm.

But I can remove it if you want?

rkflx: I added them, so the dialog would look somewhat reasonable with an example in the visual…
huoniUnsubmitted
Not Done

My reasoning was that future devs might wonder why the values are set when they are just overwritten. And less 'code noise' so to speak.
But your reasoning also makes sense.

In the end I don't mind. As you said it does no harm. I'll leave it up to you :)

huoni: My reasoning was that future devs might wonder why the values are set when they are just…
63 <property name="text"> 44​ <property name="maximum">
64 <string notr="true">⨯</string> 45​ <number>99999</number>
46​ </property>
47​ <property name="value">
48​ <number>1024</number>
65 </property> 49​ </property>
66 </widget> 50​ </widget>
67 </item> 51​ </item>
68 <item> 52​ <item row="2" column="2">
69 <widget class="QLabel" name="mOriginalHeightLabel"> 53​ <widget class="QLabel" name="label_4">
70 <property name="font"> ​
71 <font> ​
72 <italic>true</italic> ​
73 </font> ​
74 </property> ​
75 <property name="text"> 54​ <property name="text">
76 <string/> 55​ <string notr="true">⨯</string>
77 </property> ​
78 <property name="textInteractionFlags"> ​
79 <set>Qt::LinksAccessibleByMouse|Qt::TextSelectableByMouse</set> ​
80 </property> 56​ </property>
81 </widget> 57​ </widget>
82 </item> 58​ </item>
83 </layout> 59​ <item row="3" column="3">
84 </item> 60​ <widget class="QDoubleSpinBox" name="mHeightPercentSpinBox">
85 <item row="2" column="0"> 61​ <property name="enabled">
86 <widget class="QLabel" name="label_2"> 62​ <bool>false</bool>
87 <property name="text"> ​
88 <string>New Size:</string> ​
89 </property> 63​ </property>
90 <property name="buddy"> 64​ <property name="suffix">
91 <cstring>mWidthSpinBox</cstring> 65​ <string> %</string>
92 </property> 66​ </property>
93 </widget> 67​ <property name="decimals">
94 </item> 68​ <number>0</number>
95 <item row="2" column="1"> ​
96 <layout class="QHBoxLayout" name="horizontalLayout_2"> ​
97 <item> ​
98 <widget class="QSpinBox" name="mWidthSpinBox"> ​
99 <property name="sizePolicy"> ​
100 <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed" /> ​
101 </property> 69​ </property>
102 <property name="minimum"> 70​ <property name="minimum">
103 <number>1</number> 71​ <double>1.000000000000000</double>
104 </property> 72​ </property>
105 <property name="maximum"> 73​ <property name="maximum">
106 <number>100000</number> 74​ <double>1000.000000000000000</double>
75​ </property>
76​ <property name="value">
77​ <double>100.000000000000000</double>
107 </property> 78​ </property>
108 </widget> 79​ </widget>
109 </item> 80​ </item>
110 <item> 81​ <item row="1" column="2">
111 <widget class="QLabel" name="label_4"> 82​ <widget class="QLabel" name="label_6">
112 <property name="text"> 83​ <property name="text">
113 <string notr="true">⨯</string> 84​ <string notr="true">⨯</string>
114 </property> 85​ </property>
115 </widget> 86​ </widget>
116 </item> 87​ </item>
117 <item> 88​ <item row="1" column="3">
89​ <widget class="QLabel" name="mOriginalHeightLabel">
90​ <property name="text">
91​ <string>768 px</string>
92​ </property>
93​ <property name="textInteractionFlags">
94​ <set>Qt::LinksAccessibleByMouse|Qt::TextSelectableByMouse</set>
95​ </property>
96​ </widget>
97​ </item>
98​ <item row="2" column="3">
118 <widget class="QSpinBox" name="mHeightSpinBox"> 99​ <widget class="QSpinBox" name="mHeightSpinBox">
119 <property name="sizePolicy"> 100​ <property name="sizePolicy">
120 <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed" /> 101​ <sizepolicy hsizetype="Minimum" vsizetype="Fixed">
102​ <horstretch>1</horstretch>
103​ <verstretch>0</verstretch>
104​ </sizepolicy>
105​ </property>
106​ <property name="suffix">
107​ <string> px</string>
121 </property> 108​ </property>
122 <property name="minimum"> 109​ <property name="minimum">
123 <number>1</number> 110​ <number>1</number>
124 </property> 111​ </property>
125 <property name="maximum"> 112​ <property name="maximum">
126 <number>100000</number> 113​ <number>99999</number>
114​ </property>
115​ <property name="value">
116​ <number>768</number>
127 </property> 117​ </property>
128 </widget> 118​ </widget>
129 </item> 119​ </item>
130 </layout> 120​ <item row="1" column="1">
121​ <widget class="QLabel" name="mOriginalWidthLabel">
122​ <property name="text">
123​ <string>1024 px</string>
124​ </property>
125​ <property name="alignment">
126​ <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
127​ </property>
128​ <property name="textInteractionFlags">
129​ <set>Qt::LinksAccessibleByMouse|Qt::TextSelectableByMouse</set>
130​ </property>
131​ </widget>
131 </item> 132​ </item>
132 <item row="3" column="0"> 133​ <item row="2" column="0">
133 <widget class="QLabel" name="label_5"> 134​ <widget class="QLabel" name="label_2">
134 <property name="text"> 135​ <property name="text">
135 <string>Percentage:</string> 136​ <string>New size:</string>
137​ </property>
138​ <property name="alignment">
139​ <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
136 </property> 140​ </property>
137 <property name="buddy"> 141​ <property name="buddy">
138 <cstring>mWidthSpinBox</cstring> 142​ <cstring>mWidthSpinBox</cstring>
139 </property> 143​ </property>
140 </widget> 144​ </widget>
141 </item> 145​ </item>
142 <item row="3" column="1"> 146​ <item row="3" column="1">
143 <layout class="QHBoxLayout" name="horizontalLayout_3"> ​
144 <item> ​
145 <widget class="QDoubleSpinBox" name="mWidthPercentSpinBox"> 147​ <widget class="QDoubleSpinBox" name="mWidthPercentSpinBox">
146 <property name="sizePolicy"> 148​ <property name="alignment">
147 <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed" /> 149​ <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
150​ </property>
151​ <property name="suffix">
152​ <string> %</string>
153​ </property>
154​ <property name="decimals">
155​ <number>0</number>
148 </property> 156​ </property>
149 <property name="minimum"> 157​ <property name="minimum">
150 <number>1</number> 158​ <double>1.000000000000000</double>
151 </property> 159​ </property>
152 <property name="maximum"> 160​ <property name="maximum">
153 <number>999</number> 161​ <double>1000.000000000000000</double>
154 </property> 162​ </property>
155 <property name="suffix"> 163​ <property name="value">
156 <string> %</string> 164​ <double>100.000000000000000</double>
157 </property> 165​ </property>
158 <property name="decimals"> 166​ </widget>
159 <number>2</number> 167​ </item>
168​ <item row="4" column="1" colspan="3">
169​ <widget class="QCheckBox" name="mKeepAspectCheckBox">
170​ <property name="text">
171​ <string>Keep aspect ratio</string>
172​ </property>
173​ <property name="checked">
174​ <bool>true</bool>
160 </property> 175​ </property>
161 </widget> 176​ </widget>
162 </item> 177​ </item>
163 <item> 178​ <item row="3" column="2">
164 <widget class="QLabel" name="label_7"> 179​ <widget class="QLabel" name="label_7">
165 <property name="text"> 180​ <property name="text">
166 <string notr="true">⨯</string> 181​ <string notr="true">⨯</string>
167 </property> 182​ </property>
168 </widget> 183​ </widget>
169 </item> 184​ </item>
170 <item> 185​ <item row="0" column="1">
171 <widget class="QDoubleSpinBox" name="mHeightPercentSpinBox"> 186​ <widget class="QLabel" name="label_3">
172 <property name="sizePolicy"> 187​ <property name="text">
173 <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed" /> 188​ <string>Width</string>
174 </property> ​
175 <property name="minimum"> ​
176 <number>1</number> ​
177 </property> ​
178 <property name="maximum"> ​
179 <number>999</number> ​
180 </property> ​
181 <property name="suffix"> ​
182 <string> %</string> ​
183 </property> 189​ </property>
184 <property name="decimals"> 190​ <property name="alignment">
185 <number>2</number> 191​ <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
186 </property> 192​ </property>
187 </widget> 193​ </widget>
188 </item> 194​ </item>
189 </layout> 195​ <item row="0" column="3">
190 </item> 196​ <widget class="QLabel" name="label_5">
191 <item row="4" column="1"> ​
192 <widget class="QCheckBox" name="mKeepAspectCheckBox"> ​
193 <property name="text"> 197​ <property name="text">
194 <string>Keep aspect ratio</string> 198​ <string>Height</string>
195 </property> ​
196 <property name="checked"> ​
197 <bool>true</bool> ​
198 </property> 199​ </property>
199 </widget> 200​ </widget>
200 </item> 201​ </item>
201 </layout> 202​ </layout>
202 </widget> 203​ </widget>
204​ <tabstops>
205​ <tabstop>mWidthSpinBox</tabstop>
206​ <tabstop>mHeightSpinBox</tabstop>
207​ <tabstop>mWidthPercentSpinBox</tabstop>
208​ <tabstop>mHeightPercentSpinBox</tabstop>
209​ <tabstop>mKeepAspectCheckBox</tabstop>
210​ </tabstops>
203 <resources/> 211​ <resources/>
204 <connections/> 212​ <connections>
213​ <connection>
214​ <sender>mKeepAspectCheckBox</sender>
215​ <signal>toggled(bool)</signal>
216​ <receiver>mHeightPercentSpinBox</receiver>
217​ <slot>setDisabled(bool)</slot>
218​ <hints>
219​ <hint type="sourcelabel">
220​ <x>177</x>
221​ <y>139</y>
222​ </hint>
223​ <hint type="destinationlabel">
224​ <x>264</x>
225​ <y>119</y>
226​ </hint>
227​ </hints>
228​ </connection>
229​ </connections>
205</ui> 230​</ui>