Differential D12102 Diff 32652 kcms/translations/package/contents/ui/main.qml

Changeset View

Standalone View

View Options

kcms/translations/package/contents/ui/main.qml

  • This file was added.
1​/*
2​ * Copyright (C) 2015 Marco Martin <mart@kde.org>
3​ * Copyright (C) 2018 Eike Hein <hein@kde.org>
4​ *
5​ * This library is free software; you can redistribute it and/or
6​ * modify it under the terms of the GNU Library General Public
7​ * License as published by the Free Software Foundation; either
8​ * version 2 of the License, or (at your option) any later version.
9​ *
10​ * This library is distributed in the hope that it will be useful,
11​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
12​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13​ * Library General Public License for more details.
14​ *
15​ * You should have received a copy of the GNU Library General Public License
16​ * along with this library; see the file COPYING.LIB. If not, write to
17​ * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18​ * Boston, MA 02110-1301, USA.
19​*/
20​
21​import QtQuick 2.1
22​import QtQuick.Layouts 1.1
23​import QtQuick.Controls 2.3 as QtControls
24​import org.kde.kirigami 2.4 as Kirigami
25​import org.kde.plasma.core 2.1 as PlasmaCore
26​import org.kde.kcm 1.1
27​
28​SimpleKCM {
29​ id: root
30​
31​ ConfigModule.quickHelp: i18n("Language")
32​
33​ topPadding: 0
34​ leftPadding: Kirigami.Units.gridUnit * 5
35​ rightPadding: Kirigami.Units.gridUnit * 5
36​ bottomPadding: 0
37​
38​ PlasmaCore.SortFilterModel {
39​ id: availableLanguagesModel
40​
41​ sourceModel: kcm.translationsModel
42​
43​ filterRole: "IsSelected"
44​ filterCallback: function(source_row, value) { return !value; }
45​
46​ sortRole: "display"
47​ }
48​
49​ Kirigami.OverlaySheet {
50​ id: addLanguagesSheet
51​
52​ parent: root.parent
53​
54​ topPadding: 0
55​ leftPadding: 0
56​ rightPadding: 0
57​ bottomPadding: 0
58​
59​ header: Kirigami.Heading { text: i18nc("@title:window", "Add Languages") }
60​
aspotashevUnsubmitted
Not Done

Please add context:

i18nc("@title:window", "Add Languages")
aspotashev: Please add context: ``` i18nc("@title:window", "Add Languages") ```
61​ property var selectedLanguages: []
62​
63​ onSheetOpenChanged: selectedLanguages = []
64​
65​ ListView {
66​ implicitWidth: Kirigami.Units.gridUnit * 18
67​ implicitHeight: Kirigami.Units.gridUnit * 15
martUnsubmitted
Not Done

same consideration for Layout.* in delegates

mart: same consideration for Layout.* in delegates
martUnsubmitted
Not Done

sorry, counter what i told you before, setting an explicit width: in lists in overlaysheets actually breaks them, https://imgur.com/a/CPMhtYX
this line should be removed

mart: sorry, counter what i told you before, setting an explicit width: in lists in overlaysheets…
68​
69​ Kirigami.Theme.colorSet: Kirigami.Theme.View
70​ Kirigami.Theme.inherit: false
71​
72​ model: availableLanguagesModel
73​
74​ delegate: Kirigami.BasicListItem {
75​ Layout.fillWidth: true
76​
77​ property string languageCode: model.LanguageCode
78​
79​ reserveSpaceForIcon: false
80​
81​ label: model.display
82​
83​ checkable: true
84​ onCheckedChanged: {
85​ if (checked) {
86​ addLanguagesSheet.selectedLanguages.push(index);
87​
88​ // There's no property change notification for pushing to an array
89​ // in a var prop, so we can't bind selectedLanguages.length to
90​ // addLanguagesButton.enabled.
91​ addLanguagesButton.enabled = true;
92​ } else {
93​ addLanguagesSheet.selectedLanguages = addLanguagesSheet.selectedLanguages.filter(function(item) { return item !== index });
94​
95​ // There's no property change notification for pushing to an array
96​ // in a var prop, so we can't bind selectedLanguages.length to
97​ // addLanguagesButton.enabled.
98​ if (!addLanguagesSheet.selectedLanguages.length) {
99​ addLanguagesButton.enabled = false;
100​ }
101​ }
102​ }
103​ }
104​ }
105​
106​ footer: QtControls.Button {
107​ id: addLanguagesButton
108​
109​ width: parent.width
aspotashevUnsubmitted
Not Done

Please add context for translators:

i18nc("@action:button", "Add")
aspotashev: Please add context for translators: ``` i18nc("@action:button", "Add") ```
110​
111​ text: i18nc("@action:button", "Add")
112​
113​ enabled: false
114​
115​ onClicked: {
116​ var langs = kcm.translationsModel.selectedLanguages;
117​ addLanguagesSheet.selectedLanguages.sort().forEach(function(index) {
118​ langs.push(availableLanguagesModel.get(index).LanguageCode);
119​ });
120​
121​ kcm.translationsModel.selectedLanguages = langs;
122​
123​ addLanguagesSheet.sheetOpen = false;
124​ }
125​ }
126​ }
127​
128​ header: QtControls.Control {
129​ width: parent.width
130​ height: messagesLayout.implicitHeight + (messagesLayout.implicitHeight ? bottomPadding : 0)
131​
132​ bottomPadding: Kirigami.Units.smallSpacing
133​
134​ ColumnLayout {
135​ id: messagesLayout
136​
137​ width: parent.width
138​
139​ spacing: Kirigami.Units.largeSpacing
140​
141​ Kirigami.InlineMessage {
142​ Layout.fillWidth: true
143​ Layout.leftMargin: Kirigami.Units.smallSpacing
144​ Layout.rightMargin: Kirigami.Units.smallSpacing
145​
146​ type: Kirigami.MessageType.Information
aspotashevUnsubmitted
Not Done

Please add context:

i18nc("@info", "There are no languages available on this system.")
aspotashev: Please add context: ``` i18nc("@info", "There are no languages available on this system.") ```
147​
148​ text: i18nc("@info", "There are no languages available on this system.")
149​
150​ visible: !availableLanguagesModel.count
151​ }
152​
153​ Kirigami.InlineMessage {
154​ Layout.fillWidth: true
155​ Layout.leftMargin: Kirigami.Units.smallSpacing
156​ Layout.rightMargin: Kirigami.Units.smallSpacing
157​
158​ type: kcm.everSaved ? Kirigami.MessageType.Positive : Kirigami.MessageType.Information
aspotashevUnsubmitted
Not Done

Please add context "@info"

aspotashev: Please add context "@info"
159​
160​ text: (kcm.everSaved ? i18nc("@info", "Your changes will take effect the next time you log in.")
161​ : i18nc("@info", "There are currently no preferred languages configured."))
162​
163​ visible: !languagesList.count || kcm.everSaved
164​ }
165​
166​ Kirigami.InlineMessage {
167​ Layout.fillWidth: true
168​ Layout.leftMargin: Kirigami.Units.smallSpacing
169​ Layout.rightMargin: Kirigami.Units.smallSpacing
170​
171​ type: Kirigami.MessageType.Error
aspotashevUnsubmitted
Not Done

Please add context "@info":

i18ncp("@info %2 is the language code",
aspotashev: Please add context "@info": ``` i18ncp("@info %2 is the language code", ```
172​
173​ text: i18ncp("@info %2 is the language code",
174​ "The translation files for the language with the code '%2' could not be found. The language will be removed from your configuration. If you want to add it back, please install the localization files for it and add the language again.",
175​ "The translation files for the languages with the codes '%2' could not be found. These languages will be removed from your configuration. If you want to add them back, please install the localization files for it and the languages again.",
176​ kcm.translationsModel.missingLanguages.length,
177​ kcm.translationsModel.missingLanguages.join("', '"))
178​
179​ visible: kcm.translationsModel.missingLanguages.length
180​ }
181​ }
182​ }
183​
184​ QtControls.ScrollView {
185​ height: Math.max(root.parent.height - header.height - footer.height, languagesList.contentItem.height)
186​
martUnsubmitted
Not Done

Layout.* attached properties are useless there, as items in a listview are not in a layout.
the correct thing to do here (as documented by qt) is even is not pretty:

width: languagesList.width

mart: Layout.* attached properties are useless there, as items in a listview are not in a layout. the…
187​ visible: languagesList.model.count
188​
189​ QtControls.ScrollBar.horizontal.policy: QtControls.ScrollBar.AlwaysOff
190​ QtControls.ScrollBar.vertical.policy: QtControls.ScrollBar.AlwaysOff
191​
192​ Kirigami.Theme.colorSet: Kirigami.Theme.View
193​ Kirigami.Theme.inherit: false
194​
195​ ListView {
196​ id: languagesList
197​
198​ Layout.fillWidth: true
199​
200​ model: PlasmaCore.SortFilterModel {
201​ sourceModel: kcm.translationsModel
202​
203​ filterRole: "IsSelected"
204​ filterCallback: function(source_row, value) { return value; }
205​
206​ sortRole: "SelectedPriority"
207​ }
208​
209​ delegate: Kirigami.SwipeListItem {
210​ id: listItem
211​
212​ Layout.fillWidth: true
213​ Layout.margins: 0
214​
215​ contentItem: RowLayout {
216​ width: implicitWidth
217​ height: Math.max(implicitHeight, Kirigami.Units.iconSizes.smallMedium)
218​
219​ anchors.verticalCenter: parent.verticalCenter
220​
221​ Kirigami.Icon {
222​ visible: model.IsMissing
223​
224​ Layout.alignment: Qt.AlignVCenter
225​
226​ width: Kirigami.Units.iconSizes.smallMedium
227​ height: width
228​
229​ source: "error"
230​ color: Kirigami.Theme.negativeTextColor
231​ }
232​
233​ QtControls.Label {
234​ Layout.fillWidth: true
235​
236​ Layout.alignment: Qt.AlignVCenter
237​
238​ text: model.display
239​
240​ color: (model.IsMissing ? Kirigami.Theme.negativeTextColor
241​ : (listItem.checked || (listItem.pressed && !listItem.checked && !listItem.sectionDelegate)
242​ ? listItem.activeTextColor : listItem.textColor))
243​ }
244​ }
245​
246​ actions: [
247​ Kirigami.Action {
248​ enabled: !model.IsMissing && index > 0
249​ iconName: "arrow-up"
250​ onTriggered: kcm.translationsModel.selectedLanguages.splice(index - 1, 0, kcm.translationsModel.selectedLanguages.splice(index, 1)[0])
251​
252​ },
253​ Kirigami.Action {
254​ enabled: !model.IsMissing && index < (languagesList.count - 1)
255​ iconName: "arrow-down"
256​ onTriggered: kcm.translationsModel.selectedLanguages.splice(index + 1, 0, kcm.translationsModel.selectedLanguages.splice(index, 1)[0])
257​
258​ },
259​ Kirigami.Action {
260​ enabled: !model.IsMissing
261​ iconName: "list-remove"
262​ onTriggered: kcm.translationsModel.selectedLanguages = kcm.translationsModel.selectedLanguages.filter(function(item) { return item !== model.LanguageCode })
263​ }]
264​ }
265​ }
266​
267​ Component.onCompleted: {
268​ background.visible = true;
269​ QtControls.ScrollBar.horizontal.visible = false;
270​ }
271​ }
272​
aspotashevUnsubmitted
Not Done

Please add context "@action:button"

aspotashev: Please add context "@action:button"
273​ footer: QtControls.Control {
274​ width: parent.width
275​ height: footerLayout.implicitHeight + topPadding
276​
277​ topPadding: Kirigami.Units.smallSpacing
278​ leftPadding: Kirigami.Units.smallSpacing
279​ rightPadding: Kirigami.Units.smallSpacing
280​
281​ RowLayout {
282​ id: footerLayout
283​
284​ y: parent.topPadding
285​ width: parent.width
286​
287​ QtControls.Button {
288​ Layout.alignment: Qt.AlignHCenter
289​
290​ enabled: availableLanguagesModel.count
291​
292​ text: i18nc("@action:button", "Add languages...")
293​
294​ onClicked: addLanguagesSheet.sheetOpen = !addLanguagesSheet.sheetOpen
295​
296​ checkable: true
297​ checked: addLanguagesSheet.sheetOpen
298​ }
299​ }
300​ }
301​}
302​