Changeset View
Changeset View
Standalone View
Standalone View
src/Gui/SettingsDialog/GeneralOptionsPage.cpp
Show First 20 Lines • Show All 51 Lines • ▼ Show 20 Line(s) | 32 | { | |||
---|---|---|---|---|---|
52 | connect(mUseLightBackground, &QCheckBox::toggled, this, &GeneralOptionsPage::markDirty); | 52 | connect(mUseLightBackground, &QCheckBox::toggled, this, &GeneralOptionsPage::markDirty); | ||
53 | mainLayout->addWidget(mUseLightBackground, 1); | 53 | mainLayout->addWidget(mUseLightBackground, 1); | ||
54 | 54 | | |||
55 | // remember Rectangular Region box | 55 | // remember Rectangular Region box | ||
56 | 56 | | |||
57 | mRememberRect = new QCheckBox(i18n("Remember selected area"), this); | 57 | mRememberRect = new QCheckBox(i18n("Remember selected area"), this); | ||
58 | connect(mRememberRect, &QCheckBox::toggled, this, &GeneralOptionsPage::markDirty); | 58 | connect(mRememberRect, &QCheckBox::toggled, this, &GeneralOptionsPage::markDirty); | ||
59 | 59 | | |||
60 | // show magnifier | ||||
61 | | ||||
62 | mShowMagnifier = new QCheckBox(i18n("Show magnifier"), this); | ||||
63 | mShowMagnifier->setToolTip(i18n("You can use alt key to toggle magnifier temporarily during selecting")); | ||||
rkflx: I'd use {key Shift} in the text here (even though it already works with every modifier…) , as… | |||||
64 | connect(mShowMagnifier, &QCheckBox::toggled, this, &GeneralOptionsPage::markDirty); | ||||
65 | | ||||
60 | QVBoxLayout *rrCLayout = new QVBoxLayout; | 66 | QVBoxLayout *rrCLayout = new QVBoxLayout; | ||
61 | // rrCLayout->setContentsMargins(15, 10, 0, 10); | 67 | // rrCLayout->setContentsMargins(15, 10, 0, 10); | ||
62 | rrCLayout->addWidget(mUseLightBackground); | 68 | rrCLayout->addWidget(mUseLightBackground); | ||
63 | rrCLayout->addWidget(mRememberRect); | 69 | rrCLayout->addWidget(mRememberRect); | ||
70 | rrCLayout->addWidget(mShowMagnifier); | ||||
64 | rrLayout->addLayout(rrCLayout); | 71 | rrLayout->addLayout(rrCLayout); | ||
65 | mainLayout->addWidget(rrGroup, 1); | 72 | mainLayout->addWidget(rrGroup, 1); | ||
66 | 73 | | |||
67 | // read in the data | 74 | // read in the data | ||
68 | 75 | | |||
69 | resetChanges(); | 76 | resetChanges(); | ||
70 | 77 | | |||
71 | // finish up with the main layout | 78 | // finish up with the main layout | ||
Show All 9 Lines | |||||
81 | } | 88 | } | ||
82 | 89 | | |||
83 | void GeneralOptionsPage::saveChanges() | 90 | void GeneralOptionsPage::saveChanges() | ||
84 | { | 91 | { | ||
85 | SpectacleConfig *cfgManager = SpectacleConfig::instance(); | 92 | SpectacleConfig *cfgManager = SpectacleConfig::instance(); | ||
86 | 93 | | |||
87 | cfgManager->setUseLightRegionMaskColour(mUseLightBackground->checkState() == Qt::Checked); | 94 | cfgManager->setUseLightRegionMaskColour(mUseLightBackground->checkState() == Qt::Checked); | ||
88 | cfgManager->setRememberLastRectangularRegion(mRememberRect->checkState() == Qt::Checked); | 95 | cfgManager->setRememberLastRectangularRegion(mRememberRect->checkState() == Qt::Checked); | ||
96 | cfgManager->setShowMagnifierChecked(mShowMagnifier->checkState() == Qt::Checked); | ||||
89 | cfgManager->setCopySaveLocationToClipboard(mCopyPathToClipboard->checkState() == Qt::Checked); | 97 | cfgManager->setCopySaveLocationToClipboard(mCopyPathToClipboard->checkState() == Qt::Checked); | ||
90 | 98 | | |||
91 | mChangesMade = false; | 99 | mChangesMade = false; | ||
92 | } | 100 | } | ||
93 | 101 | | |||
94 | void GeneralOptionsPage::resetChanges() | 102 | void GeneralOptionsPage::resetChanges() | ||
95 | { | 103 | { | ||
96 | SpectacleConfig *cfgManager = SpectacleConfig::instance(); | 104 | SpectacleConfig *cfgManager = SpectacleConfig::instance(); | ||
97 | 105 | | |||
98 | mUseLightBackground->setChecked(cfgManager->useLightRegionMaskColour()); | 106 | mUseLightBackground->setChecked(cfgManager->useLightRegionMaskColour()); | ||
99 | mRememberRect->setChecked(cfgManager->rememberLastRectangularRegion()); | 107 | mRememberRect->setChecked(cfgManager->rememberLastRectangularRegion()); | ||
108 | mShowMagnifier->setChecked(cfgManager->showMagnifierChecked()); | ||||
100 | mCopyPathToClipboard->setChecked(cfgManager->copySaveLocationToClipboard()); | 109 | mCopyPathToClipboard->setChecked(cfgManager->copySaveLocationToClipboard()); | ||
101 | 110 | | |||
102 | mChangesMade = false; | 111 | mChangesMade = false; | ||
103 | } | 112 | } |
I'd use ⇧ in the text here (even though it already works with every modifier…) , as it is more commonly connected with modifying state (e.g. "Preserve aspect ratio"):
(Also reworded a bit, to make it more clear that the magnifier only appears once you press down a mouse button.)