Differential D12041 Diff 32246 desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

Changeset View

Standalone View

View Options

desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

Context not available.
21import QtQuick.Controls 1.0 as QtControls 21​import QtQuick.Controls 1.0 as QtControls
22import QtQuick.Layouts 1.1 22​import QtQuick.Layouts 1.1
23 23​
24​import org.kde.kconfig 1.0 // for KAuthorized
25​import org.kde.plasma.private.shell 2.0 as ShellPrivate // for WallpaperPlugin
26​
24ColumnLayout { 27​ColumnLayout {
25 id: root 28​ id: root
26 29​
Context not available.
65 68​
66 Row { 69​ Row {
67 spacing: units.largeSpacing / 2 70​ spacing: units.largeSpacing / 2
68 anchors.right: wallpaperRow.right ​
69 visible: pluginComboBox.count > 1 71​ visible: pluginComboBox.count > 1
ngrahamUnsubmitted
Not Done

Don't leave commented-out code; remove it

ngraham: Don't leave commented-out code; remove it
70 Item { ​
71 width: units.largeSpacing ​
72 height: parent.height ​
73 } ​
74 QtControls.Label { 72​ QtControls.Label {
73​ width: formAlignment - units.largeSpacing
75 anchors.verticalCenter: pluginComboBox.verticalCenter 74​ anchors.verticalCenter: pluginComboBox.verticalCenter
ngrahamUnsubmitted
Not Done

Don't leave commented-out code; remove it

ngraham: Don't leave commented-out code; remove it
76 text: i18nd("plasma_shell_org.kde.plasma.desktop", "Layout:") 75​ text: i18nd("plasma_shell_org.kde.plasma.desktop", "Layout:")
76​ horizontalAlignment: Text.AlignRight
77 } 77​ }
78 QtControls.ComboBox { 78​ QtControls.ComboBox {
79 id: pluginComboBox 79​ id: pluginComboBox
Context not available.
149 root.configurationChanged() 149​ root.configurationChanged()
150 } 150​ }
151 } 151​ }
152​ QtControls.Button {
153​ iconName: "get-hot-new-stuff"
154​ text: i18nd("plasma_shell_org.kde.plasma.desktop", "Get New Wallpaper Plugins...")
ngrahamUnsubmitted
Not Done

It might be a bit wordy, but to be consistent with the form used everywhere else, this should say, "Get new Wallpaper Plugins..."

ngraham: It might be a bit wordy, but to be consistent with the form used everywhere else, this should…
ZrenAuthorUnsubmitted
Not Done

"Get New Wallpaper" is capitalized. Are we using lowercase so the "Wallpaper Plugins" stands out more?

lowercase new vs uppercase New

Zren: "Get New Wallpaper" is capitalized. Are we using lowercase so the "Wallpaper Plugins" stands…
ngrahamUnsubmitted
Not Done

Sorry for the confusion, I was more commenting on the fact that the word "New" would be included. Following the pattern is a good idea, though I would favor lowercasing the word "new" everywhere (would be in another patch though).

ngraham: Sorry for the confusion, I was more commenting on the fact that the word "New" would be…
155​ visible: KAuthorized.authorize("ghns")
156​ onClicked: wallpaperPlugin.getNewWallpaperPlugin(this)
157​
158​ ShellPrivate.WallpaperPlugin {
159​ id: wallpaperPlugin
160​ }
161​ }
152 } 162​ }
153 163​
154 Item { 164​ Item {
Context not available.