Differential D10078 Diff 31871 src/dbusrunner/abstractrunner_p.h

Changeset View

Standalone View

src/dbusrunner/abstractrunner_p.h

This file was added.

1		/*
2		* Copyright 2018 Friedrich W. H. Kossebau <kossebau@kde.org>
3		*
4		* This program is free software; you can redistribute it and/or modify
5		* it under the terms of the GNU Library General Public License version 2 as
6		* published by the Free Software Foundation
7		*
8		* This program is distributed in the hope that it will be useful,
9		* but WITHOUT ANY WARRANTY; without even the implied warranty of
10		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11		* GNU General Public License for more details
12		*
13		* You should have received a copy of the GNU Library General Public
14		* License along with this program; if not, write to the
15		* Free Software Foundation, Inc.,
16		* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17		*/
18
19		#pragma once
20
21		#include "abstractrunner.h"
22		// Qt
23		#include <QDBusContext>
24		#include <QDBusMessage>
25
26		namespace KDBusRunner
27		{
28
29		class AbstractRunnerPrivate : public QObject, protected QDBusContext
30		{
31		Q_OBJECT
32
33		public:
34		explicit AbstractRunnerPrivate(const QString& dBusObjectPath, const QString& dBusServiceName,
35		AbstractRunner* parent);
36		~AbstractRunnerPrivate() override;
37
38		public:
39		Actions actions();
40		QueryMatches match(const QString &queryTerm);
41		void run(const QString &id, const QString &actionId);
42
43		void setEnabled(bool enabled);
44		bool isEnabled() const;
45
46		private:
47		AbstractRunner * const q;
	davidedmundsonUnsubmitted Not Done This undermines the advantages of my changes. Its not object oriented anymore. davidedmundson: This undermines the advantages of my changes. Its not object oriented anymore.
	kossebauAuthorUnsubmitted Not Done I tried to reason in the update message why I think after having tried that API that some other OO approach feels better to me. Any chance you missed that, given you do not refer to the arguments given there here? kossebau: I tried to reason in the update message why I think after having tried that API that some other…
48
49		QString mDBusObjectPath;
50		QString mDBusServiceName;
51		};
52
53		class ContextPrivate {
54		public:
55		inline bool isMatching() const { return mLastMatchDBusMessage.type() == QDBusMessage::MethodCallMessage; }
56		QDBusMessage mLastMatchDBusMessage;
57		QueryMatches mMatches;
58		QString mQuery;
59		};
60
61		}