Differential D11622 Diff 30556 krusader/panelmanager.cpp

Changeset View

Standalone View

View Options

krusader/panelmanager.cpp

Context not available.
267 cfg.writeEntry("Properties", 0); 267​ cfg.writeEntry("Properties", 0);
268 p->restoreSettings(cfg); 268​ p->restoreSettings(cfg);
269 krConfig->deleteGroup(grpName); 269​ krConfig->deleteGroup(grpName);
270​ p->openUrl(url);
martinkostolnyUnsubmitted
Not Done

I think, the fix can be done like this with no additional code:

if (nextTo->virtualPath() != url) {
    p->start(url);
}

...instead of line 270.

Please correct me if I've missed something.

martinkostolny: I think, the fix can be done like this with no additional code: ``` if (nextTo->virtualPath() !
radeAuthorUnsubmitted
Not Done

The reason I choose too not just call start is that start changes the jumpback point. Another issue that is less important is that if start is called with an invalid url, then it navigates to the homefolder. This makes sense for a new tab, because it has to show something. If openUrl is called from an existing tab with an invalid url it does nothing, because it makes more sense to continue showing the folder we are already in.

rade: The reason I choose too not just call start is that start changes the jumpback point. Another…
radeAuthorUnsubmitted
Not Done

I'm not quite sure I understand the if statement. Is the purpose of 'nextTo->virtualPath() != url' just checking that the url we are trying to open is not the url we are already at? If it is why would it be bad to open it again? Screwing up the back button or something?

rade: I'm not quite sure I understand the if statement. Is the purpose of 'nextTo->virtualPath() !=…
martinkostolnyUnsubmitted
Not Done

Please correct me if I'm wrong but it seems that jumpback point is reset for every new tab that is created (duplicated or not). Even with your diff the jumpback point of the parent tab is not transferred to the new one. I have to be missing something. Anyway I find that as an expected behaviour but I'm not explicitly against changing that :).

As for the invalid url argument, fair enough :).

ad purpose of the if statment: It was there simple in order to not call code that is not necessary to call again. Right I think there probably aren't any bad consequences, I just thought it is logically cleaner this way.

martinkostolny: Please correct me if I'm wrong but it seems that jumpback point is reset for every new tab that…
270 } 271​ }
271 else 272​ else
272 p->start(url); 273​ p->start(url);
Context not available.