Changeset View
Standalone View
src/dolphinmainwindow.cpp
| Show First 20 Lines • Show All 66 Lines • ▼ Show 20 Line(s) | |||||
| 67 | #include <KUrlComboBox> | 67 | #include <KUrlComboBox> | ||
| 68 | #include <KUrlNavigator> | 68 | #include <KUrlNavigator> | ||
| 69 | 69 | | |||
| 70 | #include <QApplication> | 70 | #include <QApplication> | ||
| 71 | #include <QClipboard> | 71 | #include <QClipboard> | ||
| 72 | #include <QCloseEvent> | 72 | #include <QCloseEvent> | ||
| 73 | #include <QDialog> | 73 | #include <QDialog> | ||
| 74 | #include <QFileInfo> | 74 | #include <QFileInfo> | ||
| 75 | #include <QDialogButtonBox> | ||||
elvisangelaccio: Not needed? (or at least, I can build without it) | |||||
| 75 | #include <QLineEdit> | 76 | #include <QLineEdit> | ||
| 76 | #include <QMenu> | 77 | #include <QMenu> | ||
| 77 | #include <QMenuBar> | 78 | #include <QMenuBar> | ||
| 79 | #include <QMessageBox> | ||||
elvisangelaccio: Not needed? (or at least, I can build without it) | |||||
| 78 | #include <QPushButton> | 80 | #include <QPushButton> | ||
| 79 | #include <QShowEvent> | 81 | #include <QShowEvent> | ||
| 80 | #include <QStandardPaths> | 82 | #include <QStandardPaths> | ||
| 81 | #include <QTimer> | 83 | #include <QTimer> | ||
| 82 | #include <QToolButton> | 84 | #include <QToolButton> | ||
| 83 | #include <kdualaction.h> | 85 | #include <kdualaction.h> | ||
| 84 | 86 | | |||
| 85 | namespace { | 87 | namespace { | ||
| ▲ Show 20 Lines • Show All 314 Lines • ▼ Show 20 Line(s) | 397 | if (m_tabWidget->count() > 1 && GeneralSettings::confirmClosingMultipleTabs() && closedByUser) { | |||
| 400 | // QDialogButtonBox::Cancel -> do nothing | 402 | // QDialogButtonBox::Cancel -> do nothing | ||
| 401 | QDialog *dialog = new QDialog(this, Qt::Dialog); | 403 | QDialog *dialog = new QDialog(this, Qt::Dialog); | ||
| 402 | dialog->setWindowTitle(i18nc("@title:window", "Confirmation")); | 404 | dialog->setWindowTitle(i18nc("@title:window", "Confirmation")); | ||
| 403 | dialog->setModal(true); | 405 | dialog->setModal(true); | ||
| 404 | QDialogButtonBox* buttons = new QDialogButtonBox(QDialogButtonBox::Yes | QDialogButtonBox::No | QDialogButtonBox::Cancel); | 406 | QDialogButtonBox* buttons = new QDialogButtonBox(QDialogButtonBox::Yes | QDialogButtonBox::No | QDialogButtonBox::Cancel); | ||
| 405 | KGuiItem::assign(buttons->button(QDialogButtonBox::Yes), KStandardGuiItem::quit()); | 407 | KGuiItem::assign(buttons->button(QDialogButtonBox::Yes), KStandardGuiItem::quit()); | ||
| 406 | KGuiItem::assign(buttons->button(QDialogButtonBox::No), KGuiItem(i18n("C&lose Current Tab"), QIcon::fromTheme(QStringLiteral("tab-close")))); | 408 | KGuiItem::assign(buttons->button(QDialogButtonBox::No), KGuiItem(i18n("C&lose Current Tab"), QIcon::fromTheme(QStringLiteral("tab-close")))); | ||
| 407 | KGuiItem::assign(buttons->button(QDialogButtonBox::Cancel), KStandardGuiItem::cancel()); | 409 | KGuiItem::assign(buttons->button(QDialogButtonBox::Cancel), KStandardGuiItem::cancel()); | ||
| 408 | buttons->button(QDialogButtonBox::Yes)->setDefault(true); | 410 | buttons->button(QDialogButtonBox::Yes)->setDefault(true); | ||
@ngraham rominf: @ngraham
How about this? Closing a window with all opened tabs is destructive in my opinion. My… | |||||
Yes, I think it's appropriate to have the cancel button be the default button for this dialog. ngraham: Yes, I think it's appropriate to have the cancel button be the default button for this dialog. | |||||
| 409 | 411 | | |||
| 410 | bool doNotAskAgainCheckboxResult = false; | 412 | bool doNotAskAgainCheckboxResult = false; | ||
| 411 | 413 | | |||
| 412 | const int result = KMessageBox::createKMessageBox(dialog, | 414 | const auto result = KMessageBox::createKMessageBox(dialog, | ||
| 413 | buttons, | 415 | buttons, | ||
| 414 | QMessageBox::Warning, | 416 | QMessageBox::Warning, | ||
| 415 | i18n("You have multiple tabs open in this window, are you sure you want to quit?"), | 417 | i18n("You have multiple tabs open in this window, are you sure you want to quit?"), | ||
| 416 | QStringList(), | 418 | QStringList(), | ||
| 417 | i18n("Do not ask again"), | 419 | i18n("Do not ask again"), | ||
| 418 | &doNotAskAgainCheckboxResult, | 420 | &doNotAskAgainCheckboxResult, | ||
| 419 | KMessageBox::Notify); | 421 | KMessageBox::Notify); | ||
Unrelated change? (At least in Okular there were huge discussions on the type of icon, and I think it's bad form if you just sneak in such changes in this patch…) rkflx: Unrelated change?
(At least in Okular there were huge discussions on the type of icon, and I… | |||||
I thought that making the separate patch because of one line of code is too much. Sorry. Do you agree with the change by itself? Should I do it in the separate patch? rominf: I thought that making the separate patch because of one line of code is too much. Sorry. Do you… | |||||
One-line patches are perfectly fine. In general, keep to one change per patch, and don't try to sneak unrelated changes into patches. ngraham: One-line patches are perfectly fine. In general, keep to one change per patch, and don't try to… | |||||
OK. See D11293. rominf: OK. See D11293. | |||||
rkflx: > Do you agree with the change by itself?
That's for #dolphin to decide. Personally I think… | |||||
Usability-wise, Cancel is the appropriate default. The default button should never cause you to lose work or state. If tab state is considered unimportant, then we shouldn't have a "close multiple tabs" confirmation in the first place. But if we do have one, then the safe/non-destructive choice must be default. ngraham: Usability-wise, {nav Cancel} is the appropriate default. The default button should never cause… | |||||
What you say applies for regular dialogs. However, here we are in a confirmation dialog, where we already saved the user from a destructive action. Now we should present the sensible choice by default, which IMO is quitting. Or do you want another safety net? Anyway, do what you want and talk to Dolphin's maintainers, I don't have time to discuss this right now. Maybe we'll change it back later when this is unified across all apps. rkflx: What you say applies for regular dialogs. However, here we are in a //confirmation// dialog… | |||||
Okay, looking at the new Okular dialog, I'm pretty sure it should work like this:
IOW, window state is less important (but still worth a confirmation) than unsaved user files (which are worth a warning). rkflx: Okay, looking at the new Okular dialog, I'm pretty sure it should work like this:
- "Are you… | |||||
ngraham: Hmm, you make some good points. I'll have a think. | |||||
Cannot edit inline comments, therefore let me clarify:
For unsaved changes, the "Save" action should be default, of course. What I meant here was when you can only choose between losing all work and cancelling. rkflx: Cannot edit inline comments, therefore let me clarify:
> "Discard changes"-type dialog: Cancel… | |||||
+1 elvisangelaccio: > What you say applies for regular dialogs. However, here we are in a confirmation dialog… | |||||
ngraham: OK, you guys have convinced me! Good arguments. | |||||
| 420 | 422 | | |||
| 421 | if (doNotAskAgainCheckboxResult) { | 423 | if (doNotAskAgainCheckboxResult) { | ||
| 422 | GeneralSettings::setConfirmClosingMultipleTabs(false); | 424 | GeneralSettings::setConfirmClosingMultipleTabs(false); | ||
| 423 | } | 425 | } | ||
| 424 | 426 | | |||
| 425 | switch (result) { | 427 | switch (result) { | ||
| 426 | case QDialogButtonBox::Yes: | 428 | case QDialogButtonBox::Yes: | ||
| 427 | // Quit | 429 | // Quit | ||
| 428 | break; | 430 | break; | ||
| 429 | case QDialogButtonBox::No: | 431 | case QDialogButtonBox::No: | ||
| 430 | // Close only the current tab | 432 | // Close only the current tab | ||
| 431 | m_tabWidget->closeTab(); | 433 | m_tabWidget->closeTab(); | ||
| 432 | Q_FALLTHROUGH(); | 434 | Q_FALLTHROUGH(); | ||
| 433 | default: | 435 | default: | ||
| 434 | event->ignore(); | 436 | event->ignore(); | ||
| 435 | return; | 437 | return; | ||
| 436 | } | 438 | } | ||
| 437 | } | 439 | } | ||
| 438 | 440 | | |||
| 441 | if (m_terminalPanel->isAnyProgramRunning() && GeneralSettings::confirmClosingTerminalRunningProgram() && closedByUser) { | ||||
| 442 | // Ask if the user really wants to quit Dolphin with a program that is still running in the Terminal panel | ||||
In general we try to avoid gendered language where possible, even in a code comment. How about: "Ask if the user really wants to..." ngraham: In general we try to avoid gendered language where possible, even in a code comment. How about… | |||||
| 443 | // Open a confirmation dialog with 3 buttons: | ||||
| 444 | // QDialogButtonBox::Yes -> Quit | ||||
| 445 | // QDialogButtonBox::No -> Show Terminal Panel | ||||
| 446 | // QDialogButtonBox::Cancel -> do nothing | ||||
Can't you use any of KMessageBox's built-in dialogs rather than creating the entire QDialog yourself? broulik: Can't you use any of `KMessageBox`'s built-in dialogs rather than creating the entire `QDialog`… | |||||
I just copy pasted ConfirmClosingMultipleTabs code because that's my first written dialog in KDE and I don't know how the things are done. If you think that this should be changed, then we have to change ConfirmClosingMultipleTabs too. rominf: I just copy pasted `ConfirmClosingMultipleTabs` code because that's my first written dialog in… | |||||
See also T7022: Improve confirmation dialog when closing multiple tabs. TL;DR: Everybody does it differently, in the far future it would be nice to make it consistent across apps. Perhaps I'd keep Dolphin's style here for now, but that's for Dolphin to decide. rkflx: See also {T7022}.
TL;DR: Everybody does it differently, in the far future it would be nice to… | |||||
| 447 | QDialog *dialog = new QDialog(this, Qt::Dialog); | ||||
| 448 | dialog->setWindowTitle(i18nc("@title:window", "Confirmation")); | ||||
| 449 | dialog->setModal(true); | ||||
| 450 | auto standardButtons = QDialogButtonBox::Yes | QDialogButtonBox::Cancel; | ||||
| 451 | if (!m_terminalPanel->isVisible()) { | ||||
| 452 | standardButtons |= QDialogButtonBox::No; | ||||
The Show Terminal Panel button should probably only be displayed if the Terminal panel is hidden. Otherwise it seems odd that it's there, and when you click on it, nothing different appears to happen compared to just hitting the cancel button. ngraham: The {nav Show Terminal Panel} button should probably only be displayed if the Terminal panel is… | |||||
Terminal panel gets focus. I think it's reasonable to keep the button. Your opinion? rominf: > Otherwise it seems odd that it's there, and when you click on it, nothing different appears… | |||||
Regardless, some kind of change is needed, because the button says "Show Terminal Panel", not "Focus Terminal Panel". A button should always do what it says it'll do, or else users learn not to truth the software. If we want to do make it simply focus the Terminal panel when the Terminal panel is open, then the text should change accordingly. ngraham: Regardless, some kind of change is needed, because the button says "Show Terminal Panel", not… | |||||
| 453 | } | ||||
| 454 | QDialogButtonBox *buttons = new QDialogButtonBox(standardButtons); | ||||
A dialog box's default button should never invoke a destructive action. In this context, killing the process is akin to quitting with unsaved changes and should be considered destructive. The button's red icon also provides a hint. :) The Cancel button should be the default button here. ngraham: A dialog box's default button should //never// invoke a destructive action. In this context… | |||||
| 455 | KGuiItem::assign(buttons->button(QDialogButtonBox::Yes), KStandardGuiItem::quit()); | ||||
| 456 | if (!m_terminalPanel->isVisible()) { | ||||
Why another if (!m_terminalPanel->isVisible()) block? Can't we merge this with the one above? elvisangelaccio: Why another `if (!m_terminalPanel->isVisible())` block? Can't we merge this with the one above? | |||||
We actually can't--at least not cleanly. The top block modifies standardButtons, which is consumed later, the product of which (buttons) is needed in the second block. ngraham: We actually can't--at least not cleanly. The top block modifies `standardButtons`, which is… | |||||
| 457 | KGuiItem::assign( | ||||
| 458 | buttons->button(QDialogButtonBox::No), | ||||
Please use const auto result, since this function returns a QDialogButtonBox::StandardButton. elvisangelaccio: Please use `const auto result`, since this function returns a `QDialogButtonBox… | |||||
| 459 | KGuiItem(i18n("Show &Terminal Panel"), QIcon::fromTheme(QStringLiteral("utilities-terminal")))); | ||||
Let's phrase this text in a more standard, grammatically correct manner: "A program is still running in the Terminal panel. Are you sure you want to quit?" Bonus points if we can get the actual running command and display it in the text here somehow. Also +1 for @rkflx's suggestion for a button that will show the terminal panel if it's hidden. ngraham: Let's phrase this text in a more standard, grammatically correct manner:
"A program is still… | |||||
Done your task for bonus points and @rkflx's suggestion. rominf: Done your task for bonus points and @rkflx's suggestion. | |||||
| 460 | } | ||||
| 461 | KGuiItem::assign(buttons->button(QDialogButtonBox::Cancel), KStandardGuiItem::cancel()); | ||||
This is the name of the key that will be stored in settings to remember this. The text in the user interface is always "Do not ask again" broulik: This is the name of the key that will be stored in settings to remember this. The text in the… | |||||
| 462 | | ||||
With the actual program name in the string (thumbs up for that), we need a small change to make it grammatically correct: A program -> The program ngraham: With the actual program name in the string (thumbs up for that), we need a small change to make… | |||||
But it is a default. Why isn't this working? rominf: > but the Cancel button still isn't the default
But it is a default. Why isn't this working? | |||||
Does it work for you? If not, you need to test the changes you're making. As for why, I don't know; it's your patch. :) One of the fun parts of producing a patch is that you often go down the rabbit hole of finding other bugs in the code you're touching! ngraham: Does it work for you? If not, you need to test the changes you're making. As for why, I don't… | |||||
| 463 | bool doNotAskAgainCheckboxResult = false; | ||||
| 464 | | ||||
No word puzzles, please. Let's add the program within the i18n function call using a format string, rather than string concatenation. ngraham: No word puzzles, please. Let's add the program within the `i18n` function call using a format… | |||||
rominf: Sorry, I didn't know that `i18n` works that way. Fixed it. | |||||
| 465 | const auto result = KMessageBox::createKMessageBox( | ||||
| 466 | dialog, | ||||
| 467 | buttons, | ||||
| 468 | QMessageBox::Warning, | ||||
| 469 | i18n("The program '%1' is still running in the Terminal panel. Are you sure you want to quit?", m_terminalPanel->runningProgramName()), | ||||
| 470 | QStringList(), | ||||
| 471 | i18n("Do not ask again"), | ||||
| 472 | &doNotAskAgainCheckboxResult, | ||||
| 473 | KMessageBox::Dangerous); | ||||
| 474 | | ||||
| 475 | if (doNotAskAgainCheckboxResult) { | ||||
| 476 | GeneralSettings::setConfirmClosingTerminalRunningProgram(false); | ||||
| 477 | } | ||||
| 478 | | ||||
| 479 | switch (result) { | ||||
| 480 | case QDialogButtonBox::Yes: | ||||
elvisangelaccio: Missing braces | |||||
| 481 | // Quit | ||||
| 482 | break; | ||||
| 483 | case QDialogButtonBox::No: | ||||
| 484 | actionCollection()->action("show_terminal_panel")->trigger(); | ||||
| 485 | // Do not quit, ignore quit event | ||||
| 486 | // fall through | ||||
This switch now exists twice in the same function. There must be a smarter way of doing that, right? markg: This switch now exists twice in the same function. There must be a smarter way of doing that… | |||||
That's 2 different switches. Look at case QDialogButtonBox::No: branch. I'm sure it's possible to merge them, but that would hurt readability. rominf: That's 2 different switches. Look at `case QDialogButtonBox::No:` branch. I'm sure it's… | |||||
Right, but this also hurts ;) markg: Right, but this also hurts ;)
Oke, it's a tradeoff i suppose. Readability over duplication. | |||||
elvisangelaccio: Please use `Q_FALLTHROUGH` instead. | |||||
| 487 | default: | ||||
| 488 | event->ignore(); | ||||
| 489 | return; | ||||
| 490 | } | ||||
| 491 | } | ||||
| 492 | | ||||
| 439 | GeneralSettings::setVersion(CurrentDolphinVersion); | 493 | GeneralSettings::setVersion(CurrentDolphinVersion); | ||
| 440 | GeneralSettings::self()->save(); | 494 | GeneralSettings::self()->save(); | ||
| 441 | 495 | | |||
| 442 | KXmlGuiWindow::closeEvent(event); | 496 | KXmlGuiWindow::closeEvent(event); | ||
| 443 | } | 497 | } | ||
| 444 | 498 | | |||
| 445 | void DolphinMainWindow::saveProperties(KConfigGroup& group) | 499 | void DolphinMainWindow::saveProperties(KConfigGroup& group) | ||
| 446 | { | 500 | { | ||
| ▲ Show 20 Lines • Show All 1182 Lines • Show Last 20 Lines | |||||
Not needed? (or at least, I can build without it)