Differential D11034 Diff 30148 src/core/ApplicationSettings.h

Changeset View

Standalone View

View Options

src/core/ApplicationSettings.h

Context not available.
467 */ 467​ */
468 Q_INVOKABLE bool useExternalWordset(); 468​ Q_INVOKABLE bool useExternalWordset();
469 469​
470​protected:
471​ explicit ApplicationSettings(QObject *parent, QString path);
jjazeixUnsubmitted
Not Done

you can delegate constructors in c++11.
Use const reference for attributes.
The previous code was good, only one constructor with default values:
explicit ApplicationSettings(const QString &path = "...", QObject *parent = 0);

jjazeix: you can delegate constructors in c++11. Use const reference for attributes. The previous code…
472​
470protected slots: 473​protected slots:
471 474​
472 Q_INVOKABLE void notifyShowLockedActivitiesChanged(); 475​ Q_INVOKABLE void notifyShowLockedActivitiesChanged();
Context not available.
569 void barHiddenChanged(); 572​ void barHiddenChanged();
570 573​
571private: 574​private:
572 575​ // Repeated code in the constructor of the class
576​ void getConstructor();
573 // Update in configuration the couple {key, value} in the group. 577​ // Update in configuration the couple {key, value} in the group.
574 template<class T> void updateValueInConfig(const QString& group, 578​ template<class T> void updateValueInConfig(const QString& group,
575 const QString& key, const T& value); 579​ const QString& key, const T& value);
Context not available.