Differential D11070 Diff 29895 plugins/htmlinterface/webserver.cpp

Changeset View

Standalone View

View Options

plugins/htmlinterface/webserver.cpp

  • This file was added.
1​/***************************************************************************
2​ * Copyright (C) 2018 by Emmanuel Eytan *
3​ * eje211@gmail.com *
4​ * *
5​ * This program is free software; you can redistribute it and/or modify *
6​ * it under the terms of the GNU General Public License as published by *
7​ * the Free Software Foundation; either version 2 of the License, or *
8​ * (at your option) any later version. *
9​ * *
10​ * This program is distributed in the hope that it will be useful, *
11​ * but WITHOUT ANY WARRANTY; without even the implied warranty of *
12​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
13​ * GNU General Public License for more details. *
14​ * *
15​ * You should have received a copy of the GNU General Public License *
16​ * along with this program; if not, write to the *
17​ * Free Software Foundation, Inc., *
18​ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. *
19​ ***************************************************************************/
20​
21​#include <iostream>
22​#include "webserver.h"
23​
24​#include <stdio.h>
25​#include <sys/stat.h>
26​#include <fcntl.h>
27​#include <string.h>
28​#include <QString>
29​#include <QRegExp>
30​#include <QStringList>
31​#include <QMimeDatabase>
32​#include <QUuid>
33​#define GET 0
pinoUnsubmitted
Not Done

Twice?

pino: Twice?
34​#define POST 1
35​#define POSTBUFFERSIZE 65536
36​
37​using namespace std;
38​
39​namespace kt {
40​ WebServer::WebServer(CoreInterface * core): core(core)
41​ {
42​
43​ }
44​
45​ WebServer::~WebServer()
46​ {
47​ MHD_stop_daemon (daemon);
48​ delete listGenerator;
49​ }
50​
51​ static QMimeDatabase mimeDatabase;
52​
53​ static QString BASE_DIRECTORY = QString::fromLatin1("/usr/share/ktorrent/html/");
pinoUnsubmitted
Not Done

The hardcoded port is a no-go.

pino: The hardcoded port is a no-go.
54​
55​ TorrentListGenerator * WebServer::listGenerator;
56​
57​ QString WebServer::sessionToken;
pinoUnsubmitted
Not Done

Forever loop? How does it exit cleanly, then?

pino: Forever loop? How does it exit cleanly, then?
58​
59​ const char * WebServer::cookie;
60​
61​ static int respond404(MHD_Connection * connection)
62​ {
63​ int ret;
64​ struct MHD_Response *response;
65​
66​ const char * message = "<html><body>404: The requested resource was not found.</body></html>";
pinoUnsubmitted
Not Done

Hardcoded path.

pino: Hardcoded path.
67​
68​ response = MHD_create_response_from_buffer (strlen(message), (void *) message, MHD_RESPMEM_PERSISTENT);
69​ ret = MHD_queue_response (connection, MHD_HTTP_NOT_FOUND, response);
70​ MHD_add_response_header (response, MHD_HTTP_HEADER_CONTENT_ENCODING, "text/html");
71​ MHD_destroy_response (response);
72​ return ret;
pinoUnsubmitted
Not Done

method is leaked; considering its only use is to compare it to "GET", then just use memcmp with message->method.len instead.

pino: `method` is leaked; considering its only use is to compare it to `"GET"`, then just use…
73​ }
74​
75​ static int respond500(MHD_Connection * connection)
76​ {
pinoUnsubmitted
Not Done

Ditto (same as method for uri).

pino: Ditto (same as `method` for `uri`).
77​ int ret;
78​ struct MHD_Response *response;
79​
80​ const char * message = "<html><body>500: An internal server error has occured.</body></html>";
81​
pinoUnsubmitted
Not Done

size is not used. Considering my suggestion earlier regarding the return value of TorrentListGenerator::get, then that would solve this issue too.

pino: `size` is not used. Considering my suggestion earlier regarding the return value of…
82​ response = MHD_create_response_from_buffer (strlen(message), (void *) message, MHD_RESPMEM_PERSISTENT);
83​ ret = MHD_queue_response (connection, MHD_HTTP_INTERNAL_SERVER_ERROR, response);
84​ MHD_add_response_header (response, MHD_HTTP_HEADER_CONTENT_ENCODING, "text/html");
85​ MHD_destroy_response (response);
86​ return ret;
87​ }
88​
89​ struct Json
90​ {
91​ QString json;
pinoUnsubmitted
Not Done

body is leaked, and it is even used only in a specific situation (so no need to create it always).
Also, IMHO it would be much better to wrap the body as QByteArray, using fromRawData to avoid copying it, and pass that to TorrentListGenerator::post.

pino: `body` is leaked, and it is even used only in a specific situation (so no need to create it…
92​ bool firstPass;
93​ };
94​
95​ int WebServer::answer_to_connection(void * cls, struct MHD_Connection * connection,
96​ const char * url, const char * method,
97​ const char * version, const char * upload_data,
pinoUnsubmitted
Not Done

len is not used.

pino: `len` is not used.
98​ size_t * upload_data_size, void ** con_cls)
99​ {
100​ int ret;
101​ struct MHD_Response *response;
102​
103​ if (strcmp("/ktorrentdata", url) == 0 && strcmp("GET", method) == 0)
104​ {
105​ QByteArray json = listGenerator->get();
106​ response = MHD_create_response_from_buffer (json.size(), (void *) json.data(),
107​ MHD_RESPMEM_PERSISTENT);
108​ ret = MHD_queue_response (connection, MHD_HTTP_OK, response);
109​ MHD_destroy_response (response);
110​ return ret;
111​ }
112​ if (strcmp("/ktorrentaction", url) == 0 && strcmp("POST", method) == 0)
113​ {
114​ Json * json;
115​ if (*con_cls == NULL)
116​ {
117​ json = new Json();
118​ *con_cls = (void *) json;
119​ json->firstPass = true;
120​ }
121​ else
122​ {
123​ json = (Json *) *con_cls;
124​ }
125​
126​ if (json->firstPass) {
127​ json->firstPass = false;
128​ return MHD_YES;
129​ }
130​ if (*upload_data_size > 0 && !json->firstPass)
131​ {
132​ QString qJson = QString::fromLatin1(upload_data, *upload_data_size);
133​ json->json.append(qJson);
134​ if (checkForToken(connection))
135​ {
136​ listGenerator->post(json->json);
137​ }
138​ *upload_data_size = 0;
139​ return MHD_YES;
140​ }
141​ const char * validation = "{\"status\":\"Request received.\"}";
142​ response = MHD_create_response_from_buffer(strlen(validation), (void *) validation,
143​ MHD_RESPMEM_PERSISTENT);
144​ MHD_add_response_header(response, "Content-Type", "application/json");
145​ ret = MHD_queue_response(connection, MHD_HTTP_OK, response);
146​ MHD_destroy_response(response);
147​ return ret;
148​ }
149​ struct stat sbuf;
150​ int fd;
151​ if (0 == strcmp(url, "/") || 0 == strcmp(url, "/index"))
152​ {
153​ url = "index.html";
154​ }
155​ QString qUrl = QString::fromLatin1(url);
156​ const char * file = (BASE_DIRECTORY + qUrl).toLatin1().data();
157​ if ((-1 == (fd = open(file, O_RDONLY))) || (0 != fstat(fd, &sbuf)))
158​ {
159​ return respond404(connection);
160​ }
161​ response = MHD_create_response_from_fd_at_offset64(sbuf.st_size, fd, 0);
162​ const char * mimeType = mimeDatabase.mimeTypeForFile(qUrl).name().toLatin1().data();
163​ MHD_add_response_header(response, "Content-Type", mimeType);
164​ MHD_add_response_header(response, "Set-Cookie", makeCookie());
165​ ret = MHD_queue_response(connection, MHD_HTTP_OK, response);
166​ MHD_destroy_response (response);
167​ return ret;
168​ }
169​
170​ static void request_completed (void *cls, struct MHD_Connection *connection,
171​ void **con_cls, enum MHD_RequestTerminationCode toe)
172​ {
173​ Json * json = (Json *) *con_cls;
174​
175​ delete json;
176​ }
177​
178​ void WebServer::process()
179​ {
180​ listGenerator = new TorrentListGenerator(core);
181​ sessionToken = QUuid::createUuid().toString();
182​ cookie = makeCookie();
183​
184​ daemon = MHD_start_daemon(MHD_USE_SELECT_INTERNALLY, 8880, NULL, NULL,
185​ &answer_to_connection, NULL,
186​ MHD_OPTION_NOTIFY_COMPLETED, request_completed,
187​ NULL, MHD_OPTION_END);
188​ }
189​
190​ const char * WebServer::makeCookie()
191​ {
192​ QString tempString = QString::fromLatin1("token=") + sessionToken;
193​ return tempString.toLatin1().data();
194​ }
195​
196​ bool WebServer::checkForToken(MHD_Connection * connection)
197​ {
198​ const char * token = MHD_lookup_connection_value(connection, MHD_HEADER_KIND, "session-Token");
199​ if (token == NULL)
200​ {
201​ return false;
202​ }
203​ if (strcmp(token, sessionToken.toLatin1().data()) == 0)
204​ {
205​ return true;
206​ }
207​ return false;
208​ }
209​}