Differential D11070 Diff 29895 plugins/htmlinterface/torrentlistgenerator.cpp

Changeset View

Standalone View

View Options

plugins/htmlinterface/torrentlistgenerator.cpp

  • This file was added.
1​/***************************************************************************
2​ * Copyright (C) 2008 by Joris Guisson and Ivan Vasic *
3​ * joris.guisson@gmail.com *
4​ * ivasic@gmail.com *
5​ * *
6​ * Copyright (C) 2018 by Emmanuel Eytan *
7​ * eje211@gmail.com *
8​ * *
9​ * This program is free software; you can redistribute it and/or modify *
10​ * it under the terms of the GNU General Public License as published by *
11​ * the Free Software Foundation; either version 2 of the License, or *
12​ * (at your option) any later version. *
13​ * *
14​ * This program is distributed in the hope that it will be useful, *
15​ * but WITHOUT ANY WARRANTY; without even the implied warranty of *
16​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
17​ * GNU General Public License for more details. *
18​ * *
19​ * You should have received a copy of the GNU General Public License *
20​ * along with this program; if not, write to the *
21​ * Free Software Foundation, Inc., *
22​ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. *
23​ ***************************************************************************/
24​
25​#include <QChar>
26​#include <QJsonDocument>
27​#include <QJsonObject>
28​#include <QJsonArray>
29​#include <QJsonValue>
30​#include <QMap>
31​#include <QString>
32​#include <iostream>
33​
34​#include "torrentlistgenerator.h"
35​#include <util/sha1hash.h>
36​#include <torrent/queuemanager.h>
37​#include <torrent/magnetmanager.h>
38​#include <interfaces/coreinterface.h>
39​
40​using namespace bt;
41​using namespace std;
42​
43​namespace kt
44​{
45​
46​ TorrentListGenerator::TorrentListGenerator(CoreInterface* core): core(core)
47​ {
48​ }
49​
50​
51​ TorrentListGenerator::~TorrentListGenerator()
52​ {
53​ }
54​
55​
56​ QByteArray TorrentListGenerator::get()
57​ {
58​ kt::QueueManager* qman = core->getQueueManager();
59​ kt::QueueManager::iterator i = qman->begin();
pinoUnsubmitted
Not Done

QJsonArray array; is enough (also for other variables in this file).

pino: `QJsonArray array;` is enough (also for other variables in this file).
60​ QJsonArray array;
61​ while (i != qman->end())
62​ {
63​ bt::TorrentInterface* ti = *i;
64​ const bt::TorrentStats& s = ti->getStats();
65​
66​ QJsonObject json;
67​ json.insert(QString::fromLatin1("name"), ti->getDisplayName());
68​ json.insert(QString::fromLatin1("infoHash"), ti->getInfoHash().toString());
69​ json.insert(QString::fromLatin1("status"), s.status);
70​ json.insert(QString::fromLatin1("timeAdded"), s.time_added.toMSecsSinceEpoch());
71​ json.insert(QString::fromLatin1("bytesDownloaded"), (double) s.bytes_downloaded);
72​ json.insert(QString::fromLatin1("bytesUploaded"), (double) s.bytes_uploaded);
73​ json.insert(QString::fromLatin1("totalBytes"), (double) s.total_bytes);
74​ json.insert(QString::fromLatin1("totalBytesToDownload"), (double) s.total_bytes_to_download);
75​ json.insert(QString::fromLatin1("downloadRate"), (double) s.download_rate);
76​ json.insert(QString::fromLatin1("uploadRate"), (double) s.upload_rate);
77​ json.insert(QString::fromLatin1("numPeers"), (double) s.num_peers);
78​ json.insert(QString::fromLatin1("seeders"), (double) s.seeders_connected_to);
79​ json.insert(QString::fromLatin1("seedersTotal"), (double) s.seeders_total);
80​ json.insert(QString::fromLatin1("leechers"), (double) s.leechers_connected_to);
81​ json.insert(QString::fromLatin1("leechersTotal"), (double) s.leechers_total);
82​ json.insert(QString::fromLatin1("running"), s.running);
83​ json.insert(QString::fromLatin1("numFiles"), (double) ti->getNumFiles());
84​ array.append(json);
85​ i++;
86​ }
87​ QJsonObject message;
88​ message.insert(QString::fromLatin1("torrents"), array);
89​ return QJsonDocument(message).toJson();
90​ }
pinoUnsubmitted
Not Done

This converts the document to QByteArray twice.
Also, when the scope of this block ends, the data to which *str_p points to becomes a dangling pointer.
Why not just return the QByteArray?

pino: This converts the document to QByteArray twice. Also, when the scope of this block ends, the…
91​
92​ void TorrentListGenerator::post(QString json)
93​ {
pinoUnsubmitted
Not Done

Since it does not modify its argument, make the json parameter of post as const char * (and remove the cast later on).

pino: Since it does not modify its argument, make the `json` parameter of `post` as `const char *`…
94​ QJsonDocument doc = QJsonDocument::fromJson(json.toLatin1());
95​ QMap<QString, QVariant> qJson = doc.toVariant().toMap();
96​
97​ QString action = qJson[QString::fromLatin1("type")].toString();
98​
99​ if (action.isEmpty())
pinoUnsubmitted
Not Done

An null QString is also empty, so just check for isEmpty (also in other places in this file).

pino: An null QString is also empty, so just check for `isEmpty` (also in other places in this file).
100​ {
101​ return;
102​ }
103​
104​ if (action == QString::fromLatin1("magnet"))
105​ {
106​ QString magnet = qJson[QString::fromLatin1("magnet")].toString();
107​ if (magnet.isEmpty())
108​ {
109​ return;
110​ }
111​ QUrl url = QUrl(magnet);
112​ if (!url.isValid())
113​ {
114​ return;
115​ }
116​ core->loadSilently(url, QString());
117​ return;
118​ }
119​
120​ QString hash = qJson[QString::fromLatin1("hash")].toString();
121​ if (hash.isEmpty())
122​ {
123​ return;
124​ }
125​
126​ TorrentInterface * ti = getTorrentFromHash(hash);
127​ if (action == QString::fromLatin1("start"))
128​ {
129​ if (ti->getStats().paused)
130​ {
pinoUnsubmitted
Not Done

Chain the various if's together, so not all the checks will be performed every time:

if (action == QLatin1String("start")) {
  ...
} else if (action == QLatin1String("pause")) {
  ...
} ...
pino: Chain the various if's together, so not all the checks will be performed every time: ```if…
131​ ti->unpause();
132​ }
133​ else
134​ {
135​ ti->start();
136​ }
137​ }
138​ else if (action == QString::fromLatin1("stop"))
139​ {
140​ core->stop(ti);
141​ }
pinoUnsubmitted
Not Done

hash is leaked. Just return it by value in QStringToSHA1Hash.

pino: `hash` is leaked. Just return it by value in `QStringToSHA1Hash`.
142​ else if (action == QString::fromLatin1("remove"))
143​ {
144​ core->remove(ti, false);
145​ }
146​ }
147​
148​ /**
149​ * From: https://github.com/KDE/libktorrent/blob/master/src/dht/tests/keytest.cpp
150​ */
151​ static Uint8 HexCharToUint8(char c)
152​ {
153​ if (c >= 'a' && c <= 'f')
154​ return 10 + (c - 'a');
155​ else if (c >= 'A' && c <= 'F')
156​ return 10 + (c - 'A');
157​ else if (c >= '0' && c <= '9')
158​ return c - '0';
159​ else
160​ return 0;
161​ }
162​
163​ /**
164​ * Based on: https://github.com/KDE/libktorrent/blob/master/src/dht/tests/keytest.cpp
165​ */
166​ static Uint8 * HashFromHexString(QString & str)
167​ {
168​ bt::Uint8 * result = new Uint8[20];
169​ std::fill(result, result + 20, 0);
170​
171​ QString s = str.toLower();
172​ if (s.size() % 2 != 0)
173​ {
174​ s.prepend(QChar::fromLatin1('0'));
175​ }
176​
177​ int j = 19;
178​
179​ for (int i = s.size() - 1; i >= 0; i -= 2)
180​ {
181​ char left = s[i - 1].toLatin1();
182​ char right = s[i].toLatin1();
pinoUnsubmitted
Not Done

Instead of shamelessly copying code from stackoverflow, use at least code already written in libktorrent: in src/dht/tests/keytest.cpp, see HexCharToUint8 (usable as-is) and KeyFromHexString (mostly similar).

pino: Instead of shamelessly copying code from stackoverflow, use at least code already written in…
183​ result[j--] = (HexCharToUint8(left) << 4) | HexCharToUint8(right);
184​ }
185​ return result;
186​ }
187​
188​ static const SHA1Hash * QStringToSHA1Hash(QString qString) {
189​ Uint8 * hashNum = HashFromHexString(qString);
190​ const SHA1Hash * hash = new SHA1Hash(hashNum);
191​ delete hashNum;
192​ return hash;
193​ }
194​
195​ TorrentInterface * TorrentListGenerator::getTorrentFromHash(QString qHash)
196​ {
197​ const SHA1Hash * hash = QStringToSHA1Hash(qHash);
198​ kt::QueueManager* qman = core->getQueueManager();
199​ kt::QueueManager::iterator i = qman->begin();
200​ while (i != qman->end())
201​ {
202​ bt::TorrentInterface* ti = *i;
203​ if (ti->getInfoHash() == *hash)
204​ {
205​ delete hash;
206​ return ti;
207​ }
208​ i++;
209​ }
210​ delete hash;
211​ return NULL;
212​ }
213​}