Differential D726 Diff 1681 kexi/core/KexiView.cpp

Changeset View

Standalone View

View Options

kexi/core/KexiView.cpp

Context not available.
26#include <koproperty/Set.h> 26​#include <koproperty/Set.h>
27 27​
28#include <db/connection.h> 28​#include <db/connection.h>
29​#include <db/cursor.h>
29#include <db/utils.h> 30​#include <db/utils.h>
30#include <kexiutils/utils.h> 31​#include <kexiutils/utils.h>
31#include <kexiutils/SmallToolButton.h> 32​#include <kexiutils/SmallToolButton.h>
Context not available.
555 window()->removeView(mode); 556​ window()->removeView(mode);
556} 557​}
557 558​
559​bool KexiView::setWidgetData(KexiDB::Cursor *cursor)
piggzUnsubmitted
Not Done

nothing is being set here ... suggest alternate name?

piggz: nothing is being set here ... suggest alternate name?
staniekAuthorUnsubmitted
Not Done

Probably but the purpose of the method is to really set data to the 'data widget' - you can see that easily in the KexiDataTableView::setWidgetData() implementation. The cursor->open() default is just sufficient for forms and reports.

staniek: Probably but the purpose of the method is to really set data to the 'data widget' - you can see…
560​{
561​ return cursor->open();
562​}
563​
564​bool KexiView::setData(KexiDB::Cursor *cursor)
565​{
566​ bool ok = setWidgetData(cursor);
567​ if (!ok && cursor) {
568​ // A simple workaround needed because the cursor will be destroyed before
569​ // the error message is built. Kexi 3 would have cleaner solution.
570​ // See https://bugs.kde.org/show_bug.cgi?id=356888
571​ QString msg = cursor->errorMsg();
572​ QString desc;
573​ if (!cursor->serverErrorMsg().isEmpty()) {
574​ if (msg.isEmpty()) {
575​ msg = cursor->serverErrorMsg();
576​ } else {
577​ desc = cursor->serverErrorMsg();
578​ }
579​ }
580​ window()->setStatus(msg, desc, cursor->recentSQLString());
581​ }
582​ return ok;
583​}
584​
558void KexiView::setFocus() 585​void KexiView::setFocus()
559{ 586​{
560 if (!d->lastFocusedChildBeforeFocusOut.isNull()) { 587​ if (!d->lastFocusedChildBeforeFocusOut.isNull()) {
Context not available.