Differential D11012 Diff 29238 src/trash/dolphintrash.h

Changeset View

Standalone View

View Options

src/trash/dolphintrash.h

  • This file was copied from src/panels/places/placesitemsignalhandler.cpp.
1/*************************************************************************** 1​/***************************************************************************
2 * Copyright (C) 2012 by Peter Penz <peter.penz19@gmail.com> * 2​ * Copyright (C) 2012 by Peter Penz <peter.penz19@gmail.com> *
3​ * Copyright (C) 2018 by Roman Inflianskas <infroma@gmail.com> *
3 * * 4​ * *
4 * This program is free software; you can redistribute it and/or modify * 5​ * This program is free software; you can redistribute it and/or modify *
5 * it under the terms of the GNU General Public License as published by * 6​ * it under the terms of the GNU General Public License as published by *
6 * the Free Software Foundation; either version 2 of the License, or * 7​ * the Free Software Foundation; either version 2 of the License, or *
7 * (at your option) any later version. * 8​ * (at your option) any later version. *
8 * * 9​ * *
9 * This program is distributed in the hope that it will be useful, * 10​ * This program is distributed in the hope that it will be useful, *
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of * 11​ * but WITHOUT ANY WARRANTY; without even the implied warranty of *
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * 12​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
12 * GNU General Public License for more details. * 13​ * GNU General Public License for more details. *
13 * * 14​ * *
14 * You should have received a copy of the GNU General Public License * 15​ * You should have received a copy of the GNU General Public License *
15 * along with this program; if not, write to the * 16​ * along with this program; if not, write to the *
16 * Free Software Foundation, Inc., * 17​ * Free Software Foundation, Inc., *
17 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA * 18​ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA *
18 ***************************************************************************/ 19​ ***************************************************************************/
19 20​
20#include "placesitemsignalhandler.h" 21​#ifndef DOLPHINTRASH_H
22​#define DOLPHINTRASH_H
21 23​
22#include "placesitem.h" 24​#include <QWidget>
23 25​
24PlacesItemSignalHandler::PlacesItemSignalHandler(PlacesItem* item, 26​#include <KIO/EmptyTrashJob>
25 QObject* parent) : 27​#include <KIOWidgets/KDirLister>
26 QObject(parent), ​
27 m_item(item) ​
28{ ​
29} ​
30 ​
31PlacesItemSignalHandler::~PlacesItemSignalHandler() ​
32{ ​
33} ​
34 28​
35void PlacesItemSignalHandler::onAccessibilityChanged() 29​class Trash: public QObject
36{ 30​{
37 if (m_item) { 31​ Q_OBJECT
38 m_item->onAccessibilityChanged(); ​
39 } ​
40} ​
41 32​
42void PlacesItemSignalHandler::onTrashDirListerCompleted() 33​public:
43{ 34​ // delete copy and move constructors and assign operators
44 if (m_item) { 35​ Trash(Trash const&) = delete;
45 m_item->onTrashDirListerCompleted(); 36​ Trash(Trash&&) = delete;
46 } 37​ Trash& operator=(Trash const&) = delete;
47} 38​ Trash& operator=(Trash &&) = delete;
48 39​
49void PlacesItemSignalHandler::onTearDownRequested(const QString& udi) 40​ static Trash& instance();
50{ 41​ static KIO::Job* empty(QWidget *window);
51 Q_UNUSED(udi) 42​ static bool isEmpty();
elvisangelaccioUnsubmitted
Done

These methods don't use m_trashDirLister, right? => they should be static

elvisangelaccio: These methods don't use `m_trashDirLister`, right? => they should be `static`
52 if (m_item) { 43​
53 Solid::StorageAccess *tmp = m_item->device().as<Solid::StorageAccess>(); 44​signals:
54 if (tmp) { 45​ void emptinessChanged(bool isEmpty);
55 QString mountPath = tmp->filePath(); 46​
56 emit tearDownExternallyRequested(mountPath); 47​private:
57 } 48​ KDirLister *m_trashDirLister;
58 } 49​
elvisangelaccioUnsubmitted
Done

Why protected instead of private?

elvisangelaccio: Why `protected` instead of `private`?
59} 50​ Trash();
51​ ~Trash();
52​};
60 53​
54​#endif // DOLPHINTRASH_H