Differential D11136 Diff 29096 plugins/custommake/custommakemanager.cpp

Changeset View

Standalone View

View Options

plugins/custommake/custommakemanager.cpp

Show First 20 Lines • Show All 318 Lines • ▼ Show 20 Line(s)317{
319 m_projectPaths.remove(project->path().path()); 319​ m_projectPaths.remove(project->path().path());
320} 320​}
321 321​
322void CustomMakeManager::unload() 322​void CustomMakeManager::unload()
323{ 323​{
324 IDefinesAndIncludesManager::manager()->unregisterBackgroundProvider(m_provider.data()); 324​ IDefinesAndIncludesManager::manager()->unregisterBackgroundProvider(m_provider.data());
325} 325​}
326 326​
327#include "custommakemanager.moc" 327​KDevelop::Path CustomMakeManager::compiler(KDevelop::ProjectTargetItem* item) const
328​{
329​ return {};
mwolffUnsubmitted
Not Done

this should not return anything and let the IADM figure out a sane default

and we should probably add a TODO to expand the custom make manager to allow setting the compiler for a given target

mwolff: this should not return anything and let the IADM figure out a sane default and we should…
mwolffUnsubmitted
Done

return empty

mwolff: return empty
330​}
328 331​
332​#include "custommakemanager.moc"