Differential D11064 Diff 28767 kcms/fonts/package/contents/ui/main.qml

Changeset View

Standalone View

View Options

kcms/fonts/package/contents/ui/main.qml

Show All 13 Lines1/*
14 You should have received a copy of the GNU Library General Public License 14​ You should have received a copy of the GNU Library General Public License
15 along with this library; see the file COPYING.LIB. If not, write to 15​ along with this library; see the file COPYING.LIB. If not, write to
16 the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 16​ the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17 Boston, MA 02110-1301, USA. 17​ Boston, MA 02110-1301, USA.
18*/ 18​*/
19 19​
20import QtQuick 2.1 20​import QtQuick 2.1
21import QtQuick.Layouts 1.1 21​import QtQuick.Layouts 1.1
22import QtQuick.Controls 2.0 as QtControls 22​import QtQuick.Controls 2.0 as QtControls
broulikUnsubmitted
Done

Is 2.2 also sufficient (Qt 5.9)?

broulik: Is `2.2` also sufficient (Qt 5.9)?
progwolffAuthorUnsubmitted
Done

Seems like even 2.0 is okay.
I misinterpreted the docs where it says import QtQuick.Controls 2.3.

progwolff: Seems like even `2.0` is okay. I misinterpreted the docs where it says `import QtQuick.Controls…
23import QtQuick.Dialogs 1.2 as QtDialogs 23​import QtQuick.Dialogs 1.2 as QtDialogs
24​import QtQuick.Window 2.0 as QtWindow
24import org.kde.kirigami 2.3 as Kirigami 25​import org.kde.kirigami 2.3 as Kirigami
25import org.kde.kcm 1.1 as KCM 26​import org.kde.kcm 1.1 as KCM
26 27​
27KCM.SimpleKCM { 28​KCM.SimpleKCM {
28 id: root 29​ id: root
29 30​
30 KCM.ConfigModule.quickHelp: i18n("Fonts") 31​ KCM.ConfigModule.quickHelp: i18n("Fonts")
31 32​
▲ Show 20 Lines • Show All 101 Lines • ▼ Show 20 Line(s)133 QtControls.ComboBox {
133 id: subPixelCombo 134​ id: subPixelCombo
134 Layout.preferredWidth: formLayout.maxImplicitWidth 135​ Layout.preferredWidth: formLayout.maxImplicitWidth
135 Kirigami.FormData.label: i18n("Sub-pixel rendering type:") 136​ Kirigami.FormData.label: i18n("Sub-pixel rendering type:")
136 currentIndex: kcm.fontAASettings.subPixelCurrentIndex 137​ currentIndex: kcm.fontAASettings.subPixelCurrentIndex
137 onCurrentIndexChanged: kcm.fontAASettings.subPixelCurrentIndex = currentIndex; 138​ onCurrentIndexChanged: kcm.fontAASettings.subPixelCurrentIndex = currentIndex;
138 model: kcm.fontAASettings.subPixelOptionsModel 139​ model: kcm.fontAASettings.subPixelOptionsModel
139 textRole: "display" 140​ textRole: "display"
140 enabled: antiAliasingComboBox.currentIndex == 0 141​ enabled: antiAliasingComboBox.currentIndex == 0
142​ delegate: QtControls.ItemDelegate {
143​ id: subPixelDelegate
144​ width: subPixelComboImage.implicitWidth
broulikUnsubmitted
Done

The popup width is too small, the text cut off. Either make it larger or at least elide the text on the right

broulik: The popup width is too small, the text cut off. Either make it larger or at least elide the…
145​ contentItem: ColumnLayout {
146​ id: subPixelLayout
147​ width: subPixelComboImage.implicitWidth
148​ QtControls.Label {
broulikUnsubmitted
Done

Use QtQuick Controls Label instead of plain Text for proper rendering and text color

broulik: Use QtQuick Controls `Label` instead of plain `Text` for proper rendering and text color
149​ id: subPixelComboText
150​ text: model.display
151​ }
152​ Image {
153​ id: subPixelComboImage
154​ source: "image://preview/" + model.index + "_" + kcm.fontAASettings.hintingCurrentIndex + ".png"
broulikUnsubmitted
Done

This is the default, no need to explicitly specify

broulik: This is the default, no need to explicitly specify
155​ transform: Scale {
broulikUnsubmitted
Done

Also not needed

broulik: Also not needed
156​ xScale: 1. / QtWindow.Screen.devicePixelRatio;
broulikUnsubmitted
Done

Coding style, add spaces between:

source: "image://preview/" + model.index + "_" + kcm.fontAASettings.hintCurrentIndex + ".png"
broulik: Coding style, add spaces between: ``` source: "image://preview/" + model.index + "_" + kcm.
157​ yScale: 1. / QtWindow.Screen.devicePixelRatio;
158​ }
159​ }
160​ }
161​ }
141 } 162​ }
142 163​
143 QtControls.ComboBox { 164​ QtControls.ComboBox {
144 id: hintingCombo 165​ id: hintingCombo
145 Layout.preferredWidth: formLayout.maxImplicitWidth 166​ Layout.preferredWidth: formLayout.maxImplicitWidth
146 Kirigami.FormData.label: i18n("Hinting style:") 167​ Kirigami.FormData.label: i18n("Hinting style:")
147 currentIndex: kcm.fontAASettings.hintingCurrentIndex 168​ currentIndex: kcm.fontAASettings.hintingCurrentIndex
148 onCurrentTextChanged: kcm.fontAASettings.hintingCurrentIndex = currentIndex; 169​ onCurrentTextChanged: kcm.fontAASettings.hintingCurrentIndex = currentIndex;
149 model: kcm.fontAASettings.hintingOptionsModel 170​ model: kcm.fontAASettings.hintingOptionsModel
150 textRole: "display" 171​ textRole: "display"
151 enabled: antiAliasingComboBox.currentIndex == 0 172​ enabled: antiAliasingComboBox.currentIndex == 0
173​ delegate: QtControls.ItemDelegate {
174​ id: hintingDelegate
175​ width: hintingComboImage.implicitWidth
176​ contentItem: ColumnLayout {
177​ id: hintingLayout
178​ width: hintingComboImage.implicitWidth
179​ QtControls.Label {
180​ id: hintingComboText
181​ text: model.display
182​ }
183​ Image {
184​ id: hintingComboImage
185​ source: "image://preview/" + kcm.fontAASettings.subPixelCurrentIndex + "_" + model.index + ".png"
186​ transform: Scale {
187​ xScale: 1. / QtWindow.Screen.devicePixelRatio;
davidedmundsonUnsubmitted
Done

We dont' need these transforms.
There shouldn't be any high DPI specicfic code in QML.

davidedmundson: We dont' need these transforms. There shouldn't be any high DPI specicfic code in QML.
188​ yScale: 1. / QtWindow.Screen.devicePixelRatio;
189​ }
190​ }
191​ }
192​ }
152 } 193​ }
153 194​
154 RowLayout { 195​ RowLayout {
155 QtControls.CheckBox { 196​ QtControls.CheckBox {
156 id: dpiCheckBox 197​ id: dpiCheckBox
157 checked: dpiSpinBox.value != 96 198​ checked: dpiSpinBox.value != 96
158 text: i18n("Force Fonts DPI:") 199​ text: i18n("Force Fonts DPI:")
159 onCheckedChanged: { 200​ onCheckedChanged: {
Show All 36 Lines