Differential D10959 Diff 28674 src/panels/terminal/terminalpanel.h

Changeset View

Standalone View

src/panels/terminal/terminalpanel.h

Show First 20 Lines • Show All 49 Lines • ▼ Show 20 Line(s)		47	public:
50		50
51	/**	51		/**
52	* @brief This function is used to set the terminal panels's cwd to	52		* @brief This function is used to set the terminal panels's cwd to
53	* home when an unmounting request is received.	53		* home when an unmounting request is received.
54	*/	54		*/
55	void goHome();	55		void goHome();
56	QString currentWorkingDirectory();	56		QString currentWorkingDirectory();
57	bool isHiddenInVisibleWindow();	57		bool isHiddenInVisibleWindow();
		58		void setFocus(Qt::FocusReason reason);
			elvisangelaccioUnsubmitted Done Should be `const` elvisangelaccio: Should be `const`
		59		bool hasFocus();
58		60
59	public slots:	61		public slots:
60	void terminalExited();	62		void terminalExited();
61	void dockVisibilityChanged();	63		void dockVisibilityChanged();
		64		void setFocus();
			elvisangelaccioUnsubmitted Done `QWidget::setFocus()`, `QWidget::hasFocus()` and `QWidget::setFocus(Qt::FocusReason reason)` are not virtual, I'm not sure this is a good idea. elvisangelaccio: `QWidget::setFocus()`, `QWidget::hasFocus()` and `QWidget::setFocus(Qt::FocusReason reason)`…
			rominfUnsubmitted Done I've tried to use `focusProxy` but it didn't work (maybe it's just me). What do you propose? rominf: I've tried to use `focusProxy` but it didn't work (maybe it's just me). What do you propose?
62		65
63	signals:	66		signals:
64	void hideTerminalPanel();	67		void hideTerminalPanel();
65		68
66	/**	69		/**
67	* Is emitted if the an URL change is requested.	70		* Is emitted if the an URL change is requested.
68	*/	71		*/
69	void changeUrl(const QUrl& url);	72		void changeUrl(const QUrl& url);
Show All 32 Lines