Differential D10901 Diff 28221 applet/contents/ui/ListItemBase.qml

Changeset View

Standalone View

View Options

applet/contents/ui/ListItemBase.qml

Context not available.
331 contextMenu.addMenuItem(menuItem); 331​ contextMenu.addMenuItem(menuItem);
332 } 332​ }
333 } 333​ }
334​
335​ // Choose output / input device
336​ // By choice only shown when there are at least two options
337​ if ((type == "sink-input" && sinkView.model.count > 1) || (type == "source-input" && sourceView.model.count > 1)) {
338​ contextMenu.addMenuItem(newSeperator());
droscaUnsubmitted
Done

sinkView.model.count > 1 -> sinkView.count

drosca: `sinkView.model.count > 1` -> `sinkView.count`
droscaUnsubmitted
Done

Sorry about this comment, it's nonsense. It was fine in your fist diff.

It must check > 1 not just > 0.

drosca: Sorry about this comment, it's nonsense. It was fine in your fist diff. It must check `> 1`…
339​ var menuItem = newMenuItem();
340​ if (type == "sink-input") {
droscaUnsubmitted
Not Done

if (

drosca: `if (`
341​ menuItem.text = i18nc("Heading for a list of possible output devices (speakers, headphones, ...) to choose", "Play audio using");
342​ } else {
343​ menuItem.text = i18nc("Heading for a list of possible input devices (built-in microphone, headset, ...) to choose", "Record audio using");
droscaUnsubmitted
Not Done

} else { on the same line

drosca: `} else {` on the same line
344​ }
345​ menuItem.section = true;
346​ contextMenu.addMenuItem(menuItem);
347​ var sModel = type == "sink-input" ? sinkView.model : sourceView.model;
348​
349​ for (var i = 0; i < sModel.count; ++i) {
350​ var data = sModel.get(i);
droscaUnsubmitted
Not Done

extra newline

drosca: extra newline
351​ var menuItem = newMenuItem();
352​ menuItem.text = data.Description;
353​ menuItem.enabled = true;
354​ menuItem.checkable = true;
355​ menuItem.checked = data.Index === PulseObject.deviceIndex;
356​ var setActiveSink = function(sinkIndex) {
357​ return function() {
358​ PulseObject.deviceIndex = sinkIndex;
359​ };
360​ };
361​ menuItem.clicked.connect(setActiveSink(data.Index));
362​ contextMenu.addMenuItem(menuItem);
363​ }
364​ }
334 } 365​ }
335 366​
336 function show() { 367​ function show() {
Context not available.