Differential D7401 Diff 27395 src/solid/devices/backends/iokit/iokitvolume.h

Changeset View

Standalone View

View Options

src/solid/devices/backends/iokit/iokitvolume.h

  • This file was added.
1​/*
2​ Copyright 2017 René J.V. Bertin <rjvbertin@gmail.com>
3​
4​ This library is free software; you can redistribute it and/or
5​ modify it under the terms of the GNU Lesser General Public
6​ License as published by the Free Software Foundation; either
7​ version 2.1 of the License, or (at your option) version 3, or any
8​ later version accepted by the membership of KDE e.V. (or its
9​ successor approved by the membership of KDE e.V.), which shall
10​ act as a proxy defined in Section 6 of version 3 of the license.
11​
12​ This library is distributed in the hope that it will be useful,
13​ but WITHOUT ANY WARRANTY; without even the implied warranty of
14​ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15​ Lesser General Public License for more details.
16​
17​ You should have received a copy of the GNU Lesser General Public
18​ License along with this library. If not, see <http://www.gnu.org/licenses/>.
19​*/
20​
21​#ifndef SOLID_BACKENDS_IOKIT_VOLUME_H
22​#define SOLID_BACKENDS_IOKIT_VOLUME_H
23​
24​#include <solid/devices/ifaces/storagevolume.h>
25​#include "iokitblock.h"
26​#include "dadictionary_p.h"
27​
28​#include <DiskArbitration/DiskArbitration.h>
29​
30​namespace Solid
31​{
32​namespace Backends
33​{
34​namespace IOKit
35​{
36​class IOKitVolume : public Block, virtual public Solid::Ifaces::StorageVolume
37​{
38​ Q_OBJECT
39​ Q_INTERFACES(Solid::Ifaces::StorageVolume)
40​
41​public:
42​ IOKitVolume(IOKitDevice *device);
43​ IOKitVolume(const IOKitDevice *device);
44​ virtual ~IOKitVolume();
45​
46​ bool isIgnored() const Q_DECL_OVERRIDE;
kfunkUnsubmitted
Done

Here and below: Missing Q_DECL_OVERRIDE again

kfunk: Here and below: Missing `Q_DECL_OVERRIDE` again
kfunkUnsubmitted
Done

No virtual needed if there's already a Q_DECL_OVERRIDE or override.

kfunk: No `virtual` needed if there's already a `Q_DECL_OVERRIDE` or `override`.
rjvbbAuthorUnsubmitted
Not Done

I guess that's safe here because IOKitOpticalDisc doesn't override any of these methods?

rjvbb: I guess that's safe here because IOKitOpticalDisc doesn't override any of these methods?
47​ Solid::StorageVolume::UsageType usage() const Q_DECL_OVERRIDE;
48​ QString fsType() const Q_DECL_OVERRIDE;
49​ QString label() const Q_DECL_OVERRIDE;
50​ QString uuid() const Q_DECL_OVERRIDE;
51​ qulonglong size() const Q_DECL_OVERRIDE;
52​ QString encryptedContainerUdi() const Q_DECL_OVERRIDE;
53​
54​ QString vendor() const;
kfunkUnsubmitted
Done

Here and below: No const for return types on implicitly-shared types (just adds noise)

The functions can be made const though.

kfunk: Here and below: No `const` for return types on implicitly-shared types (just adds noise) The…
55​ QString product() const;
56​ QString description() const;
57​
58​ DADiskRef daRef() const;
59​
60​private:
61​ DADictionary *daDict;
62​};
63​}
64​}
65​}
66​
67​#endif // SOLID_BACKENDS_IOKIT_VOLUME_H