Differential D7401 Diff 27395 src/solid/devices/backends/iokit/iokitstorageaccess.cpp

Changeset View

Standalone View

src/solid/devices/backends/iokit/iokitstorageaccess.cpp

This file was added.

1		/*
2		Copyright 2017 René J.V. Bertin <rjvbertin@gmail.com>
3
4		This library is free software; you can redistribute it and/or
5		modify it under the terms of the GNU Lesser General Public
6		License as published by the Free Software Foundation; either
7		version 2.1 of the License, or (at your option) version 3, or any
8		later version accepted by the membership of KDE e.V. (or its
9		successor approved by the membership of KDE e.V.), which shall
10		act as a proxy defined in Section 6 of version 3 of the license.
11
12		This library is distributed in the hope that it will be useful,
13		but WITHOUT ANY WARRANTY; without even the implied warranty of
14		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
15		Lesser General Public License for more details.
16
17		You should have received a copy of the GNU Lesser General Public
18		License along with this library. If not, see <http://www.gnu.org/licenses/>.
19		*/
20
21		#include "iokitstorageaccess.h"
22
23		#include <QDebug>
24
25		#include <CoreFoundation/CoreFoundation.h>
26		#include <DiskArbitration/DiskArbitration.h>
27
28		using namespace Solid::Backends::IOKit;
29
30		IOKitStorageAccess::IOKitStorageAccess(IOKitDevice *device)
31		: DeviceInterface(device)
32		, daDict(new DADictionary(device))
33		{
34		connect(device, SIGNAL(propertyChanged(QMap<QString,int>)),
35		this, SLOT(onPropertyChanged(QMap<QString,int>)));
36		}
37
38		IOKitStorageAccess::IOKitStorageAccess(const IOKitDevice *device)
39		: DeviceInterface(device)
40		, daDict(new DADictionary(device))
41		{
42		connect(device, SIGNAL(propertyChanged(QMap<QString,int>)),
	kfunkUnsubmitted Done Here and below: `nullptr` kfunk: Here and below: `nullptr`
43		this, SLOT(onPropertyChanged(QMap<QString,int>)));
44		}
45
46		IOKitStorageAccess::~IOKitStorageAccess()
47		{
48		delete daDict;
49		}
50
51		bool IOKitStorageAccess::isAccessible() const
52		{
53		filePath();
54		const QVariant isMounted = m_device->property(QStringLiteral("isMounted"));
55		return isMounted.isValid() && isMounted.toBool();
56		}
57
	kfunkUnsubmitted Done Dito, inconsistent member naming. kfunk: Dito, inconsistent member naming.
58		QString IOKitStorageAccess::filePath() const
59		{
60		// mount points can change (but can they between invocations of filePath()?)
61		QString mountPoint;
62		if (const CFURLRef urlRef = daDict->cfUrLRefForKey(kDADiskDescriptionVolumePathKey)) {
63		const CFStringRef mpRef = CFURLCopyFileSystemPath(urlRef, kCFURLPOSIXPathStyle);
64		mountPoint = QString::fromCFString(mpRef);
65		CFRelease(mpRef);
66		m_device->setProperty("mountPoint", QVariant(mountPoint));
67		bool isMounted = !mountPoint.isEmpty();
68		const QString isMountedKey = QStringLiteral("isMounted");
69		const QVariant wasMounted = m_device->property(isMountedKey);
70		if (wasMounted.isValid() && wasMounted.toBool() != isMounted) {
71		IOKitStorageAccess(m_device).onPropertyChanged(QMap<QString,int>{{isMountedKey,isMounted}});
72		}
73		m_device->setProperty("isMounted", QVariant(isMounted));
74		}
75		return mountPoint;
76		}
77
78		bool IOKitStorageAccess::isIgnored() const
79		{
80		if (m_device->iOKitPropertyExists(QStringLiteral("Open"))) {
81		// ignore storage volumes that aren't mounted
82		bool isIgnored = m_device->property(QStringLiteral("Open")).toBool() == false;
83		m_device->setProperty("isIgnored", QVariant(isIgnored));
84		return isIgnored;
85		}
86		const QVariant isIgnored = m_device->property(QStringLiteral("isIgnored"));
87		return isIgnored.isValid() && isIgnored.toBool();
88		}
89
90		bool IOKitStorageAccess::setup()
91		{
92		// TODO?
	kfunkUnsubmitted Done Early-return would reduce the indentation level here [1]. if (errorCase) // return early return {}; } // normal case // ... [1] https://softwareengineering.stackexchange.com/questions/18454/should-i-return-from-a-function-early-or-use-an-if-statement kfunk: Early-return would reduce the indentation level here [1]. ``` if (errorCase) // return early…
	rjvbbAuthorUnsubmitted Not Done Compromise. Too many return points make functions hard to maintain (Apple code tends to be full of `goto bail;` instructions because of that; we're far here from the nesting you'd get without those in code using the QT SDK.) rjvbb: Compromise. Too many return points make functions hard to maintain (Apple code tends to be full…
93		return false;
94		}
95
96		bool IOKitStorageAccess::teardown()
97		{
98		// TODO?
99		return false;
100		}
101
102		void IOKitStorageAccess::onPropertyChanged(const QMap<QString, int> &changes)
103		{
104		Q_FOREACH (const QString &property, changes.keys()) {
105		if (property == QStringLiteral("isMounted")) {
106		emit accessibilityChanged(m_device->property(QStringLiteral("isMounted")).toBool(), m_device->udi());
107		}
108		}
109		}
110
	kfunkUnsubmitted Done Coding style: Eliminate `else` branch, just `return in function-level scope. kfunk: Coding style: Eliminate `else` branch, just `return in function-level scope.
	kfunkUnsubmitted Done Dito kfunk: Dito