Differential D10301 Diff 26732 src/Gui/KSMainWindow.cpp

Changeset View

Standalone View

View Options

src/Gui/KSMainWindow.cpp

Show First 20 Lines • Show All 183 Lines • ▼ Show 20 Line(s)108{
184 // disable onClick mode if not available on the platform 184​ // disable onClick mode if not available on the platform
185 185​
186 if (!mOnClickAvailable) { 186​ if (!mOnClickAvailable) {
187 mKSWidget->disableOnClick(); 187​ mKSWidget->disableOnClick();
188 } 188​ }
189 resize(QSize(840, 420).expandedTo(minimumSize())); 189​ resize(QSize(840, 420).expandedTo(minimumSize()));
190 190​
191 191​
192 // done with the init 192​ // done with the init
193} 193​}
rkflxUnsubmitted
Done

This works for me too and might be more modern Qt:

QAction *actionQuit = KStandardAction::quit(qApp, &QApplication::quit, this);
actionQuit->setShortcut(QKeySequence::Quit);
rkflx: This works for me too and might be more modern Qt: QAction *actionQuit = KStandardAction…
194 194​
195void KSMainWindow::buildSaveMenu() 195​void KSMainWindow::buildSaveMenu()
196{ 196​{
197 // first clear the menu 197​ // first clear the menu
198 mSaveMenu->clear(); 198​ mSaveMenu->clear();
199 199​
rkflxUnsubmitted
Done

Now Ctrl+Q does not work anymore.

rkflx: Now {key Ctrl Q} does not work anymore.
200 // get our actions in order 200​ // get our actions in order
201 QAction *actionSave = KStandardAction::save(this, &KSMainWindow::save, this); 201​ QAction *actionSave = KStandardAction::save(this, &KSMainWindow::save, this);
202 QAction *actionSaveAs = KStandardAction::saveAs(this, &KSMainWindow::saveAs, this); 202​ QAction *actionSaveAs = KStandardAction::saveAs(this, &KSMainWindow::saveAs, this);
203 QAction *actionSaveExit = new QAction(QIcon::fromTheme(QStringLiteral("document-save")), i18n("Save &&& Exit"), this); ​
204 actionSaveExit->setToolTip(i18n("Save screenshot in your Pictures directory and exit")); ​
205 actionSaveExit->setShortcut(QKeySequence(QKeySequence::Quit)); ​
206 connect(actionSaveExit, &QAction::triggered, this, &KSMainWindow::saveAndExit); ​
207 203​
208 // static or dynamic 204​ // static or dynamic
209 SpectacleConfig *cfgManager = SpectacleConfig::instance(); 205​ SpectacleConfig *cfgManager = SpectacleConfig::instance();
210 int switchState = cfgManager->useDynamicSaveButton() ? cfgManager->lastUsedSaveMode() : 0; 206​ int switchState = cfgManager->useDynamicSaveButton() ? cfgManager->lastUsedSaveMode() : 0;
211 207​
212 // put the actions in order 208​ // put the actions in order
213 switch (switchState) { 209​ switch (switchState) {
214 case 0: 210​ case 0:
215 default: 211​ default:
216 mSaveButton->setDefaultAction(actionSaveAs); 212​ mSaveButton->setDefaultAction(actionSaveAs);
217 mSaveMenu->addAction(actionSaveExit); ​
218 mSaveMenu->addAction(actionSave); 213​ mSaveMenu->addAction(actionSave);
219 break; 214​ break;
220 case 1: 215​ case 1:
221 mSaveButton->setDefaultAction(actionSave); 216​ mSaveButton->setDefaultAction(actionSave);
222 mSaveMenu->addAction(actionSaveExit); ​
223 mSaveMenu->addAction(actionSaveAs); ​
224 break; ​
225 case 2: ​
226 mSaveButton->setDefaultAction(actionSaveExit); ​
227 mSaveMenu->addAction(actionSave); ​
228 mSaveMenu->addAction(actionSaveAs); 217​ mSaveMenu->addAction(actionSaveAs);
229 break; 218​ break;
230 } 219​ }
231} 220​}
232 221​
233// overrides 222​// overrides
234 223​
235void KSMainWindow::moveEvent(QMoveEvent *event) 224​void KSMainWindow::moveEvent(QMoveEvent *event)
Show All 29 Lines
265void KSMainWindow::showPrintDialog() 254​void KSMainWindow::showPrintDialog()
266{ 255​{
267 QPrinter *printer = new QPrinter(QPrinter::HighResolution); 256​ QPrinter *printer = new QPrinter(QPrinter::HighResolution);
268 QPrintDialog printDialog(printer, this); 257​ QPrintDialog printDialog(printer, this);
269 if (printDialog.exec() == QDialog::Accepted) { 258​ if (printDialog.exec() == QDialog::Accepted) {
270 ExportManager::instance()->doPrint(printer); 259​ ExportManager::instance()->doPrint(printer);
271 return; 260​ return;
272 } 261​ }
273 delete printer; 262​ delete printer;
274} 263​}
275 264​
rkflxUnsubmitted
Done

That's wrong: This way Print does not quit when accepting, but when cancelling (IMO it should never quit, so perhaps edit the test plan and remove this code).

rkflx: That's wrong: This way {nav Print} does not quit when accepting, but when cancelling (IMO it…
276void KSMainWindow::showImageSharedFeedback(bool error, const QString &message) 265​void KSMainWindow::showImageSharedFeedback(bool error, const QString &message)
277{ 266​{
278 if (error) { 267​ if (error) {
279 mMessageWidget->setMessageType(KMessageWidget::Error); 268​ mMessageWidget->setMessageType(KMessageWidget::Error);
280 mMessageWidget->setText(i18n("There was a problem sharing the image: %1", message)); 269​ mMessageWidget->setText(i18n("There was a problem sharing the image: %1", message));
281 mMessageWidget->setIcon(QIcon::fromTheme(QStringLiteral("dialog-error"))); 270​ mMessageWidget->setIcon(QIcon::fromTheme(QStringLiteral("dialog-error")));
282 } else { 271​ } else {
rkflxUnsubmitted
Done

Personally, I wouldn't quit here either. Did not test this part, but at least I'd expect some form of feedback about success or error.

rkflx: Personally, I wouldn't quit here either. Did not test this part, but at least I'd expect some…
283 mMessageWidget->setMessageType(KMessageWidget::Positive); 272​ mMessageWidget->setMessageType(KMessageWidget::Positive);
284 if (message.isEmpty()) 273​ if (message.isEmpty())
285 mMessageWidget->setText(i18n("Image shared")); 274​ mMessageWidget->setText(i18n("Image shared"));
286 else 275​ else
287 mMessageWidget->setText(i18n("You can find the shared image at: <a href=\"%1\">%1</a>", message)); 276​ mMessageWidget->setText(i18n("You can find the shared image at: <a href=\"%1\">%1</a>", message));
288 mMessageWidget->setIcon(QIcon::fromTheme(QStringLiteral("dialog-ok-apply"))); 277​ mMessageWidget->setIcon(QIcon::fromTheme(QStringLiteral("dialog-ok-apply")));
289 } 278​ }
290 279​
291 mMessageWidget->animatedShow(); 280​ mMessageWidget->animatedShow();
292 QTimer::singleShot(20000, mMessageWidget, &KMessageWidget::animatedHide); 281​ QTimer::singleShot(20000, mMessageWidget, &KMessageWidget::animatedHide);
293} 282​}
294 283​
295void KSMainWindow::sendToClipboard() 284​void KSMainWindow::sendToClipboard()
296{ 285​{
297 ExportManager::instance()->doCopyToClipboard(); 286​ ExportManager::instance()->doCopyToClipboard();
298 287​
288​ if (SpectacleConfig::instance()->quitAfterSaveOrCopyChecked()) {
289​ QApplication::quit();
290​ }
291​
rkflxUnsubmitted
Done

Modernize like you've done before…

rkflx: Modernize like you've done before…
299 mMessageWidget->setMessageType(KMessageWidget::Information); 292​ mMessageWidget->setMessageType(KMessageWidget::Information);
300 mMessageWidget->setText(i18n("The screenshot has been copied to the clipboard.")); 293​ mMessageWidget->setText(i18n("The screenshot has been copied to the clipboard."));
301 mMessageWidget->setIcon(QIcon::fromTheme(QStringLiteral("dialog-information"))); 294​ mMessageWidget->setIcon(QIcon::fromTheme(QStringLiteral("dialog-information")));
302 295​
303 mMessageWidget->animatedShow(); 296​ mMessageWidget->animatedShow();
304 QTimer::singleShot(10000, mMessageWidget, &KMessageWidget::animatedHide); 297​ QTimer::singleShot(10000, mMessageWidget, &KMessageWidget::animatedHide);
rkflxUnsubmitted
Done

Is pasting a screenshot after Copy To Clipboard → Quit actually working? For me it isn't, regardless of the state of the checkbox. Can you confirm?

rkflx: Is pasting a screenshot after {nav Copy To Clipboard > Quit} actually working? For me it isn't…
ngrahamAuthorUnsubmitted
Done

Oh right, this doesn't work yet on X11 because the image can't be saved to the standard X11 clipboard. See D9117 for more information. The patch author there might be able to get it working with a bit of technical assistance (a bit beyond my level, I'm afraid).

ngraham: Oh right, this doesn't work yet on X11 because the image can't be saved to the standard X11…
rkflxUnsubmitted
Done

I could get it to work for manually copying and quitting by unchecking "Ignore images" in Klipper's settings (it's checked by default, but why?). Still, for auto-quit I'm still unable to paste afterwards and the image does not appear in Klipper.

It might be a problem in your code, if it works on X11 in other cases.

rkflx: I could get it to work for manually copying and quitting by unchecking "Ignore images" in…
305} 298​}
306 299​
307void KSMainWindow::showPreferencesDialog() 300​void KSMainWindow::showPreferencesDialog()
308{ 301​{
309 SettingsDialog prefDialog(this); 302​ SettingsDialog prefDialog(this);
310 prefDialog.exec(); 303​ prefDialog.exec();
311} 304​}
312 305​
313void KSMainWindow::setScreenshotWindowTitle(QUrl location) 306​void KSMainWindow::setScreenshotWindowTitle(QUrl location)
314{ 307​{
315 setWindowTitle(location.fileName()); 308​ setWindowTitle(location.fileName());
316 setWindowModified(false); 309​ setWindowModified(false);
317} 310​}
318 311​
319void KSMainWindow::save() 312​void KSMainWindow::save()
320{ 313​{
321 SpectacleConfig::instance()->setLastUsedSaveMode(1); 314​ SpectacleConfig::instance()->setLastUsedSaveMode(1);
322 buildSaveMenu(); 315​ buildSaveMenu();
316​
317​ if (SpectacleConfig::instance()->quitAfterSaveOrCopyChecked()) {
318​ ExportManager::instance()->doSave(QUrl(), true);
319​ qApp->setQuitOnLastWindowClosed(false);
rkflxUnsubmitted
Done

//?

rkflx: `//`?
320​ hide();
321​ }
322​ else {
323 ExportManager::instance()->doSave(); 323​ ExportManager::instance()->doSave();
324} 324​ }
325​}
325 326​
rkflxUnsubmitted
Done

I see you copied this over, however do you know what this is for? Perhaps related to Bug 389694?

rkflx: I see you copied this over, however do you know what this is for? Perhaps related to [Bug…
ngrahamAuthorUnsubmitted
Done

This is to prevent Spectacle from quitting before the notification is displayed, I believe. I'm open to better ways of accomplishing the same thing, because I've noticed that bug, too.

ngraham: This is to prevent Spectacle from quitting before the notification is displayed, I believe. I'm…
rkflxUnsubmitted
Done

Okay, thanks for checking. I have no time to investigate this further currently.

Let's do it this way: Keep the calls everywhere they are needed, and we have the bug to track the issue (perhaps add a comment over there).

rkflx: Okay, thanks for checking. I have no time to investigate this further currently. Let's do it…
326void KSMainWindow::saveAs() 327​void KSMainWindow::saveAs()
327{ 328​{
328 SpectacleConfig::instance()->setLastUsedSaveMode(0); 329​ SpectacleConfig::instance()->setLastUsedSaveMode(0);
329 buildSaveMenu(); 330​ buildSaveMenu();
330 ExportManager::instance()->doSaveAs(this); ​
331} ​
332 331​
333void KSMainWindow::saveAndExit() 332​ if (SpectacleConfig::instance()->quitAfterSaveOrCopyChecked()) {
334{ 333​ ExportManager::instance()->doSaveAs(this, true);
rkflxUnsubmitted
Done

Somewhere there's a bug: Cancelling the Save As dialog quits, but it should only abort the dialog.

rkflx: Somewhere there's a bug: {nav Cancelling} the {nav Save As} dialog quits, but it should only…
335 SpectacleConfig::instance()->setLastUsedSaveMode(2); ​
336 qApp->setQuitOnLastWindowClosed(false); 334​ qApp->setQuitOnLastWindowClosed(false);
rkflxUnsubmitted
Done

Save As must be fixed

qApp->setQuitOnLastWindowClosed(false);
hide();
rkflx: > {nav Save As} must be fixed qApp->setQuitOnLastWindowClosed(false); hide();
rkflxUnsubmitted
Done

Ping (otherwise clicking on Open in the notfication is broken).

rkflx: Ping (otherwise clicking on {nav Open} in the notfication is broken).
337 ExportManager::instance()->doSave(QUrl(), true); ​
338 hide(); 335​ hide();
339} 336​ }
337​ else {
338​ ExportManager::instance()->doSaveAs(this, false);
339​ }
340​}