Changeset View
Changeset View
Standalone View
Standalone View
src/ioslaves/file/fdreceiver.h
Show All 34 Lines | 32 | public: | |||
---|---|---|---|---|---|
35 | 35 | | |||
36 | bool isListening() const; | 36 | bool isListening() const; | ||
37 | int fileDescriptor() const; | 37 | int fileDescriptor() const; | ||
38 | 38 | | |||
39 | private: | 39 | private: | ||
40 | Q_SLOT void receiveFileDescriptor(); | 40 | Q_SLOT void receiveFileDescriptor(); | ||
41 | 41 | | |||
42 | QSocketNotifier *m_readNotifier; | 42 | QSocketNotifier *m_readNotifier; | ||
43 | QString m_path; | ||||
43 | int m_socketDes; | 44 | int m_socketDes; | ||
44 | int m_fileDes; | 45 | int m_fileDes; | ||
45 | }; | 46 | }; | ||
46 | 47 | | |||
ossi: why are you moving the member?
it doesn't matter in this case, but generally it's better to… | |||||
47 | #endif | 48 | #endif |
why are you moving the member?
it doesn't matter in this case, but generally it's better to have the bigger members first, concentrating in particular on equal size (and sizeof(QString) == sizeof(void*)).
all other things being equal, prefer no change to reduce the diff size.