Differential D10085 Diff 26241 src/views/draganddrophelper.cpp

Changeset View

Standalone View

View Options

src/views/draganddrophelper.cpp

Context not available.
29#include <KIO/DropJob> 29​#include <KIO/DropJob>
30#include <KJobWidgets> 30​#include <KJobWidgets>
31 31​
32 ​
33bool DragAndDropHelper::urlListMatchesUrl(const QList<QUrl>& urls, const QUrl& destUrl) 32​bool DragAndDropHelper::urlListMatchesUrl(const QList<QUrl>& urls, const QUrl& destUrl)
34{ 33​{
35 return std::find_if(urls.constBegin(), urls.constEnd(), [destUrl](const QUrl& url) { 34​ const QUrl& adjustedDestUrl = destUrl.adjusted(QUrl::StripTrailingSlash);
36 return url.matches(destUrl, QUrl::StripTrailingSlash); 35​ return std::find_if(urls.constBegin(), urls.constEnd(), [adjustedDestUrl](const QUrl& url) {
36​ return adjustedDestUrl.matches(url, QUrl::StripTrailingSlash);
elvisangelaccioUnsubmitted
Done

Please use constFind()

elvisangelaccio: Please use `constFind()`
37 }) != urls.constEnd(); 37​ }) != urls.constEnd();
38} 38​}
39 39​
Context not available.
elvisangelaccioUnsubmitted
Done

Unrelated whitespace change

elvisangelaccio: Unrelated whitespace change
anthonyfieroniUnsubmitted
Done

Don't do that. It's ridiculous, it cannot guarantied that function will be called with same objects. It's enough speed-up with concurrent calls.

anthonyfieroni: Don't do that. It's ridiculous, it cannot guarantied that function will be called with same…