Differential D9907 Diff 25724 src/contentlist/CMakeLists.txt

Changeset View

Standalone View

View Options

src/contentlist/CMakeLists.txt

1set(qmlplugin_SRCS 1​set(qmlplugin_SRCS
2 qmlplugin.cpp 2​ qmlplugin.cpp
3 ContentList.cpp 3​ ContentList.cpp
4 ContentListerBase.cpp 4​ ContentListerBase.cpp
5 FilesystemContentLister.cpp 5​ FilesystemContentLister.cpp
6​ ContentQuery.cpp
6) 7​)
7 8​
8 9​
9if(KF5Baloo_FOUND) 10​if(KF5Baloo_FOUND)
10 set(qmlplugin_baloo_SRCS 11​ set(qmlplugin_baloo_SRCS
11 BalooContentLister.cpp 12​ BalooContentLister.cpp
12 ) 13​ )
13endif() 14​endif()
14 15​
15add_library (contentlistqmlplugin SHARED ${qmlplugin_SRCS} ${qmlplugin_baloo_SRCS}) 16​add_library (contentlistqmlplugin SHARED ${qmlplugin_SRCS} ${qmlplugin_baloo_SRCS})
16 17​
17target_link_libraries (contentlistqmlplugin 18​target_link_libraries (contentlistqmlplugin
19​ Qt5::Gui
leinirUnsubmitted
Not Done

Are you sure?

leinir: Are you sure?
ahiemstraAuthorUnsubmitted
Not Done

Qt5::Gui is needed for QImageReader::supportedFormats(), which is used in ContentQuery.cpp line 151. I could use a hardcoded list for images as well, but I was hoping to have a bit more flexible approach for mapping "query type" to mimetype.

I also originally assumed Qt5Qml was already linking to Qt5Gui but that seems to be false. :)

ahiemstra: Qt5::Gui is needed for QImageReader::supportedFormats(), which is used in ContentQuery.cpp line…
leinirUnsubmitted
Not Done

Right, i guess that's ok, yeah - certainly better than a random bit of hardcoding and such :)

leinir: Right, i guess that's ok, yeah - certainly better than a random bit of hardcoding and such :)
18 Qt5::Qml 20​ Qt5::Qml
19 KF5::FileMetaData 21​ KF5::FileMetaData
20) 22​)
21 23​
22if(KF5Baloo_FOUND) 24​if(KF5Baloo_FOUND)
23 target_compile_definitions(contentlistqmlplugin PRIVATE -DBALOO_FOUND="${KF5Baloo_FOUND}") 25​ target_compile_definitions(contentlistqmlplugin PRIVATE -DBALOO_FOUND="${KF5Baloo_FOUND}")
24 target_link_libraries(contentlistqmlplugin 26​ target_link_libraries(contentlistqmlplugin
25 KF5::Baloo 27​ KF5::Baloo
26 ) 28​ )
27endif() 29​endif()
28 30​
29install (TARGETS contentlistqmlplugin DESTINATION ${QML_INSTALL_DIR}/org/kde/contentlist) 31​install (TARGETS contentlistqmlplugin DESTINATION ${QML_INSTALL_DIR}/org/kde/contentlist)
30install (FILES qmldir DESTINATION ${QML_INSTALL_DIR}/org/kde/contentlist) 32​install (FILES qmldir DESTINATION ${QML_INSTALL_DIR}/org/kde/contentlist)