Differential D9414 Diff 25635 kded/qml/OsdSelector.qml

Changeset View

Standalone View

View Options

kded/qml/OsdSelector.qml

  • This file was added.
1​/*
2​ * Copyright 2017 Daniel Vrátil <dvratil@kde.org>
3​ *
4​ * This program is free software; you can redistribute it and/or
5​ * modify it under the terms of the GNU General Public License as
6​ * published by the Free Software Foundation; either version 2 of
7​ * the License, or (at your option) any later version.
8​ *
9​ * This program is distributed in the hope that it will be useful,
10​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
11​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12​ * GNU General Public License for more details.
13​ *
14​ * You should have received a copy of the GNU General Public License
15​ * along with this program. If not, see <http://www.gnu.org/licenses/>.
16​ */
17​
18​import QtQuick 2.5
19​import QtQuick.Window 2.2
20​
21​import org.kde.plasma.core 2.0 as PlasmaCore
22​import org.kde.plasma.components 2.0 as PlasmaComponents
23​import org.kde.plasma.extras 2.0 as PlasmaExtras
24​
25​import org.kde.KScreen 1.0
26​
27​Item {
28​ id: root
29​ property QtObject rootItem
30​
31​ signal clicked(int actionId)
32​
33​ height: Math.min(units.gridUnit * 15, Screen.desktopAvailableHeight / 5)
34​ width: buttonRow.width
35​
36​ PlasmaComponents.ButtonRow {
37​ id: buttonRow
38​
39​ exclusive: false
40​
41​ height: parent.height - label.height - ((units.smallSpacing/2) * 3)
42​ width: (actionRepeater.count * height) + ((actionRepeater.count - 1) * buttonRow.spacing);
43​
broulikUnsubmitted
Done

Repeater has a count property, avoids copying that JS Array over just to get its length

(also, urgh, I hoped ButtonRow was smarter than that)

broulik: `Repeater` has a `count` property, avoids copying that JS Array over just to get its length…
44​ Repeater {
45​ id: actionRepeater
46​ model: [
47​ {
48​ iconSource: "osd-shutd-laptop",
49​ label: i18n("Switch to external screen"),
50​ action: OsdAction.SwitchToExternal
sebasUnsubmitted
Done

i18n() instead of qsTr()

sebas: i18n() instead of qsTr()
51​ },
52​ {
53​ iconSource: "osd-shutd-screen",
54​ label: i18n("Switch to laptop screen"),
55​ action: OsdAction.SwitchToInternal
sebasUnsubmitted
Done

i18n() instead of qsTr()

sebas: i18n() instead of qsTr()
56​ },
57​ {
58​ iconSource: "osd-duplicate",
59​ label: i18n("Unify outputs"),
60​ action: OsdAction.Clonse
sebasUnsubmitted
Done

i18n() instead of qsTr(), perhaps clone or unify? (Unify is used elsewhere in the UI)

sebas: i18n() instead of qsTr(), perhaps clone or unify? (Unify is used elsewhere in the UI)
61​ },
62​ {
63​ iconSource: "osd-sbs-left",
64​ label: i18n("Extend to left"),
65​ action: OsdAction.ExtendLeft
sebasUnsubmitted
Done

i18n() instead of qsTr()

sebas: i18n() instead of qsTr()
66​ },
67​ {
68​ iconSource: "osd-sbs-sright",
69​ label: i18n("Extend to right"),
70​ action: OsdAction.ExtendRight
sebasUnsubmitted
Done

i18n() instead of qsTr()

sebas: i18n() instead of qsTr()
71​ },
72​ {
73​ iconSource: "dialog-cancel",
74​ label: i18n("Leave unchanged"),
75​ action: OsdAction.NoAction
sebasUnsubmitted
Done

Perhaps "Leave unchanged"?

sebas: Perhaps "Leave unchanged"?
76​ }
77​ ]
78​ delegate: PlasmaComponents.Button {
79​ PlasmaCore.IconItem {
80​ source: modelData.iconSource
broulikUnsubmitted
Not Done

Why do you need an IconItem inside? The Button can have an icon of its own

broulik: Why do you need an `IconItem` inside? The `Button` can have an icon of its own
dvratilAuthorUnsubmitted
Not Done

It's a workaround for Button's iconSource displaying the icon as 24x24 regardless of the size of the button, so we end up with massive button with a tiny icon.

dvratil: It's a workaround for Button's iconSource displaying the icon as 24x24 regardless of the size…
81​ height: buttonRow.height - ((units.smallSpacing / 2) * 3)
82​ width: height
83​ anchors.centerIn: parent
84​ }
85​ height: parent.height
86​ width: height
87​
88​ onHoveredChanged: rootItem.infoText = (hovered ? modelData.label : "")
89​
90​ onClicked: root.clicked(modelData.action)
91​ }
92​ }
93​ }
94​
95​ // TODO: keep? remove?
96​ PlasmaExtras.Heading {
97​ id: label
98​ anchors {
99​ bottom: parent.bottom
100​ left: parent.left
101​ right: parent.right
102​ margins: Math.floor(units.smallSpacing / 2)
103​ }
104​
105​ text: rootItem.infoText
106​ horizontalAlignment: Text.AlignHCenter
107​ wrapMode: Text.WordWrap
108​ maximumLineCount: 2
109​ elide: Text.ElideLeft
110​ minimumPointSize: theme.defaultFont.pointSize
111​ fontSizeMode: Text.HorizontalFit
112​ }
113​
114​ Component.onCompleted: print("OsdSelector loaded...");
115​}
116​