Differential D9827 Diff 25202 applets/taskmanager/package/contents/ui/Badge.qml

Changeset View

Standalone View

View Options

applets/taskmanager/package/contents/ui/Badge.qml

  • This file was added.
1​/***************************************************************************
2​ * Copyright (C) 2018 Kai Uwe Broulik <kde@privat.broulik.de> *
3​ * *
4​ * This program is free software; you can redistribute it and/or modify *
5​ * it under the terms of the GNU General Public License as published by *
6​ * the Free Software Foundation; either version 2 of the License, or *
7​ * (at your option) any later version. *
8​ * *
9​ * This program is distributed in the hope that it will be useful, *
10​ * but WITHOUT ANY WARRANTY; without even the implied warranty of *
11​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
12​ * GNU General Public License for more details. *
13​ * *
14​ * You should have received a copy of the GNU General Public License *
15​ * along with this program; if not, write to the *
16​ * Free Software Foundation, Inc., *
17​ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA . *
18​ ***************************************************************************/
19​
20​import QtQuick 2.4
21​
22​import org.kde.plasma.components 2.0 as PlasmaComponents
23​
24​Rectangle {
25​ id: badgeRect
26​
27​ property alias text: label.text
28​ property alias textColor: label.color
29​ property int number: 0
30​
31​ implicitWidth: Math.max(height, Math.round(label.contentWidth + radius / 2)) // Add some padding around.
32​ height: Math.round(parent.height * 0.4)
davidedmundsonUnsubmitted
Not Done

Components shouldn't specify their own height, nor should they assume stuff about their parents, it makes them non-portable.

I would get rid of this line. Maybe specify an implicitHeight of: label.implicitHeight.

Apperance will remain identical as you're overwriting the height on line 79 of TaskBadgeOverlay

davidedmundson: Components shouldn't specify their own height, nor should they assume stuff about their parents…
33​ color: theme.highlightColor
34​ radius: height / 2
35​
36​ PlasmaComponents.Label {
37​ id: label
38​ anchors.centerIn: parent
39​ width: height
40​ height: Math.round(parent.height)
41​ horizontalAlignment: Text.AlignHCenter
42​ verticalAlignment: Text.AlignVCenter
43​ fontSizeMode: Text.VerticalFit
44​ font.pointSize: 1024
45​ minimumPointSize: 5
46​ color: theme.backgroundColor
47​ text: badgeRect.number > 9999 ? i18nc("Over 9999 new messages, overlay, keep short", "9,999+")
48​ : Math.max(0, badgeRect.number).toLocaleString(Qt.locale(), 'f', 0)
davidedmundsonUnsubmitted
Not Done

Why 0 instead of a negative?

davidedmundson: Why 0 instead of a negative?
49​ }
50​}