Differential D9808 Diff 25163 autotests/klineedit_unittest.cpp

Changeset View

Standalone View

View Options

autotests/klineedit_unittest.cpp

Context not available.
68#endif 68​#endif
69 QCOMPARE(textChangedSpy.count(), 1); 69​ QCOMPARE(textChangedSpy.count(), 1);
70 QCOMPARE(textChangedSpy[0][0].toString(), w.text()); 70​ QCOMPARE(textChangedSpy[0][0].toString(), w.text());
71 QCOMPARE(textEditedSpy.count(), 1); 71​ QCOMPARE(textEditedSpy.count(), 0);
dfaureUnsubmitted
Not Done

LOL the comment above says "setText emits textChanged and userTextChanged, but not textEdited", and the code didn't match that. Someone quickly adapted the tests after someone else added the emit, none of them really thought about this, sigh.

dfaure: LOL the comment above says "setText emits textChanged and userTextChanged, but not textEdited"…
72 QVERIFY(!w.isModified()); 72​ QVERIFY(!w.isModified());
73#ifndef KCOMPLETION_NO_DEPRECATED 73​#ifndef KCOMPLETION_NO_DEPRECATED
74 userTextChangedSpy.clear(); 74​ userTextChangedSpy.clear();
Context not available.
76 textChangedSpy.clear(); 76​ textChangedSpy.clear();
77 textEditedSpy.clear(); 77​ textEditedSpy.clear();
78 78​
79​ // calling clear should emit textChanged and userTextChanged, but not textEdited
80​ w.clear();
81​ QCOMPARE(textChangedSpy.count(),1);
82​ QCOMPARE(textEditedSpy.count(),0);
83​#ifndef KCOMPLETION_NO_DEPRECATED
84​ QCOMPARE(userTextChangedSpy.count(),1);
85​#endif
86​
87​ //if text box is already empty, calling clear() shouldn't emit
mwolffUnsubmitted
Not Done

typo: if the text box is already clear*ed*

mwolff: typo: if the text box is already clear*ed*
dweatherillAuthorUnsubmitted
Not Done

ok, it's unclear, but not a typo.
According to QLineEdit documentation, clear() should only emit textChanged when there is actually text to clear.

So the word "cleared" kind of implies "only after we've called clear()" I guess I should change it to

//if text box is already empty, calling clear() shouldn't emit
dweatherill: ok, it's unclear, but not a typo. According to QLineEdit documentation, clear() should only…
dfaureUnsubmitted
Not Done

Agreed, that's clearer (haha).

dfaure: Agreed, that's clearer (haha).
88​ // any more signals
89​ w.clear();
90​ QCOMPARE(textChangedSpy.count(),1);
91​ QCOMPARE(textEditedSpy.count(),0);
92​#ifndef KCOMPLETION_NO_DEPRECATED
93​ QCOMPARE(userTextChangedSpy.count(),1);
94​#endif
95​
96​
97​ //set the text back for further tests below
98​ w.setText("Hello worl");
99​#ifndef KCOMPLETION_NO_DEPRECATED
100​ userTextChangedSpy.clear();
101​#endif
102​ textChangedSpy.clear();
103​ textEditedSpy.clear();
104​
79 // typing emits all three signals 105​ // typing emits all three signals
80 QTest::keyClick(&w, Qt::Key_D); 106​ QTest::keyClick(&w, Qt::Key_D);
81 QCOMPARE(w.text(), QString::fromLatin1("Hello world")); 107​ QCOMPARE(w.text(), QString::fromLatin1("Hello world"));
Context not available.
85#endif 111​#endif
86 QCOMPARE(textChangedSpy.count(), 1); 112​ QCOMPARE(textChangedSpy.count(), 1);
87 QCOMPARE(textChangedSpy[0][0].toString(), w.text()); 113​ QCOMPARE(textChangedSpy[0][0].toString(), w.text());
88 QCOMPARE(textEditedSpy.count(), 2); 114​ QCOMPARE(textEditedSpy.count(), 1);
89 QCOMPARE(textEditedSpy[0][0].toString(), w.text()); 115​ QCOMPARE(textEditedSpy[0][0].toString(), w.text());
90 QVERIFY(w.isModified()); 116​ QVERIFY(w.isModified());
91 117​
Context not available.
169 QCOMPARE(userTextChangedSpy.count(), 2); 195​ QCOMPARE(userTextChangedSpy.count(), 2);
170#endif 196​#endif
171 QCOMPARE(textChangedSpy.count(), 2); 197​ QCOMPARE(textChangedSpy.count(), 2);
172 QCOMPARE(textEditedSpy.count(), 2); 198​ QCOMPARE(textEditedSpy.count(), 0);
173#ifndef KCOMPLETION_NO_DEPRECATED 199​#ifndef KCOMPLETION_NO_DEPRECATED
174 userTextChangedSpy.clear(); 200​ userTextChangedSpy.clear();
175#endif 201​#endif
Context not available.