Differential D9294 Diff 23867 kwin-5.11.3/decorations/decoratedclient.cpp

Changeset View

Standalone View

Context not available.
200	return QColor();	200		return QColor();
201	}	201		}
202		202
		203		void DecoratedClientImpl::requestShowToolTip(QString &text)
			broulikUnsubmitted Done I would prefer to have two dedicated methods to avoid a boolean trap. `requestTooltip(false)` is hardly descriptive without knowing the code. Perhaps `requestShowToolTip(const QString &text)` and `requestHideToolTip()` Shouldn't it be ToolTip (capital Tip)? Also pass argument as `const QString &` broulik: I would prefer to have two dedicated methods to avoid a boolean trap. `requestTooltip(false)`…
		204		{
		205		Workspace::self()->showToolTip(text);
		206		}
		207
		208		void DecoratedClientImpl::requestHideToolTip()
		209		{
		210		Workspace::self()->hideToolTip();
		211		}
		212
203	void DecoratedClientImpl::requestShowWindowMenu()	213		void DecoratedClientImpl::requestShowWindowMenu()
204	{	214		{
205	// TODO: add rect to requestShowWindowMenu	215		// TODO: add rect to requestShowWindowMenu
Context not available.