Differential D7246 Diff 23866 kdecoration-5.11.3/src/private/decoratedclientprivate.h

Changeset View

Standalone View

View Options

kdecoration-5.11.3/src/private/decoratedclientprivate.h

Context not available.
76 virtual QPalette palette() const = 0; 76​ virtual QPalette palette() const = 0;
77 virtual Qt::Edges adjacentScreenEdges() const = 0; 77​ virtual Qt::Edges adjacentScreenEdges() const = 0;
78 78​
79​ virtual void requestShowToolTip(QString &text) = 0;
80​ virtual void requestHideToolTip() = 0;
graesslinUnsubmitted
Done

If we add pure virtuals we need to increase the so version of the private libraru.

graesslin: If we add pure virtuals we need to increase the so version of the private libraru.
McPainAuthorUnsubmitted
Done

I need to avoid sover increasing, right?

McPain: I need to avoid sover increasing, right?
graesslinUnsubmitted
Done

No, increasing the soversion of the private library is fine. It's only used by KWin and by KDecoration public library. The interface to the decoration plugins (like breeze) is still stable. As KDecoration and KWin are released together it's not a problem. But we should try to get it in before the beta release as distros might need to adjust packaging.

graesslin: No, increasing the soversion of the private library is fine. It's only used by KWin and by…
79 virtual void requestClose() = 0; 81​ virtual void requestClose() = 0;
80 virtual void requestToggleMaximization(Qt::MouseButtons buttons) = 0; 82​ virtual void requestToggleMaximization(Qt::MouseButtons buttons) = 0;
81 virtual void requestMinimize() = 0; 83​ virtual void requestMinimize() = 0;
Context not available.