Differential D9145 Diff 23752 app/semanticinfosidebaritem.ui

Changeset View

Standalone View

View Options

app/semanticinfosidebaritem.ui

Context not available.
16 <property name="fieldGrowthPolicy"> 16​ <property name="fieldGrowthPolicy">
17 <enum>QFormLayout::ExpandingFieldsGrow</enum> 17​ <enum>QFormLayout::ExpandingFieldsGrow</enum>
18 </property> 18​ </property>
19​ <property name="leftMargin">
20​ <number>3</number>
rkflxUnsubmitted
Not Done

In SemanticInfoContextManagerItemPrivate::setupGroup, add

formLayout->setContentsMargins(DEFAULT_LAYOUT_MARGIN, 0, 0, 0);

so you don't have to duplicate the magic number in the .ui file. Move DEFAULT_LAYOUT_MARGIN to sidebar.h for this.

rkflx: In `SemanticInfoContextManagerItemPrivate::setupGroup`, add ``` formLayout->setContentsMargins…
21​ </property>
19 <item row="0" column="0"> 22​ <item row="0" column="0">
20 <widget class="QLabel" name="label"> 23​ <widget class="QLabel" name="label">
21 <property name="text"> 24​ <property name="text">
Context not available.
34 <verstretch>0</verstretch> 37​ <verstretch>0</verstretch>
35 </sizepolicy> 38​ </sizepolicy>
36 </property> 39​ </property>
37 <property name="alignment"> ​
38 <set>Qt::AlignLeading|Qt::AlignLeft|Qt::AlignVCenter</set> ​
rkflxUnsubmitted
Not Done

Removing this breaks the alignment of the rating widget.

rkflx: Removing this breaks the alignment of the rating widget.
39 </property> ​
40 </widget> 40​ </widget>
41 </item> 41​ </item>
42 <item row="1" column="0"> 42​ <item row="1" column="0">
Context not available.
84 <class>KRatingWidget</class> 84​ <class>KRatingWidget</class>
85 <extends>QFrame</extends> 85​ <extends>QFrame</extends>
86 <header>kratingwidget.h</header> 86​ <header>kratingwidget.h</header>
87​ <container>1</container>
rkflxUnsubmitted
Not Done

Why do you need to add that?

rkflx: Why do you need to add that?
87 </customwidget> 88​ </customwidget>
88 </customwidgets> 89​ </customwidgets>
89 <resources/> 90​ <resources/>
Context not available.