Differential D9106 Diff 23271 kmymoney/mymoney/storage/tests/mymoneydatabasemgr-test.cpp

Changeset View

Standalone View

View Options

kmymoney/mymoney/storage/tests/mymoneydatabasemgr-test.cpp

Context not available.
28#include "mymoneytag.h" 28​#include "mymoneytag.h"
29#include "mymoneypayee.h" 29​#include "mymoneypayee.h"
30#include "mymoneyschedule.h" 30​#include "mymoneyschedule.h"
31​#include "mymoneyschedule_p.h"
31#include "mymoneyreport.h" 32​#include "mymoneyreport.h"
32#include "mymoneysplit.h" 33​#include "mymoneysplit.h"
34​#include "mymoneysplit_p.h"
33#include "mymoneytransaction.h" 35​#include "mymoneytransaction.h"
34#include "mymoneybudget.h" 36​#include "mymoneybudget.h"
35 37​
Context not available.
668 QVERIFY(s.id().isEmpty()); 670​ QVERIFY(s.id().isEmpty());
669 t1.addSplit(s); 671​ t1.addSplit(s);
670 672​
671 s.setId(QString()); // enable re-usage of split variable 673​ s.d_func()->setId(QString()); // enable re-usage of split variable
tbaumgartUnsubmitted
Done

Better use

s.d_func()->clearId();

here

tbaumgart: Better use s.d_func()->clearId(); here
672 s.setAccountId("A000005"); // Salary 674​ s.setAccountId("A000005"); // Salary
673 s.setShares(MyMoneyMoney(-100000, 100)); 675​ s.setShares(MyMoneyMoney(-100000, 100));
674 s.setValue(MyMoneyMoney(-100000, 100)); 676​ s.setValue(MyMoneyMoney(-100000, 100));
Context not available.
696 698​
697 try { 699​ try {
698 // I spent some money, not so great 700​ // I spent some money, not so great
699 s.setId(QString()); // enable re-usage of split variable 701​ s.d_func()->setId(QString()); // enable re-usage of split variable
700 s.setAccountId("A000004"); // Grosseries 702​ s.setAccountId("A000004"); // Grosseries
701 s.setShares(MyMoneyMoney(10000, 100)); 703​ s.setShares(MyMoneyMoney(10000, 100));
702 s.setValue(MyMoneyMoney(10000, 100)); 704​ s.setValue(MyMoneyMoney(10000, 100));
703 QVERIFY(s.id().isEmpty()); 705​ QVERIFY(s.id().isEmpty());
704 t2.addSplit(s); 706​ t2.addSplit(s);
705 707​
706 s.setId(QString()); // enable re-usage of split variable 708​ s.d_func()->setId(QString()); // enable re-usage of split variable
707 s.setAccountId("A000002"); // 16% sales tax 709​ s.setAccountId("A000002"); // 16% sales tax
708 s.setShares(MyMoneyMoney(1200, 100)); 710​ s.setShares(MyMoneyMoney(1200, 100));
709 s.setValue(MyMoneyMoney(1200, 100)); 711​ s.setValue(MyMoneyMoney(1200, 100));
710 QVERIFY(s.id().isEmpty()); 712​ QVERIFY(s.id().isEmpty());
711 t2.addSplit(s); 713​ t2.addSplit(s);
712 714​
713 s.setId(QString()); // enable re-usage of split variable 715​ s.d_func()->setId(QString()); // enable re-usage of split variable
714 s.setAccountId("A000003"); // 7% sales tax 716​ s.setAccountId("A000003"); // 7% sales tax
715 s.setShares(MyMoneyMoney(400, 100)); 717​ s.setShares(MyMoneyMoney(400, 100));
716 s.setValue(MyMoneyMoney(400, 100)); 718​ s.setValue(MyMoneyMoney(400, 100));
717 QVERIFY(s.id().isEmpty()); 719​ QVERIFY(s.id().isEmpty());
718 t2.addSplit(s); 720​ t2.addSplit(s);
719 721​
720 s.setId(QString()); // enable re-usage of split variable 722​ s.d_func()->setId(QString()); // enable re-usage of split variable
721 s.setAccountId("A000006"); // Checkings account 723​ s.setAccountId("A000006"); // Checkings account
722 s.setShares(MyMoneyMoney(-11600, 100)); 724​ s.setShares(MyMoneyMoney(-11600, 100));
723 s.setValue(MyMoneyMoney(-11600, 100)); 725​ s.setValue(MyMoneyMoney(-11600, 100));
Context not available.
904 QVERIFY(s.id().isEmpty()); 906​ QVERIFY(s.id().isEmpty());
905 t1.addSplit(s); 907​ t1.addSplit(s);
906 908​
907 s.setId(QString()); // enable re-usage of split variable 909​ s.d_func()->setId(QString()); // enable re-usage of split variable
908 s.setAccountId("A000002"); 910​ s.setAccountId("A000002");
909 s.setShares(MyMoneyMoney(400, 100)); 911​ s.setShares(MyMoneyMoney(400, 100));
910 s.setValue(MyMoneyMoney(400, 100)); 912​ s.setValue(MyMoneyMoney(400, 100));
Context not available.
1021 // Create another transaction 1023​ // Create another transaction
1022 MyMoneyTransaction t1; 1024​ MyMoneyTransaction t1;
1023 try { 1025​ try {
1024 s.setId(QString()); // enable re-usage of split variable 1026​ s.d_func()->setId(QString()); // enable re-usage of split variable
1025 s.setAccountId("A000006"); // Checkings 1027​ s.setAccountId("A000006"); // Checkings
1026 s.setShares(MyMoneyMoney(10000, 100)); 1028​ s.setShares(MyMoneyMoney(10000, 100));
1027 s.setValue(MyMoneyMoney(10000, 100)); 1029​ s.setValue(MyMoneyMoney(10000, 100));
1028 QVERIFY(s.id().isEmpty()); 1030​ QVERIFY(s.id().isEmpty());
1029 t1.addSplit(s); 1031​ t1.addSplit(s);
1030 1032​
1031 s.setId(QString()); // enable re-usage of split variable 1033​ s.d_func()->setId(QString()); // enable re-usage of split variable
1032 s.setAccountId("A000005"); // Salary 1034​ s.setAccountId("A000005"); // Salary
1033 s.setShares(MyMoneyMoney(-10000, 100)); 1035​ s.setShares(MyMoneyMoney(-10000, 100));
1034 s.setValue(MyMoneyMoney(-10000, 100)); 1036​ s.setValue(MyMoneyMoney(-10000, 100));
Context not available.
1856 MyMoneySchedule sched; 1858​ MyMoneySchedule sched;
1857 1859​
1858 sched = m->schedule("SCH000001"); 1860​ sched = m->schedule("SCH000001");
1859 sched.setId("SCH000002"); 1861​ sched.d_func()->setId("SCH000002");
1860 try { 1862​ try {
1861 m->modifySchedule(sched); 1863​ m->modifySchedule(sched);
1862 QFAIL("Exception expected"); 1864​ QFAIL("Exception expected");
Context not available.
1888 MyMoneySchedule sched; 1890​ MyMoneySchedule sched;
1889 1891​
1890 sched = m->schedule("SCH000001"); 1892​ sched = m->schedule("SCH000001");
1891 sched.setId("SCH000002"); 1893​ sched.d_func()->setId("SCH000002");
1892 try { 1894​ try {
1893 m->removeSchedule(sched); 1895​ m->removeSchedule(sched);
1894 QFAIL("Exception expected"); 1896​ QFAIL("Exception expected");
Context not available.