Differential D8641 Diff 22462 src/controls/FormLayout.qml

Changeset View

Standalone View

View Options

src/controls/FormLayout.qml

  • This file was added.
1​/*
2​ * Copyright 2017 Marco Martin <mart@kde.org>
3​ *
4​ * This program is free software; you can redistribute it and/or modify
5​ * it under the terms of the GNU Library General Public License as
6​ * published by the Free Software Foundation; either version 2 or
7​ * (at your option) any later version.
8​ *
9​ * This program is distributed in the hope that it will be useful,
davidedmundsonUnsubmitted
Not Done

Why do we inherit from Control?

davidedmundson: Why do we inherit from Control?
martAuthorUnsubmitted
Not Done

I tend to have them controls by default as they have the padding properties that can be very convenient sometimes (as well, if one needs to put a background on the back of it for whatever reason)

mart: I tend to have them controls by default as they have the padding properties that can be very…
10​ * but WITHOUT ANY WARRANTY; without even the implied warranty of
11​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12​ * GNU Library General Public License for more details
13​ *
14​ * You should have received a copy of the GNU Library General Public
15​ * License along with this program; if not, write to the
16​ * Free Software Foundation, Inc.,
17​ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18​ */
19​
20​import QtQuick 2.6
21​import org.kde.kirigami 2.3 as Kirigami
davidedmundsonUnsubmitted
Done

this can be taller than the parent item.

davidedmundson: this can be taller than the parent item.
22​
23​import "templates" as T
24​
25​T.FormLayout {
26​
27​}
davidedmundsonUnsubmitted
Done

If you're doing a hack round something, document what.

davidedmundson: If you're doing a hack round something, document what.
davidedmundsonUnsubmitted
Done

We have an entire KCM with fonts where you can customise everything.

Then we ignore it and hardcode a bunch of them. The end result is we have complexity and don't even use it.

davidedmundson: We have an entire KCM with fonts where you can customise everything. Then we ignore it and…
davidedmundsonUnsubmitted
Done

so this is skipping items that are already in here?

davidedmundson: so this is skipping items that are already in here?
davidedmundsonUnsubmitted
Done

merge

davidedmundson: merge
davidedmundsonUnsubmitted
Done

what about when an item gets deleted?

davidedmundson: what about when an item gets deleted?