Differential D8641 Diff 22401 src/mnemonicattached.cpp

Changeset View

Standalone View

View Options

src/mnemonicattached.cpp

  • This file was added.
1​/*
2​* Copyright (C) 2017 by Marco Martin <mart@kde.org>
3​*
4​* This program is free software; you can redistribute it and/or modify
5​* it under the terms of the GNU Library General Public License as
6​* published by the Free Software Foundation; either version 2, or
7​* (at your option) any later version.
8​*
9​* This program is distributed in the hope that it will be useful,
10​* but WITHOUT ANY WARRANTY; without even the implied warranty of
11​* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12​* GNU Library General Public License for more details
13​*
14​* You should have received a copy of the GNU Library General Public
15​* License along with this program; if not, write to the
16​* Free Software Foundation, Inc.,
17​* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18​*/
19​
20​#include "mnemonicattached.h"
21​#include <QQuickItem>
22​#include <QQuickWindow>
23​#include <QDebug>
24​
25​QHash<QKeySequence, MnemonicAttached *> MnemonicAttached::s_sequenceToObject = QHash<QKeySequence, MnemonicAttached *>();
26​QHash<MnemonicAttached *, QKeySequence> MnemonicAttached::s_objectToSequence = QHash<MnemonicAttached *, QKeySequence>();
27​
28​MnemonicAttached::MnemonicAttached(QObject *parent)
29​ : QObject(parent)
30​{
31​ QQuickItem *parentItem = qobject_cast<QQuickItem *>(parent);
davidedmundsonUnsubmitted
Done

we can filter the window, instead of the app.

It's massively faster; qapp gets a lot of stuff.

davidedmundson: we can filter the window, instead of the app. It's massively faster; qapp gets a lot of stuff.
32​ if (parentItem) {
33​ if (parentItem->window()) {
34​ m_window = parentItem->window();
35​ m_window->installEventFilter(this);
36​ }
37​ connect(parentItem, &QQuickItem::windowChanged, this,
38​ [this](QQuickWindow *window) {
39​ if (m_window) {
40​ m_window->removeEventFilter(this);
41​ }
42​ m_window = window;
43​ if (m_window) {
44​ m_window->installEventFilter(this);
45​ }
46​ });
47​ }
48​}
49​
50​MnemonicAttached::~MnemonicAttached()
davidedmundsonUnsubmitted
Done

Note that the alt to show is a Breeze special feature for widgets.

davidedmundson: Note that the alt to show is a Breeze special feature for widgets.
martAuthorUnsubmitted
Done

i think it's fine assuming the style supports that... (and assume that the one which is really supported is breeze) i wouldn't know how to detect it from here?

mart: i think it's fine assuming the style supports that... (and assume that the one which is really…
51​{
52​ if (s_objectToSequence.contains(this)) {
53​ s_sequenceToObject.remove(s_objectToSequence.value(this));
broulikUnsubmitted
Done

Double lookup (contains+value), also below

broulik: Double lookup (contains+value), also below
54​ s_objectToSequence.remove(this);
55​ }
56​}
57​
58​bool MnemonicAttached::eventFilter(QObject *watched, QEvent *e)
59​{
60​ Q_UNUSED(watched)
61​
62​ if (m_richTextLabel.length() == 0) {
63​ return false;
broulikUnsubmitted
Done

isEmpty

broulik: `isEmpty`
64​ }
65​
66​ if (e->type() == QEvent::KeyPress) {
67​ QKeyEvent *ke = static_cast<QKeyEvent *>(e);
68​ if (ke->key() == Qt::Key_Alt) {
69​ m_actualRichTextLabel = m_richTextLabel;
70​ emit richTextLabelChanged();
71​ }
72​
73​ } else if (e->type() == QEvent::KeyRelease) {
74​ QKeyEvent *ke = static_cast<QKeyEvent *>(e);
75​ if (ke->key() == Qt::Key_Alt) {
76​ m_actualRichTextLabel = m_label;
77​ m_actualRichTextLabel.replace("&", QString());
78​ emit richTextLabelChanged();
79​ }
80​ }
81​ return false;
82​}
83​
84​//Algorythm adapted from KAccelString
85​void MnemonicAttached::calculateWeights()
86​{
87​ m_weights.clear();
88​
89​ int pos = 0;
90​ bool start_character = true;
91​ bool wanted_character = false;
92​
93​ while (pos < m_label.length()) {
94​ QChar c = m_label[pos];
95​
96​ // skip non typeable characters
97​ if (!c.isLetterOrNumber()) {
98​ start_character = true;
99​ ++pos;
100​ continue;
101​ }
102​
103​ int weight = 1;
104​
105​ // add special weight to first character
106​ if (pos == 0) {
107​ weight += FIRST_CHARACTER_EXTRA_WEIGHT;
108​ }
109​
110​ // add weight to word beginnings
111​ if (start_character) {
112​ weight += WORD_BEGINNING_EXTRA_WEIGHT;
113​ start_character = false;
114​ }
115​
116​ // add weight to word beginnings
117​ if (wanted_character) {
118​ weight += WANTED_ACCEL_EXTRA_WEIGHT;
119​ wanted_character = false;
120​ }
121​
122​ // add decreasing weight to left characters
123​ if (pos < 50) {
124​ weight += (50 - pos);
125​ }
126​
127​ // try to preserve the wanted accelarators
128​ if (c == "&") {
129​ wanted_character = true;
130​ ++pos;
131​ continue;
132​ }
133​
134​ while (m_weights.contains(weight)) {
135​ ++weight;
136​ }
137​
138​ m_weights[weight] = c;
139​
140​ ++pos;
141​ }
142​
143​ //update our maximum weight
144​ if (m_weights.isEmpty()) {
145​ m_weight = m_baseWeight;
146​ } else {
147​ m_weight = m_baseWeight + m_weights.keys().last();
148​ }
149​}
150​
151​void MnemonicAttached::updateSequence()
152​{
153​ //forget about old association
154​ if (s_objectToSequence.contains(this)) {
155​ s_sequenceToObject.remove(s_objectToSequence.value(this));
156​ s_objectToSequence.remove(this);
157​ }
158​
159​ calculateWeights();
160​
161​ const QString text = label();
162​
163​ if (!m_enabled) {
164​ m_actualRichTextLabel = text;
165​ m_actualRichTextLabel.replace("&", QString());
166​ m_mnemonicLabel = m_actualRichTextLabel;
167​ emit mnemonicLabelChanged();
168​ emit richTextLabelChanged();
broulikUnsubmitted
Done

Can we emit this stuff only if actually changed or can this be assumed here?

broulik: Can we emit this stuff only if actually changed or can this be assumed here?
169​ return;
170​ }
171​
172​ if (m_weights.isEmpty()) {
173​ return;
174​ }
175​
176​ QMap<int, QChar>::const_iterator i = m_weights.constEnd();
177​ do {
178​ --i;
179​ QChar c = i.value();
180​ QKeySequence ks("Alt+"%c);
181​ MnemonicAttached *otherMa = s_sequenceToObject.value(ks);
182​ Q_ASSERT(otherMa != this);
183​ if (!otherMa || otherMa->m_weight < m_weight) {
184​ //the old shortcut is less valuable than the current: remove it
185​ if (otherMa) {
186​ s_sequenceToObject.remove(otherMa->sequence());
187​ s_objectToSequence.remove(otherMa);
188​ }
189​
190​ s_sequenceToObject[ks] = this;
191​ s_objectToSequence[this] = ks;
192​ m_richTextLabel = text;
193​ m_richTextLabel.replace("&", QString());
194​ m_actualRichTextLabel = m_richTextLabel;
195​ m_mnemonicLabel = m_richTextLabel;
196​ m_mnemonicLabel.replace(c, "&" % c);
197​ m_richTextLabel.replace(QString(c), "<u>" % c % "</u>");
198​
199​ //remap the sequence of the previous shortcut
200​ if (otherMa) {
201​ otherMa->updateSequence();
202​ }
203​
204​ break;
205​ }
206​ } while (i != m_weights.constBegin());
207​
208​ if (s_objectToSequence.contains(this)) {
209​ emit sequenceChanged();
210​ }
211​
212​ emit richTextLabelChanged();
213​ emit mnemonicLabelChanged();
214​}
215​
216​void MnemonicAttached::setLabel(const QString &text)
217​{
218​ if (m_label == text) {
219​ return;
220​ }
221​
222​ m_label = text;
223​ updateSequence();
224​ emit labelChanged();
225​}
226​
227​QString MnemonicAttached::richTextLabel() const
228​{
229​ return m_actualRichTextLabel.length() > 0 ? m_actualRichTextLabel : m_label;
230​}
broulikUnsubmitted
Done

`!isEmpty?

broulik: `!isEmpty?
231​
232​QString MnemonicAttached::mnemonicLabel() const
233​{
234​ return m_mnemonicLabel;
235​}
236​
237​QString MnemonicAttached::label() const
238​{
239​ return m_label;
240​}
241​
242​void MnemonicAttached::setEnabled(bool enabled)
243​{
244​ if (m_enabled == enabled) {
245​ return;
246​ }
247​
248​ m_enabled = enabled;
249​ updateSequence();
250​ emit enabledChanged();
251​}
252​
253​bool MnemonicAttached::enabled() const
254​{
255​ return m_enabled;
256​}
257​
258​void MnemonicAttached::setControlType(MnemonicAttached::ControlType controlType)
259​{
260​ if (m_controlType == controlType) {
261​ return;
262​ }
263​
264​ m_controlType = controlType;
265​
266​ switch (controlType) {
267​ case ActionElement:
268​ m_baseWeight = ACTION_ELEMENT_WEIGHT;
269​ break;
270​ case DialogButton:
271​ m_baseWeight = DIALOG_BUTTON_EXTRA_WEIGHT;
272​ break;
273​ case MenuItem:
274​ m_baseWeight = MENU_ITEM_WEIGHT;
275​ break;
276​ case FormLabel:
277​ m_baseWeight = FORM_LABEL_WEIGHT;
278​ break;
279​ default:
280​ m_baseWeight = SECONDARY_CONTROL_WEIGHT;
281​ break;
282​ }
283​ //update our maximum weight
284​ if (m_weights.isEmpty()) {
285​ m_weight = m_baseWeight;
286​ } else {
287​ m_weight = m_baseWeight + m_weights.keys().last();
288​ }
broulikUnsubmitted
Done

(m_weights.constEnd() - 1).key()? Avoids creating a keys() temporary list

broulik: `(m_weights.constEnd() - 1).key()`? Avoids creating a `keys()` temporary list
289​ emit controlTypeChanged();
290​}
291​
292​MnemonicAttached::ControlType MnemonicAttached::controlType() const
293​{
294​ return m_controlType;
295​}
296​
297​QKeySequence MnemonicAttached::sequence()
298​{
299​ return s_objectToSequence.value(this);
300​}
301​
302​MnemonicAttached *MnemonicAttached::qmlAttachedProperties(QObject *object)
303​{
304​ return new MnemonicAttached(object);
305​}
306​
307​#include "moc_mnemonicattached.cpp"