Differential D8641 Diff 22324 src/formlayoutattached.h

Changeset View

Standalone View

View Options

src/formlayoutattached.h

  • This file was added.
1​/*
2​* Copyright (C) 2017 by Marco Martin <mart@kde.org>
3​*
4​* This program is free software; you can redistribute it and/or modify
5​* it under the terms of the GNU Library General Public License as
6​* published by the Free Software Foundation; either version 2, or
7​* (at your option) any later version.
8​*
9​* This program is distributed in the hope that it will be useful,
10​* but WITHOUT ANY WARRANTY; without even the implied warranty of
11​* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12​* GNU Library General Public License for more details
13​*
14​* You should have received a copy of the GNU Library General Public
15​* License along with this program; if not, write to the
16​* Free Software Foundation, Inc.,
17​* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18​*/
19​
20​#ifndef FORMLAYOUTATTACHED_H
21​#define FORMLAYOUTATTACHED_H
22​
23​#include <QtQml>
24​#include <QObject>
25​
26​class QQuickItem;
27​
28​class FormLayoutAttached : public QObject
29​{
30​ Q_OBJECT
31​ Q_PROPERTY(QString label READ label WRITE setLabel NOTIFY labelChanged)
32​ Q_PROPERTY(bool isSection READ isSection WRITE setIsSection NOTIFY isSectionChanged)
33​ Q_PROPERTY(QQuickItem *buddyFor READ buddyFor NOTIFY buddyForChanged)
34​
davidedmundsonUnsubmitted
Done

Why would this ever not be the parent? I think having that writable is opening a confusing mess you don't want.

davidedmundson: Why would this ever not be the parent? I think having that writable is opening a confusing mess…
davidedmundsonUnsubmitted
Done

constant

davidedmundson: constant
35​public:
36​
37​ explicit FormLayoutAttached(QObject *parent = 0);
38​ ~FormLayoutAttached();
broulikUnsubmitted
Done

nullptr

broulik: `nullptr`
39​
broulikUnsubmitted
Done

override

broulik: `override`
40​ void setLabel(const QString &text);
41​ QString label() const;
davidedmundsonUnsubmitted
Done

That's a really clever idea; it makes it very flexible so a phone layout could have the labels on top ++++

so I'm a bit surprised that the FormLayout.qml is an object, and not a template; I think it's throwing away an opportunity.

davidedmundson: That's a really clever idea; it makes it very flexible so a phone layout could have the labels…
martAuthorUnsubmitted
Done

at the moment it automatically switches based on the width..
but maybe indeed better to make it a template and force two columns on desktop (on mobile, still automatic i guess, for phone/tablet, or even just portait/landscape phone

mart: at the moment it automatically switches based on the width.. but maybe indeed better to make it…
42​
43​ QString decoratedLabel() const;
44​
45​ void setIsSection(bool section);
46​ bool isSection() const;
47​
48​ QQuickItem *buddyFor() const;
49​
50​ //QML attached property
51​ static FormLayoutAttached *qmlAttachedProperties(QObject *object);
52​
53​Q_SIGNALS:
54​ void labelChanged();
55​ void isSectionChanged();
56​ void buddyForChanged();
57​ void mnemonicChanged();
broulikUnsubmitted
Done

Unused, there's also no property.

broulik: Unused, there's also no property.
martAuthorUnsubmitted
Done

other leftovers, sorry :)

mart: other leftovers, sorry :)
58​ void decoratedLabelChanged();
broulikUnsubmitted
Done

Also unused

broulik: Also unused
59​
60​private:
61​ QString m_label;
62​ QString m_actualDecoratedLabel;
broulikUnsubmitted
Done

Unused

broulik: Unused
63​ QString m_decoratedLabel;
broulikUnsubmitted
Done

Unused

broulik: Unused
64​ QPointer <QQuickItem> m_buddyFor;
65​ bool m_isSection = false;
66​};
67​
68​QML_DECLARE_TYPEINFO(FormLayoutAttached, QML_HAS_ATTACHED_PROPERTIES)
69​
70​#endif // FORMLAYOUTATTACHED_H