Differential D8641 Diff 21840 src/controls/FormLayout.qml

Changeset View

Standalone View

View Options

src/controls/FormLayout.qml

  • This file was added.
1​
2​
3​import QtQuick 2.6
4​import QtQuick.Layouts 1.2
5​import QtQuick.Controls 2.2
6​import org.kde.kirigami 2.3 as Kirigami
7​
8​Control {
davidedmundsonUnsubmitted
Not Done

Why do we inherit from Control?

davidedmundson: Why do we inherit from Control?
martAuthorUnsubmitted
Not Done

I tend to have them controls by default as they have the padding properties that can be very convenient sometimes (as well, if one needs to put a background on the back of it for whatever reason)

mart: I tend to have them controls by default as they have the padding properties that can be very…
9​ id: root
10​ implicitWidth: lay.implicitWidth
11​ implicitHeight: lay.implicitHeight
12​ Layout.preferredHeight: lay.implicitHeight
13​ property bool wideMode: applicationWindow() ? applicationWindow().wideScreen : width > Kirigami.Units.gridUnit * 15
14​
15​ GridLayout {
16​ id: lay
17​ columns: root.wideMode ? 2 : 1
18​ rowSpacing: Kirigami.Units.smallSpacing
19​ columnSpacing: Kirigami.Units.smallSpacing
20​ anchors {
davidedmundsonUnsubmitted
Done

this can be taller than the parent item.

davidedmundson: this can be taller than the parent item.
21​ left: parent.left
22​ top: parent.top
23​ right: parent.right
24​ }
25​ }
26​ default property list<Item> __items
27​ on__ItemsChanged: {
davidedmundsonUnsubmitted
Done

what about when an item gets deleted?

davidedmundson: what about when an item gets deleted?
28​ for (var i = 0; i < __items.length; ++i) {
29​ var item = __items[i];
30​
31​ if (item.parent && item.parent.parent == lay) {
davidedmundsonUnsubmitted
Done

so this is skipping items that are already in here?

davidedmundson: so this is skipping items that are already in here?
32​ continue;
33​ }
34​
35​ var itemContainer = itemComponent.createObject(root, {"item": item})
36​ item.parent = itemContainer;
37​ item.anchors.fill = itemContainer;
38​ //if section, label goes after the separator
39​ if (item.Kirigami.FormData.isSection) {
40​ //put an extra spacer
41​ var placeHolder = placeHolderComponent.createObject(lay);
42​ placeHolder.Layout.colSpan = 2;
43​ placeHolder.parent = lay;
44​ itemContainer.parent = lay;
45​ }
46​
47​ var buddy = buddyComponent.createObject(lay, {"formData": item.Kirigami.FormData})
48​ buddy.parent = lay;
davidedmundsonUnsubmitted
Done

merge

davidedmundson: merge
49​
50​
51​ itemContainer.parent = lay;
52​ //if section, wee need another placeholder
53​ if (item.Kirigami.FormData.isSection) {
54​ var placeHolder = placeHolderComponent.createObject(lay);
55​ placeHolder.parent = lay;
56​ }
57​ }
58​ }
59​ Component.onCompleted: __itemsChanged()
60​ Component {
61​ id: itemComponent
62​ Item {
63​ property var item
64​ implicitWidth: item.implicitWidth
65​ Layout.preferredHeight: Math.max(item.Layout.preferredHeight, item.implicitHeight)
66​
67​ Layout.alignment: (root.wideMode ? Qt.AlignLeft : Qt.AlignHCenter) | Qt.AlignVCenter
68​ Layout.fillWidth: item.Kirigami.FormData.isSection
69​ Layout.columnSpan: item.Kirigami.FormData.isSection ? lay.columns : 1
70​ }
71​ }
72​ Component {
73​ id: placeHolderComponent
74​ Item {
75​ width: Kirigami.Units.smallSpacing
76​ height: Kirigami.Units.smallSpacing
77​ }
78​ }
79​ Component {
80​ id: buddyComponent
81​ Label {
82​ property var formData
83​ width: 1
davidedmundsonUnsubmitted
Done

If you're doing a hack round something, document what.

davidedmundson: If you're doing a hack round something, document what.
84​ text: formData.label
85​
86​ font.pointSize: formData.isSection ? Kirigami.Theme.defaultFont.pointSize * 1.2 : Kirigami.Theme.defaultFont.pointSize
davidedmundsonUnsubmitted
Done

We have an entire KCM with fonts where you can customise everything.

Then we ignore it and hardcode a bunch of them. The end result is we have complexity and don't even use it.

davidedmundson: We have an entire KCM with fonts where you can customise everything. Then we ignore it and…
87​ font.weight: formData.isSection ? Font.Light : Font.Normal
88​
89​ Layout.preferredHeight: formData.label.length > 0 ? implicitHeight : Kirigami.Units.smallSpacing
90​ Layout.alignment: (root.wideMode ? Qt.AlignRight : Qt.AlignLeft) | (formData.buddyFor.height > height * 2 ? Qt.AlignTop : Qt.AlignVCenter)
91​ Layout.topMargin: formData.buddyFor.height > height * 2 ? Kirigami.Units.smallSpacing : 0
92​ }
93​ }
94​}