Differential D1230 Diff 21211 plugins/platforms/drm/egl_gbm_backend.cpp

Changeset View

Standalone View

View Options

plugins/platforms/drm/egl_gbm_backend.cpp

Context not available.
126 initKWinGL(); 126​ initKWinGL();
127 initBufferAge(); 127​ initBufferAge();
128 initWayland(); 128​ initWayland();
129​ initRemotePresent();
129} 130​}
130 131​
131bool EglGbmBackend::initRenderingContext() 132​bool EglGbmBackend::initRenderingContext()
Context not available.
150 return makeContextCurrent(m_outputs.first()); 151​ return makeContextCurrent(m_outputs.first());
151} 152​}
152 153​
154​void EglGbmBackend::initRemotePresent()
155​{
156​ if (!qEnvironmentVariableIsSet("KWIN_REMOTE"))
157​ return;
158​
159​ qCDebug(KWIN_DRM) << "Support for remote access enabled";
160​ m_remoteaccessManager.reset(new RemoteAccessManager);
romanggUnsubmitted
Done

Should be the default not directly activated remote funcitonality? And if one wants to deactivate remote set KWIN_NO_REMOTE or something.

romangg: Should be the default not directly activated remote funcitonality? And if one wants to…
KanediasAuthorUnsubmitted
Not Done

There's no authentication protocol, so any malicious application can get whole screencast for free.
But that's another story as we're getting full input control already in fakeinput-protocol.
Changed.

Kanedias: There's no authentication protocol, so any malicious application can get whole screencast for…
romanggUnsubmitted
Not Done

Use braces: https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces

romangg: Use braces: https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces
161​}
162​
153void EglGbmBackend::createOutput(DrmOutput *drmOutput) 163​void EglGbmBackend::createOutput(DrmOutput *drmOutput)
154{ 164​{
155 Output o; 165​ Output o;
davidedmundsonUnsubmitted
Done

you can do
bool foo =qEnvironmentVariableIsSet("");

davidedmundson: you can do bool foo =qEnvironmentVariableIsSet("");
Context not available.
239{ 249​{
240 eglSwapBuffers(eglDisplay(), o.eglSurface); 250​ eglSwapBuffers(eglDisplay(), o.eglSurface);
241 o.buffer = m_backend->createBuffer(o.gbmSurface); 251​ o.buffer = m_backend->createBuffer(o.gbmSurface);
252​ if(m_remoteaccessManager && gbm_surface_has_free_buffers(o.gbmSurface->surface())) {
253​ // GBM surface is released on page flip so
254​ // we should pass the buffer before it's presented
255​ m_remoteaccessManager->passBuffer(o.output, o.buffer);
256​ }
242 m_backend->present(o.buffer, o.output); 257​ m_backend->present(o.buffer, o.output);
258​
243 if (supportsBufferAge()) { 259​ if (supportsBufferAge()) {
244 eglQuerySurface(eglDisplay(), o.eglSurface, EGL_BUFFER_AGE_EXT, &o.bufferAge); 260​ eglQuerySurface(eglDisplay(), o.eglSurface, EGL_BUFFER_AGE_EXT, &o.bufferAge);
245 } 261​ }
Context not available.