Differential D5932 Diff 20969 kcms/nightcolor/package/contents/ui/LocationsAutoView.qml

Changeset View

Standalone View

View Options

kcms/nightcolor/package/contents/ui/LocationsAutoView.qml

  • This file was added.
1​/********************************************************************
2​Copyright 2017 Roman Gilg <subdiff@gmail.com>
3​
4​This program is free software; you can redistribute it and/or modify
5​it under the terms of the GNU General Public License as published by
6​the Free Software Foundation; either version 2 of the License, or
7​(at your option) any later version.
8​
9​This program is distributed in the hope that it will be useful,
10​but WITHOUT ANY WARRANTY; without even the implied warranty of
11​MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12​GNU General Public License for more details.
13​
14​You should have received a copy of the GNU General Public License
15​along with this program. If not, see <http://www.gnu.org/licenses/>.
16​*********************************************************************/
17​import QtQuick 2.1
18​import QtQuick.Layouts 1.1
19​import QtQuick.Controls 1.4 as Controls
20​
21​GridLayout {
22​ columns: 2
davidedmundsonUnsubmitted
Done

you shouldn't be using Plasma Components in KCMs. Use QQC directly.

Plasma Components follow the plasma theme which can lead to a white text on white situation.

davidedmundson: you shouldn't be using Plasma Components in KCMs. Use QQC directly. Plasma Components follow…
23​ rowSpacing: units.smallSpacing
24​ columnSpacing: units.smallSpacing
25​ enabled: activator.checked
26​
27​ Controls.Label {
28​ text: i18n("Latitude")
29​ Layout.alignment: Qt.AlignRight
lueckUnsubmitted
Done

in CMakelists.txt you set the domain already to "kcm_nightcolor", therefore the i18nd call should be replaced by i18n() calls
that is less error prone if a catalogs has to be renamed.

lueck: in CMakelists.txt you set the domain already to "kcm_nightcolor", therefore the i18nd call…
30​ enabled: false
31​ }
32​ NumberField {
33​ id: latitudeField
34​ backend: locator.latitude
35​ enabled: false
36​ }
37​ Controls.Label {
38​ text: i18n("Longitude")
39​ Layout.alignment: Qt.AlignRight
40​ enabled: false
41​ }
42​ NumberField {
43​ id: longitudeField
44​ backend: locator.longitude
45​ enabled: false
46​ }
47​}