Differential D8059 Diff 20585 kdevplatform/project/projectwatcher.cpp

Changeset View

Standalone View

View Options

kdevplatform/project/projectwatcher.cpp

  • This file was added.
1​/***************************************************************************
2​ * This file is part of KDevelop *
3​ * Copyright 2017 René Bertin <rjvbertin@gmail.com> *
4​ * *
5​ * This program is free software; you can redistribute it and/or modify *
6​ * it under the terms of the GNU Library General Public License as *
7​ * published by the Free Software Foundation; either version 2 of the *
8​ * License, or (at your option) any later version. *
9​ * *
10​ * This program is distributed in the hope that it will be useful, *
11​ * but WITHOUT ANY WARRANTY; without even the implied warranty of *
12​ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
13​ * GNU General Public License for more details. *
14​ * *
15​ * You should have received a copy of the GNU Library General Public *
16​ * License along with this program; if not, write to the *
17​ * Free Software Foundation, Inc., *
18​ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. *
19​ ***************************************************************************/
20​
21​#include "projectwatcher.h"
22​#include "iproject.h"
23​#include "projectfiltermanager.h"
24​#include "path.h"
25​
26​#include <KDirWatch>
27​
28​using namespace KDevelop;
29​
30​KDevelop::ProjectWatcher::ProjectWatcher(IProject* project, ProjectFilterManager* filter)
31​ : KDirWatch(project)
32​ , m_project(project)
33​ , m_filter(filter)
34​ , m_watchedCount(0)
35​{}
36​
37​void KDevelop::ProjectWatcher::addDir(const QString& path, WatchModes watchModes)
38​{
39​ if (m_filter->isValid(Path(path), true, m_project) && !contains(path)) {
mwolffUnsubmitted
Done

this filter check here is conceptually different functionality compared to before. I'm not saying it's a bad change, but it makes this patch do more than just adding a benchmark. Please split your patches up to make it easier to review _and_ to keep the history sane.

Splitting up this patch that way will also allow us to assess the impact of this change.

mwolff: this filter check here is conceptually different functionality compared to before. I'm not…
40​ KDirWatch::addDir(path, watchModes);
41​ m_watchedCount += 1;
42​ }
43​}
44​
45​void KDevelop::ProjectWatcher::removeDir(const QString& path)
46​{
47​ if (contains(path)) {
48​ KDirWatch::removeDir(path);
49​ m_watchedCount -= 1;
50​ }
51​}
52​
53​int KDevelop::ProjectWatcher::size() const
54​{
55​ return m_watchedCount;
56​}
57​