Changeset View
Changeset View
Standalone View
Standalone View
src/core/slavebase.h
Show First 20 Lines • Show All 929 Lines • ▼ Show 20 Line(s) | 886 | #endif | |||
---|---|---|---|---|---|
930 | */ | 930 | */ | ||
931 | void lookupHost(const QString &host); | 931 | void lookupHost(const QString &host); | ||
932 | 932 | | |||
933 | /** Internally used | 933 | /** Internally used | ||
934 | * @internal | 934 | * @internal | ||
935 | */ | 935 | */ | ||
936 | int waitForHostInfo(QHostInfo &info); | 936 | int waitForHostInfo(QHostInfo &info); | ||
937 | 937 | | |||
938 | /** | ||||
939 | * Checks with job if privilege operation is allowed. | ||||
dfaure: missing @since 5.38, BTW | |||||
940 | * @return privilege operation status. | ||||
Four? I count only three. No need to duplicate the full enum docu anyway, it's bound to go out-of-date at some point, just refer to the enum. dfaure: Four? I count only three. No need to duplicate the full enum docu anyway, it's bound to go out… | |||||
941 | * @see PrivilegeOperationStatus | ||||
It's not similar to data(), it doesn't send data from the file being read ;-) Please remove that sentence from the docu, and rename the signal (see D6832). dfaure: It's not similar to data(), it doesn't send data from the file being read ;-)
Please remove… | |||||
942 | * @since 5.38 | ||||
943 | */ | ||||
944 | PrivilegeOperationStatus requestPrivilegeOperation(); | ||||
If it returns an int, it can't really be named "isSomething" anymore, which is for boolean methods. "Is this allowed?" "2" doesn't really work. Can't this return an enum type rather than an int? dfaure: If it returns an int, it can't really be named "isSomething" anymore, which is for boolean… | |||||
945 | | ||||
938 | protected: | 946 | protected: | ||
939 | /** | 947 | /** | ||
940 | * Name of the protocol supported by this slave | 948 | * Name of the protocol supported by this slave | ||
941 | */ | 949 | */ | ||
942 | QByteArray mProtocol; | 950 | QByteArray mProtocol; | ||
943 | //Often used by TcpSlaveBase and unlikely to change | 951 | //Often used by TcpSlaveBase and unlikely to change | ||
944 | MetaData mOutgoingMetaData; | 952 | MetaData mOutgoingMetaData; | ||
945 | MetaData mIncomingMetaData; | 953 | MetaData mIncomingMetaData; | ||
Show All 26 Lines |
missing @since 5.38, BTW