Differential D7847 Diff 19584 src/panels/terminal/terminalpanel.cpp

Changeset View

Standalone View

View Options

src/panels/terminal/terminalpanel.cpp

Context not available.
54{ 54​{
55} 55​}
56 56​
57​void TerminalPanel::goHome()
58​{
59​ sendCdToTerminal(QDir::homePath(), false);
60​}
61​
62​QString TerminalPanel::currentWorkingDirectory()
63​{
64​ if (m_terminal) {
65​ return m_terminal->currentWorkingDirectory();
66​ }
67​ return QStringLiteral("");
elvisangelaccioUnsubmitted
Done

Prefer QString().

elvisangelaccio: Prefer `QString()`.
68​}
69​
57void TerminalPanel::terminalExited() 70​void TerminalPanel::terminalExited()
58{ 71​{
59 m_terminal = 0; 72​ m_terminal = 0;
Context not available.
144 } 157​ }
145} 158​}
146 159​
147void TerminalPanel::sendCdToTerminal(const QString& dir) 160​void TerminalPanel::sendCdToTerminal(const QString& dir, bool addToHistory)
148{ 161​{
149 if (dir == m_konsolePartCurrentDirectory) { 162​ if (dir == m_konsolePartCurrentDirectory) {
150 m_clearTerminal = false; 163​ m_clearTerminal = false;
Context not available.
168 // the directory change, because this directory change is not caused by a "cd" command that the 181​ // the directory change, because this directory change is not caused by a "cd" command that the
169 // user entered in the panel. Therefore, we have to remember 'dir'. Note that it could also be 182​ // user entered in the panel. Therefore, we have to remember 'dir'. Note that it could also be
170 // a symbolic link -> remember the 'canonical' path. 183​ // a symbolic link -> remember the 'canonical' path.
171 m_sendCdToTerminalHistory.enqueue(QDir(dir).canonicalPath()); 184​ if (addToHistory) {
185​ m_sendCdToTerminalHistory.enqueue(QDir(dir).canonicalPath());
186​ }
172 187​
173 if (m_clearTerminal) { 188​ if (m_clearTerminal) {
174 m_terminal->sendInput(QStringLiteral(" clear\n")); 189​ m_terminal->sendInput(QStringLiteral(" clear\n"));
Context not available.