Home
Phabricator
Search
Log In
Differential
D7453
Diff 18593
src/apps/marble-maps/Bookmarks.qml
Changeset View
I know it's not directly part of this patchset, but I'd still like to mention it:
It's relatively unusual to have visual items inside a MouseArea and semantically it's pretty odd: The object hierarchy should also always reflect the semantics in order to keep good modularity: The delegate here is not primarily an "extended MouseArea" so the MouseArea should not be the root item. You could either put the MouseArea as a child inside the SwipeDelegate (but I guess input handling will interfere then) OR you add it as a sibling next to the SwipeDelegate.