Differential D7382 Diff 18578 generators/markdown/converter.cpp

Changeset View

Standalone View

View Options

generators/markdown/converter.cpp

  • This file was added.
1​/***************************************************************************
2​ * Copyright (C) 2017 by Julian Wolff <wolff@julianwolff.de> *
3​ * *
4​ * This program is free software; you can redistribute it and/or modify *
5​ * it under the terms of the GNU General Public License as published by *
6​ * the Free Software Foundation; either version 2 of the License, or *
7​ * (at your option) any later version. *
8​ ***************************************************************************/
9​
10​#include "converter.h"
11​
12​#include <KLocalizedString>
13​
14​#include <QTemporaryFile>
15​#include <QTextDocument>
16​#include <QTextStream>
17​#include <QTextFrame>
18​#include <QTextCursor>
19​
20​#include <core/action.h>
21​
22​#include "debug_md.h"
23​
24​extern "C" {
25​#include <mkdio.h>
26​}
27​
28​// older versions of discount might not have these flags.
29​// defining them to 0 allows us to convert without them
30​#ifndef MKD_FENCEDCODE
31​#define MKD_FENCEDCODE 0
32​#endif
33​
34​#ifndef MKD_GITHUBTAGS
35​#define MKD_GITHUBTAGS 0
36​#endif
37​
38​#ifndef MKD_AUTOLINK
39​#define MKD_AUTOLINK 0
40​#endif
41​
42​using namespace Markdown;
aacidUnsubmitted
Not Done

You probably want toLocal8Bit here

aacid: You probably want toLocal8Bit here
43​
44​Converter::Converter()
45​: mTextDocument(nullptr)
46​{
47​}
48​
49​Converter::~Converter()
50​{
51​}
52​
53​QTextDocument* Converter::convert( const QString &fileName )
54​{
55​ FILE *markdownFile = fopen( fileName.toLocal8Bit(), "rb" );
56​ mDir = QDir( fileName.left( fileName.lastIndexOf( '/' ) ) );
57​
aacidUnsubmitted
Not Done

Have you tried mkd_document so we don't need a temp file?

aacid: Have you tried mkd_document so we don't need a temp file?
progwolffAuthorUnsubmitted
Not Done

I played around with this function, but could not get it to work. I'll take a deeper look into the source files of discount tomorrow, to check if we can get rid of the temporary file.

progwolff: I played around with this function, but could not get it to work. I'll take a deeper look into…
58​ MMIOT *markdownHandle = mkd_in( markdownFile, 0 );
aacidUnsubmitted
Not Done

980x1307 is an interesting size, any specific reaosn you choose that one?

aacid: 980x1307 is an interesting size, any specific reaosn you choose that one?
progwolffAuthorUnsubmitted
Not Done

980 is the width github uses to show README.md documents. This means many documents will be optimized for this width.
980x1307 then matches the aspect ratio of 600x800, wich is used by other generators.

progwolff: 980 is the width github uses to show README.md documents. This means many documents will be…
59​
60​ if ( !mkd_compile( markdownHandle, MKD_FENCEDCODE | MKD_GITHUBTAGS | MKD_AUTOLINK ) ) {
61​ emit error( i18n( "Failed to compile markdown document!" ), -1 );
62​ return 0;
63​ }
64​
65​ char *htmlDocument;
66​ int size = mkd_document( markdownHandle, &htmlDocument );
67​
68​ QString html = QString::fromUtf8( htmlDocument, size );
69​
70​ mTextDocument = new QTextDocument;
71​ mTextDocument->setPageSize( QSizeF( 980, 1307 ) );
72​ mTextDocument->setHtml( html );
73​
74​ mkd_cleanup( markdownHandle );
75​
76​ QTextFrameFormat frameFormat;
77​ frameFormat.setMargin( 45 );
78​
79​ QTextFrame *rootFrame = mTextDocument->rootFrame();
80​ rootFrame->setFrameFormat( frameFormat );
81​
82​ convertLinks();
83​ convertImages();
84​
85​ return mTextDocument;
86​}
87​
88​void Converter::convertLinks()
89​{
90​ convertLinks( mTextDocument->rootFrame() );
91​}
92​
93​
94​void Converter::convertLinks(QTextFrame * parent)
95​{
96​ for ( QTextFrame::iterator it = parent->begin(); !it.atEnd(); ++it ) {
97​ QTextFrame *textFrame = it.currentFrame();
98​ QTextBlock textBlock = it.currentBlock();
99​
100​ if ( textFrame ) {
101​ convertLinks(textFrame);
102​ }
103​ else if ( textBlock.isValid() ) {
104​ convertLinks(textBlock);
105​ }
106​ }
107​}
108​
109​void Converter::convertLinks(QTextBlock & parent)
110​{
111​ for ( QTextBlock::iterator it = parent.begin(); !it.atEnd(); ++it ) {
112​ QTextFragment textFragment = it.fragment();
113​ if ( textFragment.isValid() ) {
114​ QTextCharFormat textCharFormat = textFragment.charFormat();
115​ if ( textCharFormat.isAnchor() ) {
116​ Okular::BrowseAction *action = new Okular::BrowseAction( QUrl( textCharFormat.anchorHref() ) );
117​ emit addAction( action, textFragment.position(), textFragment.position()+textFragment.length()-1 );
aacidUnsubmitted
Not Done

Can you double check this -1?

If i enable the draw borders around links in the accessibility settings i see the link ends one character earlier than it should, no idea if this is this -1 but i did a random guess :D

aacid: Can you double check this -1? If i enable the draw borders around links in the accessibility…
progwolffAuthorUnsubmitted
Not Done

You're right, fixed this.

progwolff: You're right, fixed this.
118​
119​ }
120​ }
121​ }
122​}
123​
124​void Converter::convertImages()
125​{
126​ convertImages( mTextDocument->rootFrame() );
127​}
128​
129​void Converter::convertImages(QTextFrame * parent)
130​{
131​ for ( QTextFrame::iterator it = parent->begin(); !it.atEnd(); ++it ) {
132​ QTextFrame *textFrame = it.currentFrame();
133​ QTextBlock textBlock = it.currentBlock();
134​
135​ if ( textFrame ) {
136​ convertImages(textFrame);
137​ }
138​ else if ( textBlock.isValid() ) {
139​ convertImages(textBlock);
140​ }
141​ }
142​}
143​
144​void Converter::convertImages(QTextBlock & parent)
145​{
146​ for ( QTextBlock::iterator it = parent.begin(); !it.atEnd(); ++it ) {
147​ QTextFragment textFragment = it.fragment();
148​ if ( textFragment.isValid() ) {
149​ QTextCharFormat textCharFormat = textFragment.charFormat();
150​ if( textCharFormat.isImageFormat() ) {
151​
152​ //TODO: Show images from http URIs
153​
154​ QTextImageFormat format;
155​
156​ format.setName( QDir::cleanPath( mDir.absoluteFilePath( textCharFormat.toImageFormat().name() ) ) );
157​ const QImage img = QImage( format.name() );
158​
159​ if ( img.width() > 890 ) {
160​ format.setWidth( 890 );
161​ format.setHeight( img.height() * 890. / img.width() );
162​ }
163​ else {
164​ format.setWidth( img.width() );
165​ format.setHeight( img.height() );
166​ }
167​
168​ QTextCursor cursor( mTextDocument );
169​ cursor.setPosition( textFragment.position(), QTextCursor::MoveAnchor );
170​ cursor.setPosition( textFragment.position() + textFragment.length(), QTextCursor::KeepAnchor );
171​ cursor.removeSelectedText();
172​ cursor.insertImage( format );
173​
174​ }
175​ }
176​ }
177​}