Differential D7374 Diff 18305 moving_client_x11_filter.cpp

Changeset View

Standalone View

View Options

moving_client_x11_filter.cpp

  • This file was added.
1​/********************************************************************
2​ KWin - the KDE window manager
3​ This file is part of the KDE project.
4​
5​Copyright (C) 2017 Martin Flöser <mgraesslin@kde.org>
6​
7​This program is free software; you can redistribute it and/or modify
8​it under the terms of the GNU General Public License as published by
9​the Free Software Foundation; either version 2 of the License, or
10​(at your option) any later version.
11​
12​This program is distributed in the hope that it will be useful,
13​but WITHOUT ANY WARRANTY; without even the implied warranty of
14​MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15​GNU General Public License for more details.
16​
17​You should have received a copy of the GNU General Public License
18​along with this program. If not, see <http://www.gnu.org/licenses/>.
19​*********************************************************************/
20​#include "moving_client_x11_filter.h"
21​#include "client.h"
22​#include "workspace.h"
23​#include <KKeyServer>
24​#include <xcb/xcb.h>
25​
26​namespace KWin
27​{
28​
29​MovingClientX11Filter::MovingClientX11Filter()
30​ : X11EventFilter(QVector<int>{XCB_KEY_PRESS, XCB_MOTION_NOTIFY, XCB_BUTTON_PRESS, XCB_BUTTON_RELEASE})
31​{
32​}
33​
34​bool MovingClientX11Filter::event(xcb_generic_event_t *event)
35​{
36​ auto client = dynamic_cast<Client*>(workspace()->getMovingClient());
broulikUnsubmitted
Not Done

qobject_cast

broulik: `qobject_cast`
graesslinAuthorUnsubmitted
Not Done

*shrug* honestly I don't see that the one or the other is better. The old code used dynamic_cast and I try to be as close as possible to the old one.

graesslin: *shrug* honestly I don't see that the one or the other is better. The old code used…
martUnsubmitted
Not Done

both are fine, qobject_cast should be a tad faster, so is probably marginally better to change

mart: both are fine, qobject_cast should be a tad faster, so is probably marginally better to change
37​ if (!client) {
38​ return false;
39​ }
40​ auto testWindow = [client, event] (xcb_window_t window) {
41​ return client->moveResizeGrabWindow() == window && client->windowEvent(event);
42​ };
43​
44​ const uint8_t eventType = event->response_type & ~0x80;
45​ switch (eventType) {
46​ case XCB_KEY_PRESS: {
47​ int keyQt;
48​ xcb_key_press_event_t *keyEvent = reinterpret_cast<xcb_key_press_event_t*>(event);
49​ KKeyServer::xcbKeyPressEventToQt(keyEvent, &keyQt);
50​ client->keyPressEvent(keyQt, keyEvent->time);
51​ return true;
52​ }
53​ case XCB_BUTTON_PRESS:
54​ case XCB_BUTTON_RELEASE:
55​ return testWindow(reinterpret_cast<xcb_button_press_event_t*>(event)->event);
56​ case XCB_MOTION_NOTIFY:
57​ return testWindow(reinterpret_cast<xcb_motion_notify_event_t*>(event)->event);
58​ }
59​ return false;
60​}
61​
62​}