Differential D7373 Diff 18303 src/activities/letter-in-word/LetterInWord.qml

Changeset View

Standalone View

View Options

src/activities/letter-in-word/LetterInWord.qml

Context not available.
243 } 243​ }
244 } 244​ }
245 245​
246​ GCText {
jjazeixUnsubmitted
Done

you should use a GCDialogCheckBox instead of directly a GCText

jjazeix: you should use a GCDialogCheckBox instead of directly a GCText
247​ id: easyModeText
248​ color: 'red'
jjazeixUnsubmitted
Done

no need to change the text color

jjazeix: no need to change the text color
249​ text: 'Easy'
jjazeixUnsubmitted
Not Done

qsTr needs to be used for translatable texts.
Easy does not help the child, we should find a more explicit text on what the option does

jjazeix: qsTr needs to be used for translatable texts. Easy does not help the child, we should find a…
250​ anchors {
251​ top: parent.top
252​ right: parent.right
253​ topMargin: 10
254​ rightMargin: 160
255​ }
256​ MouseArea{
257​ anchors.fill: parent
258​ onClicked:{
259​ Activity.easyMode = Activity.easyMode ? false : true;
jjazeixUnsubmitted
Not Done

it should only be changed when clicking on the cross (so in onSaveData).
You should also check that it is well loaded when you start the activity (onLoadData).
Take a look at categorisation for example to be sure you save and load the good js type.

jjazeix: it should only be changed when clicking on the cross (so in onSaveData). You should also check…
260​ easyModeText.text = Activity.easyMode ? 'Normal' : 'Easy'
jjazeixUnsubmitted
Done

you should not change the text directly

jjazeix: you should not change the text directly
261​ Activity.initLevel()
262​ }
263​ }
264​ }
265​
246 BarButton { 266​ BarButton {
247 id: repeatItem 267​ id: repeatItem
248 source: "qrc:/gcompris/src/core/resource/bar_repeat.svg" 268​ source: "qrc:/gcompris/src/core/resource/bar_repeat.svg"
Context not available.