Differential D7231 Diff 18207 src/activities/penalty/Penalty.qml

Changeset View

Standalone View

View Options

src/activities/penalty/Penalty.qml

Context not available.
48 //To enable tapping/clicking on left side of goal 48​ //To enable tapping/clicking on left side of goal
49 Rectangle{ 49​ Rectangle{
jjazeixUnsubmitted
Not Done

coding convention, space between () and { (needs to be updated not only there)
put comment above the function, the name should be more explicit on what the function does

jjazeix: coding convention, space between () and { (needs to be updated not only there) put comment…
50 id: maleft 50​ id: maleft
51 anchors.fill: parent.left 51​ //anchors.fill: parent.left
52 width: 475 52​ width: 475
53 height: 300 53​ height: 300
54 x: 100 54​ x: 100
jjazeixUnsubmitted
Not Done

the code should be factorised, it's the same as above and below. Copy/paste are bad.

jjazeix: the code should be factorised, it's the same as above and below. Copy/paste are bad.
jjazeixUnsubmitted
Not Done

coding rule.
You already initialize it to TOP, just check for "RIGHT" and don't have a default else

jjazeix: coding rule. You already initialize it to TOP, just check for "RIGHT" and don't have a default…
jjazeixUnsubmitted
Not Done

is it necessary to check this and the button list below?
The only accepted buttons are these 3 so I don't think it's necessary and the mouse.button should always exist.

jjazeix: is it necessary to check this and the button list below? The only accepted buttons are these 3…
jjazeixUnsubmitted
Not Done

do you need to store it in local or can't you directly pass it to the function and store it in ball.state?

jjazeix: do you need to store it in local or can't you directly pass it to the function and store it in…
jjazeixUnsubmitted
Not Done

where does this value comes from? Is it the same on every screen resolutions or should it be relative to it?

jjazeix: where does this value comes from? Is it the same on every screen resolutions or should it be…
jjazeixUnsubmitted
Not Done

harcoded values?

jjazeix: harcoded values?
Context not available.
155 //To enable tapping/clicking on right side of goal 155​ //To enable tapping/clicking on right side of goal
156 Rectangle{ 156​ Rectangle{
157 id: maright 157​ id: maright
158 anchors.fill: parent.right 158​ //anchors.fill: parent.right
159 width: 475 159​ width: 475
160 height: 300 160​ height: 300
161 x: 800 161​ x: 800
Context not available.
jjazeixUnsubmitted
Not Done

is it still useful (I haven't read the full code but it seems to be the previous MouseArea for the whole screen)?

jjazeix: is it still useful (I haven't read the full code but it seems to be the previous MouseArea for…
jjazeixUnsubmitted
Done

I guess we can keep the previous final positions, no need to add random

jjazeix: I guess we can keep the previous final positions, no need to add random