Differential D7094 Diff 17911 modules/ECMFindQMLModule.cmake.in

Changeset View

Standalone View

View Options

modules/ECMFindQMLModule.cmake.in

  • This file was added.
1​#=============================================================================
2​# Copyright 2015 Aleix Pol Gonzalez <aleixpol@blue-systems.com>
3​#
4​# Redistribution and use in source and binary forms, with or without
5​# modification, are permitted provided that the following conditions
6​# are met:
7​#
8​# 1. Redistributions of source code must retain the copyright
9​# notice, this list of conditions and the following disclaimer.
10​# 2. Redistributions in binary form must reproduce the copyright
11​# notice, this list of conditions and the following disclaimer in the
12​# documentation and/or other materials provided with the distribution.
13​# 3. The name of the author may not be used to endorse or promote products
14​# derived from this software without specific prior written permission.
15​#
16​# THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
17​# IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
18​# OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
19​# IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
20​# INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
21​# NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
22​# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
23​# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
24​# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
25​# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
26​#=============================================================================
27​
28​include(FindPackageHandleStandardArgs)
29​
30​find_program(QMLPLUGINDUMP_PROGRAM qmlplugindump)
31​execute_process(COMMAND "${QMLPLUGINDUMP_PROGRAM}" "@MODULE_NAME@" "@VERSION@" ERROR_VARIABLE ERRORS_OUTPUT OUTPUT_VARIABLE DISREGARD_VARIABLE RESULT_VARIABLE ExitCode)
sitterUnsubmitted
Done

Not sure if we have a common practice for this, but I am thinking this needs to have a find_program() and give suitable output if qmlplugindump itself cannot be found. Pointing the user towards qtdeclarative being needed to check qml dependencies.

sitter: Not sure if we have a common practice for this, but I am thinking this needs to have a…
apolAuthorUnsubmitted
Not Done

Doing find_program for now. The right fix would be to change Qt to export the qmlplugindump target.

apol: Doing find_program for now. The right fix would be to change Qt to export the `qmlplugindump`…
sitterUnsubmitted
Not Done

You still need to do "something" if qmlplugindump isn't found. Print a message(WARNING and/or add_feature_info or something similar.
Right now the code would mark the plugin not found but not tell the user that the reason it was not found is that the helper is missing.

e.g. here kirigami is actually installed but qmlplugindump is not:

 10:45:09  /tmp/t/b 
$ cmake ..
-- The C compiler identification is GNU 5.4.0
-- The CXX compiler identification is GNU 5.4.0
-- Check for working C compiler: /usr/lib/icecc/bin/gcc
-- Check for working C compiler: /usr/lib/icecc/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/lib/icecc/bin/g++
-- Check for working CXX compiler: /usr/lib/icecc/bin/g++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- qmlplugindump failed for org.kde.kirigami.
-- Could NOT find org.kde.kirigami-QMLModule (missing:  org.kde.kirigami-QMLModule_FOUND) 
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/t/b

 10:45:12  /tmp/t/b 
$ cat ../CMakeLists.txt 
project(test)
cmake_minimum_required(VERSION 3.5)

find_package(ECM 1.3.0 REQUIRED NO_MODULE)
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${ECM_MODULE_PATH})

include(ECMQMLModules)
ecm_find_qmlmodule(org.kde.kirigami 2.1)
sitter: You still need to do "something" if qmlplugindump isn't found. Print a `message(WARNING` and/or…
32​
33​if(ExitCode EQUAL 0)
34​ set(@GENMODULE@_FOUND TRUE)
35​ set(@GENMODULE@_VERSION "${PACKAGE_FIND_VERSION}")
36​else()
37​ message(STATUS "qmlplugindump failed for @MODULE_NAME@.")
38​ set(@GENMODULE@_FOUND FALSE)
39​endif()
40​
41​find_package_handle_standard_args(@GENMODULE@
42​ FOUND_VAR
43​ @GENMODULE@_FOUND
44​ REQUIRED_VARS
45​ @GENMODULE@_FOUND
46​ VERSION_VAR
47​ @GENMODULE@_VERSION
48​ HANDLE_COMPONENTS
49​)
50​
51​